* [PATCH 0/1] Fix HW SAVEANDRESTORE shift define
@ 2009-04-01 6:42 Kalle Jokiniemi
2009-04-01 6:42 ` [PATCH] ARM: OMAP3: " Kalle Jokiniemi
0 siblings, 1 reply; 5+ messages in thread
From: Kalle Jokiniemi @ 2009-04-01 6:42 UTC (permalink / raw)
To: tony, linux-omap; +Cc: khilman
Here's a patch that fixes a bug in enabling and disabling hardware
save-and-restore functionality in powerdomain.c code.
This affects power management, as it also fixes a hw bug in off-mode,
but I think this should be applied directly to linux-omap. As this
part of code is already there and its setting up wrong bits in
PM_PWSTCTRL registers.
Kalle Jokiniemi (1):
ARM: OMAP3: Fix HW SAVEANDRESTORE shift define
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: OMAP3: Fix HW SAVEANDRESTORE shift define
2009-04-01 6:42 [PATCH 0/1] Fix HW SAVEANDRESTORE shift define Kalle Jokiniemi
@ 2009-04-01 6:42 ` Kalle Jokiniemi
2009-04-01 18:52 ` Kevin Hilman
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Kalle Jokiniemi @ 2009-04-01 6:42 UTC (permalink / raw)
To: tony, linux-omap; +Cc: khilman, Kalle Jokiniemi
The OMAP3430ES2_SAVEANDRESTORE_SHIFT macro is used
by powerdomain code in
"1 << OMAP3430ES2_SAVEANDRESTORE_SHIFT" manner, but
the definition was also (1 << 4), meaning we actually
modified bit 16. So the definition needs to be 4.
This fixes also a cold reset HW bug in OMAP3430 ES3.x
where some of the efuse bits are not isolated during
wake-up from off mode. This can cause randomish
cold resets with off mode. Enabling the USBTLL hardware
SAVEANDRESTORE causes the core power up assert to be
delayed in a way that we will not get faulty values
when boot ROM is reading the unisolated registers.
Signed-off-by: Kalle Jokiniemi <kalle.jokiniemi@digia.com>
---
arch/arm/mach-omap2/prm-regbits-34xx.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/prm-regbits-34xx.h b/arch/arm/mach-omap2/prm-regbits-34xx.h
index d73eee8..d792c29 100644
--- a/arch/arm/mach-omap2/prm-regbits-34xx.h
+++ b/arch/arm/mach-omap2/prm-regbits-34xx.h
@@ -409,7 +409,7 @@
/* PM_PREPWSTST_CAM specific bits */
/* PM_PWSTCTRL_USBHOST specific bits */
-#define OMAP3430ES2_SAVEANDRESTORE_SHIFT (1 << 4)
+#define OMAP3430ES2_SAVEANDRESTORE_SHIFT 4
/* RM_RSTST_PER specific bits */
--
1.5.4.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: OMAP3: Fix HW SAVEANDRESTORE shift define
2009-04-01 6:42 ` [PATCH] ARM: OMAP3: " Kalle Jokiniemi
@ 2009-04-01 18:52 ` Kevin Hilman
2009-04-01 19:05 ` Paul Walmsley
2009-05-14 16:53 ` [APPLIED] " Tony Lindgren
2 siblings, 0 replies; 5+ messages in thread
From: Kevin Hilman @ 2009-04-01 18:52 UTC (permalink / raw)
To: Kalle Jokiniemi; +Cc: tony, linux-omap
Kalle Jokiniemi <kalle.jokiniemi@digia.com> writes:
> The OMAP3430ES2_SAVEANDRESTORE_SHIFT macro is used
> by powerdomain code in
> "1 << OMAP3430ES2_SAVEANDRESTORE_SHIFT" manner, but
> the definition was also (1 << 4), meaning we actually
> modified bit 16. So the definition needs to be 4.
>
> This fixes also a cold reset HW bug in OMAP3430 ES3.x
> where some of the efuse bits are not isolated during
> wake-up from off mode. This can cause randomish
> cold resets with off mode. Enabling the USBTLL hardware
> SAVEANDRESTORE causes the core power up assert to be
> delayed in a way that we will not get faulty values
> when boot ROM is reading the unisolated registers.
>
> Signed-off-by: Kalle Jokiniemi <kalle.jokiniemi@digia.com>
Acked-by: Kevin Hilman <khilman@deeprootsystems.com>
> ---
> arch/arm/mach-omap2/prm-regbits-34xx.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/prm-regbits-34xx.h b/arch/arm/mach-omap2/prm-regbits-34xx.h
> index d73eee8..d792c29 100644
> --- a/arch/arm/mach-omap2/prm-regbits-34xx.h
> +++ b/arch/arm/mach-omap2/prm-regbits-34xx.h
> @@ -409,7 +409,7 @@
> /* PM_PREPWSTST_CAM specific bits */
>
> /* PM_PWSTCTRL_USBHOST specific bits */
> -#define OMAP3430ES2_SAVEANDRESTORE_SHIFT (1 << 4)
> +#define OMAP3430ES2_SAVEANDRESTORE_SHIFT 4
>
> /* RM_RSTST_PER specific bits */
>
> --
> 1.5.4.3
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: OMAP3: Fix HW SAVEANDRESTORE shift define
2009-04-01 6:42 ` [PATCH] ARM: OMAP3: " Kalle Jokiniemi
2009-04-01 18:52 ` Kevin Hilman
@ 2009-04-01 19:05 ` Paul Walmsley
2009-05-14 16:53 ` [APPLIED] " Tony Lindgren
2 siblings, 0 replies; 5+ messages in thread
From: Paul Walmsley @ 2009-04-01 19:05 UTC (permalink / raw)
To: Kalle Jokiniemi; +Cc: tony, linux-omap, khilman
On Wed, 1 Apr 2009, Kalle Jokiniemi wrote:
> The OMAP3430ES2_SAVEANDRESTORE_SHIFT macro is used
> by powerdomain code in
> "1 << OMAP3430ES2_SAVEANDRESTORE_SHIFT" manner, but
> the definition was also (1 << 4), meaning we actually
> modified bit 16. So the definition needs to be 4.
Thanks Kalle,
Acked-by: Paul Walmsley <paul@pwsan.com>
> diff --git a/arch/arm/mach-omap2/prm-regbits-34xx.h b/arch/arm/mach-omap2/prm-regbits-34xx.h
> index d73eee8..d792c29 100644
> --- a/arch/arm/mach-omap2/prm-regbits-34xx.h
> +++ b/arch/arm/mach-omap2/prm-regbits-34xx.h
> @@ -409,7 +409,7 @@
> /* PM_PREPWSTST_CAM specific bits */
>
> /* PM_PWSTCTRL_USBHOST specific bits */
> -#define OMAP3430ES2_SAVEANDRESTORE_SHIFT (1 << 4)
> +#define OMAP3430ES2_SAVEANDRESTORE_SHIFT 4
>
> /* RM_RSTST_PER specific bits */
>
> --
> 1.5.4.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
- Paul
^ permalink raw reply [flat|nested] 5+ messages in thread
* [APPLIED] [PATCH] ARM: OMAP3: Fix HW SAVEANDRESTORE shift define
2009-04-01 6:42 ` [PATCH] ARM: OMAP3: " Kalle Jokiniemi
2009-04-01 18:52 ` Kevin Hilman
2009-04-01 19:05 ` Paul Walmsley
@ 2009-05-14 16:53 ` Tony Lindgren
2 siblings, 0 replies; 5+ messages in thread
From: Tony Lindgren @ 2009-05-14 16:53 UTC (permalink / raw)
To: linux-omap
This patch has been applied to the linux-omap
by youw fwiendly patch wobot.
Initial commit ID (Likely to change): e2196a74ba4faeb272caef961b22e9ab982fb442
PatchWorks
http://patchwork.kernel.org/patch/15586/
Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=e2196a74ba4faeb272caef961b22e9ab982fb442
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-05-14 16:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-01 6:42 [PATCH 0/1] Fix HW SAVEANDRESTORE shift define Kalle Jokiniemi
2009-04-01 6:42 ` [PATCH] ARM: OMAP3: " Kalle Jokiniemi
2009-04-01 18:52 ` Kevin Hilman
2009-04-01 19:05 ` Paul Walmsley
2009-05-14 16:53 ` [APPLIED] " Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.