* [PATCH] OMAP3: PM: Move the clk stabilization delay to the right place
@ 2009-06-26 11:29 Rajendra Nayak
2009-06-29 23:16 ` Kevin Hilman
2009-07-28 17:18 ` Paul Walmsley
0 siblings, 2 replies; 3+ messages in thread
From: Rajendra Nayak @ 2009-06-26 11:29 UTC (permalink / raw)
To: linux-omap; +Cc: Rajendra Nayak
The clock stabilization delay post a M2 divider change is needed
even before a SDRC interface clock re-enable and not only before
jumping back to SDRAM.
Signed-off-by: Rajendra Nayak <rnayak@ti.com>
---
arch/arm/mach-omap2/sram34xx.S | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/sram34xx.S b/arch/arm/mach-omap2/sram34xx.S
index f41f8d9..481f912 100644
--- a/arch/arm/mach-omap2/sram34xx.S
+++ b/arch/arm/mach-omap2/sram34xx.S
@@ -97,6 +97,8 @@ ENTRY(omap3_sram_configure_core_dpll)
blne lock_dll
bl sdram_in_selfrefresh @ put SDRAM in self refresh, idle SDRC
bl configure_core_dpll @ change the DPLL3 M2 divider
+ mov r12, r5
+ bl wait_clk_stable @ wait for SDRC to stabilize
bl enable_sdrc @ take SDRC out of idle
cmp r4, #SDRC_UNLOCK_DLL @ wait for DLL status to change
bleq wait_dll_unlock
@@ -104,8 +106,6 @@ ENTRY(omap3_sram_configure_core_dpll)
cmp r7, #1 @ if increasing SDRC clk rate,
beq return_to_sdram @ return to SDRAM code, otherwise,
bl configure_sdrc @ reprogram SDRC regs now
- mov r12, r5
- bl wait_clk_stable @ wait for SDRC to stabilize
return_to_sdram:
isb @ prevent speculative exec past here
mov r0, #0 @ return value
--
1.5.4.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] OMAP3: PM: Move the clk stabilization delay to the right place
2009-06-26 11:29 [PATCH] OMAP3: PM: Move the clk stabilization delay to the right place Rajendra Nayak
@ 2009-06-29 23:16 ` Kevin Hilman
2009-07-28 17:18 ` Paul Walmsley
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Hilman @ 2009-06-29 23:16 UTC (permalink / raw)
To: Rajendra Nayak; +Cc: linux-omap
Rajendra Nayak <rnayak@ti.com> writes:
> The clock stabilization delay post a M2 divider change is needed
> even before a SDRC interface clock re-enable and not only before
> jumping back to SDRAM.
>
> Signed-off-by: Rajendra Nayak <rnayak@ti.com>
Thanks, pushing to PM branch (and pm-2.6.29)
Kevin
> ---
> arch/arm/mach-omap2/sram34xx.S | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/sram34xx.S b/arch/arm/mach-omap2/sram34xx.S
> index f41f8d9..481f912 100644
> --- a/arch/arm/mach-omap2/sram34xx.S
> +++ b/arch/arm/mach-omap2/sram34xx.S
> @@ -97,6 +97,8 @@ ENTRY(omap3_sram_configure_core_dpll)
> blne lock_dll
> bl sdram_in_selfrefresh @ put SDRAM in self refresh, idle SDRC
> bl configure_core_dpll @ change the DPLL3 M2 divider
> + mov r12, r5
> + bl wait_clk_stable @ wait for SDRC to stabilize
> bl enable_sdrc @ take SDRC out of idle
> cmp r4, #SDRC_UNLOCK_DLL @ wait for DLL status to change
> bleq wait_dll_unlock
> @@ -104,8 +106,6 @@ ENTRY(omap3_sram_configure_core_dpll)
> cmp r7, #1 @ if increasing SDRC clk rate,
> beq return_to_sdram @ return to SDRAM code, otherwise,
> bl configure_sdrc @ reprogram SDRC regs now
> - mov r12, r5
> - bl wait_clk_stable @ wait for SDRC to stabilize
> return_to_sdram:
> isb @ prevent speculative exec past here
> mov r0, #0 @ return value
> --
> 1.5.4.7
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] OMAP3: PM: Move the clk stabilization delay to the right place
2009-06-26 11:29 [PATCH] OMAP3: PM: Move the clk stabilization delay to the right place Rajendra Nayak
2009-06-29 23:16 ` Kevin Hilman
@ 2009-07-28 17:18 ` Paul Walmsley
1 sibling, 0 replies; 3+ messages in thread
From: Paul Walmsley @ 2009-07-28 17:18 UTC (permalink / raw)
To: Rajendra Nayak; +Cc: linux-omap
On Fri, 26 Jun 2009, Rajendra Nayak wrote:
> The clock stabilization delay post a M2 divider change is needed
> even before a SDRC interface clock re-enable and not only before
> jumping back to SDRAM.
>
> Signed-off-by: Rajendra Nayak <rnayak@ti.com>
For the archives: this patch has been accepted and sent upstream for
2.6.31-rc fixes.
- Paul
> ---
> arch/arm/mach-omap2/sram34xx.S | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/sram34xx.S b/arch/arm/mach-omap2/sram34xx.S
> index f41f8d9..481f912 100644
> --- a/arch/arm/mach-omap2/sram34xx.S
> +++ b/arch/arm/mach-omap2/sram34xx.S
> @@ -97,6 +97,8 @@ ENTRY(omap3_sram_configure_core_dpll)
> blne lock_dll
> bl sdram_in_selfrefresh @ put SDRAM in self refresh, idle SDRC
> bl configure_core_dpll @ change the DPLL3 M2 divider
> + mov r12, r5
> + bl wait_clk_stable @ wait for SDRC to stabilize
> bl enable_sdrc @ take SDRC out of idle
> cmp r4, #SDRC_UNLOCK_DLL @ wait for DLL status to change
> bleq wait_dll_unlock
> @@ -104,8 +106,6 @@ ENTRY(omap3_sram_configure_core_dpll)
> cmp r7, #1 @ if increasing SDRC clk rate,
> beq return_to_sdram @ return to SDRAM code, otherwise,
> bl configure_sdrc @ reprogram SDRC regs now
> - mov r12, r5
> - bl wait_clk_stable @ wait for SDRC to stabilize
> return_to_sdram:
> isb @ prevent speculative exec past here
> mov r0, #0 @ return value
> --
> 1.5.4.7
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
- Paul
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-07-28 17:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-26 11:29 [PATCH] OMAP3: PM: Move the clk stabilization delay to the right place Rajendra Nayak
2009-06-29 23:16 ` Kevin Hilman
2009-07-28 17:18 ` Paul Walmsley
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.