All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] OMAP3: clock: fix enable bit used for dpll4_m4x2 clock
@ 2010-03-26  4:55 Ranjith Lohithakshan
  2010-03-30  7:34 ` Paul Walmsley
  0 siblings, 1 reply; 2+ messages in thread
From: Ranjith Lohithakshan @ 2010-03-26  4:55 UTC (permalink / raw)
  To: linux-omap; +Cc: paul, ranjithl

The enable bit for dpll4_m4x2 clock should be OMAP3430_PWRDN_DSS1_SHIFT.
The code erroneously uses OMAP3430_PWRDN_CAM_SHIFT which is meant for
dpll4_m5x2 clock.

This came into notice during a recent review of the clock tree.

Signed-off-by: Ranjith Lohithakshan <ranjithl@ti.com>
---
 arch/arm/mach-omap2/clock3xxx_data.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/clock3xxx_data.c b/arch/arm/mach-omap2/clock3xxx_data.c
index d5153b6..9cba556 100644
--- a/arch/arm/mach-omap2/clock3xxx_data.c
+++ b/arch/arm/mach-omap2/clock3xxx_data.c
@@ -895,7 +895,7 @@ static struct clk dpll4_m4x2_ck = {
 	.ops		= &clkops_omap2_dflt_wait,
 	.parent		= &dpll4_m4_ck,
 	.enable_reg	= OMAP_CM_REGADDR(PLL_MOD, CM_CLKEN),
-	.enable_bit	= OMAP3430_PWRDN_CAM_SHIFT,
+	.enable_bit	= OMAP3430_PWRDN_DSS1_SHIFT,
 	.flags		= INVERT_ENABLE,
 	.clkdm_name	= "dpll4_clkdm",
 	.recalc		= &omap3_clkoutx2_recalc,
-- 
1.6.2.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] OMAP3: clock: fix enable bit used for dpll4_m4x2 clock
  2010-03-26  4:55 [PATCH] OMAP3: clock: fix enable bit used for dpll4_m4x2 clock Ranjith Lohithakshan
@ 2010-03-30  7:34 ` Paul Walmsley
  0 siblings, 0 replies; 2+ messages in thread
From: Paul Walmsley @ 2010-03-30  7:34 UTC (permalink / raw)
  To: Ranjith Lohithakshan; +Cc: b-cousson, rnayak, linux-omap

Hi Ranjith,

On Fri, 26 Mar 2010, Ranjith Lohithakshan wrote:

> The enable bit for dpll4_m4x2 clock should be OMAP3430_PWRDN_DSS1_SHIFT.
> The code erroneously uses OMAP3430_PWRDN_CAM_SHIFT which is meant for
> dpll4_m5x2 clock.
> 
> This came into notice during a recent review of the clock tree.
> 
> Signed-off-by: Ranjith Lohithakshan <ranjithl@ti.com>

Thanks, queued for 2.6.34-rcX.


- Paul

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-03-30  7:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-26  4:55 [PATCH] OMAP3: clock: fix enable bit used for dpll4_m4x2 clock Ranjith Lohithakshan
2010-03-30  7:34 ` Paul Walmsley

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.