* libxenlight and xl: missing features
@ 2010-04-22 16:44 Stefano Stabellini
2010-04-22 19:36 ` Dan Magenheimer
2010-04-30 2:26 ` Yu Zhiguo
0 siblings, 2 replies; 7+ messages in thread
From: Stefano Stabellini @ 2010-04-22 16:44 UTC (permalink / raw)
To: xen-devel
Hi all,
this is a non comprehensive list of missing features in libxenlight
and\or xl:
- xen_platform_pci flag support in VM config files;
- relative paths support in VM config files;
- hap support in VM config files;
- -c option to xl create;
- remus;
- trigger command;
- tmem-* commands;
- sched-* commands;
- usb-* commands;
- scsi-* commands.
In general if you execute "xm help" and "xl help" any command presents
in the former but not in the latter is a missing feature.
Few items are known to be "work in progress":
- network-* commands;
- network2-* commands;
- block-* commands;
Feel free to pick the missing command of you choice and write a simple
implementation for it :)
Cheers,
Stefano
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: libxenlight and xl: missing features
2010-04-22 16:44 libxenlight and xl: missing features Stefano Stabellini
@ 2010-04-22 19:36 ` Dan Magenheimer
2010-04-23 11:06 ` Stefano Stabellini
2010-04-30 2:26 ` Yu Zhiguo
1 sibling, 1 reply; 7+ messages in thread
From: Dan Magenheimer @ 2010-04-22 19:36 UTC (permalink / raw)
To: Stefano Stabellini, xen-devel; +Cc: Djm (dan.magenheimer@oracle.com)
I'll try to do the tmem-* commands after Xen Summit.
> -----Original Message-----
> From: Stefano Stabellini [mailto:stefano.stabellini@eu.citrix.com]
> Sent: Thursday, April 22, 2010 10:44 AM
> To: xen-devel@lists.xensource.com
> Subject: [Xen-devel] libxenlight and xl: missing features
>
> Hi all,
> this is a non comprehensive list of missing features in libxenlight
> and\or xl:
>
> - xen_platform_pci flag support in VM config files;
>
> - relative paths support in VM config files;
>
> - hap support in VM config files;
>
> - -c option to xl create;
>
> - remus;
>
> - trigger command;
>
> - tmem-* commands;
>
> - sched-* commands;
>
> - usb-* commands;
>
> - scsi-* commands.
>
>
> In general if you execute "xm help" and "xl help" any command presents
> in the former but not in the latter is a missing feature.
>
> Few items are known to be "work in progress":
>
> - network-* commands;
>
> - network2-* commands;
>
> - block-* commands;
>
>
> Feel free to pick the missing command of you choice and write a simple
> implementation for it :)
>
> Cheers,
>
> Stefano
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: libxenlight and xl: missing features
2010-04-22 19:36 ` Dan Magenheimer
@ 2010-04-23 11:06 ` Stefano Stabellini
2010-05-13 13:47 ` Dan Magenheimer
0 siblings, 1 reply; 7+ messages in thread
From: Stefano Stabellini @ 2010-04-23 11:06 UTC (permalink / raw)
To: Dan Magenheimer; +Cc: xen-devel, Stefano Stabellini
On Thu, 22 Apr 2010, Dan Magenheimer wrote:
> I'll try to do the tmem-* commands after Xen Summit.
Thanks, that would be appreciated :)
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: libxenlight and xl: missing features
2010-04-22 16:44 libxenlight and xl: missing features Stefano Stabellini
2010-04-22 19:36 ` Dan Magenheimer
@ 2010-04-30 2:26 ` Yu Zhiguo
2010-04-30 6:38 ` Stefano Stabellini
1 sibling, 1 reply; 7+ messages in thread
From: Yu Zhiguo @ 2010-04-30 2:26 UTC (permalink / raw)
To: Stefano Stabellini; +Cc: xen-devel, Keir Fraser
Hi Stefano,
Stefano Stabellini wrote:
> Hi all,
> this is a non comprehensive list of missing features in libxenlight
> and\or xl:
>
...
>
> - -c option to xl create;
>
How about the following patch.
* I made it base changeset 21236:9a1d7caa2024.
Regards
Yu Zhiguo
--------------------------------------------------------------
Add option '-c' for 'xl create'
* -c Connect to the console after the domain is created.
Signed-off-by: Yu Zhiguo <yuzg@cn.fujitsu.com>
diff -r 9a1d7caa2024 -r 880b6a219189 tools/libxl/xl.c
--- a/tools/libxl/xl.c Mon Apr 26 12:13:23 2010 +0100
+++ b/tools/libxl/xl.c Fri Apr 30 17:58:25 2010 +0800
@@ -976,7 +976,7 @@
libxl_domain_unpause(&ctx, domid);
if (!daemonize)
- return 0; /* caller gets success in parent */
+ return domid; /* caller gets success in parent */
if (need_daemon) {
char *fullname, *name;
@@ -1000,7 +1000,7 @@
"daemonizing child", child1, status);
return ERROR_FAIL;
}
- return 0; /* caller gets success in parent */
+ return domid; /* caller gets success in parent */
}
rc = libxl_ctx_postfork(&ctx);
@@ -1113,6 +1113,7 @@
printf("Options:\n\n");
printf("-h Print this help.\n");
printf("-p Leave the domain paused after it is created.\n");
+ printf("-c Connect to the console after the domain is created.\n");
printf("-d Enable debug messages.\n");
printf("-e Do not wait in the background for the death of the domain.\n");
} else if(!strcmp(command, "list")) {
@@ -1937,7 +1938,7 @@
0 /* no config file, use incoming */,
"incoming migration stream", 1,
0, &migration_domname);
- if (rc) {
+ if (rc < 0) {
fprintf(stderr, "migration target: Domain creation failed"
" (code %d).\n", rc);
exit(-rc);
@@ -2047,7 +2048,10 @@
}
rc = create_domain(debug, daemonize, config_file,
checkpoint_file, paused, -1, 0);
- exit(-rc);
+ if (rc >= 0)
+ exit(0);
+ else
+ exit(-rc);
}
int main_migrate_receive(int argc, char **argv)
@@ -2291,14 +2295,18 @@
int main_create(int argc, char **argv)
{
char *filename = NULL;
- int paused = 0, debug = 0, daemonize = 1;
+ char dom[10]; /* long enough */
+ int paused = 0, debug = 0, daemonize = 1, console_autoconnect = 0;
int opt, rc;
- while ((opt = getopt(argc, argv, "hdep")) != -1) {
+ while ((opt = getopt(argc, argv, "hpcde")) != -1) {
switch (opt) {
case 'p':
paused = 1;
break;
+ case 'c':
+ console_autoconnect = 1;
+ break;
case 'd':
debug = 1;
break;
@@ -2322,7 +2330,14 @@
filename = argv[optind];
rc = create_domain(debug, daemonize, filename, NULL, paused,
-1, 0);
- exit(-rc);
+ if (rc > 0) {
+ if (console_autoconnect) {
+ snprintf(dom, sizeof(dom), "%d", rc);
+ console(dom, 0);
+ }
+ exit(0);
+ } else
+ exit(-rc);
}
void button_press(char *p, char *b)
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: libxenlight and xl: missing features
2010-04-30 2:26 ` Yu Zhiguo
@ 2010-04-30 6:38 ` Stefano Stabellini
0 siblings, 0 replies; 7+ messages in thread
From: Stefano Stabellini @ 2010-04-30 6:38 UTC (permalink / raw)
To: Yu Zhiguo; +Cc: xen-devel, Keir Fraser, Stefano Stabellini
On Fri, 30 Apr 2010, Yu Zhiguo wrote:
> Hi Stefano,
>
> Stefano Stabellini wrote:
> > Hi all,
> > this is a non comprehensive list of missing features in libxenlight
> > and\or xl:
> >
> ...
> >
> > - -c option to xl create;
> >
>
> How about the following patch.
> * I made it base changeset 21236:9a1d7caa2024.
>
it looks good to me, one less item on the list!
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: libxenlight and xl: missing features
2010-04-23 11:06 ` Stefano Stabellini
@ 2010-05-13 13:47 ` Dan Magenheimer
2010-05-14 3:55 ` Yang Hongyang
0 siblings, 1 reply; 7+ messages in thread
From: Dan Magenheimer @ 2010-05-13 13:47 UTC (permalink / raw)
To: Stefano Stabellini, Yang Hongyang, Eric Chanudet; +Cc: xen-devel
As I have not yet found the time to add the tmem-* commands
to xl, and since others are actively reimplementing all of
the xm commands, I would be grateful if someone would
add in the tmem commands to xl as well. If there are any
difficulties or questions, I would be happy to help.
Thanks in advance,
Dan
> -----Original Message-----
> From: Stefano Stabellini [mailto:stefano.stabellini@eu.citrix.com]
> Sent: Friday, April 23, 2010 5:06 AM
> To: Dan Magenheimer
> Cc: Stefano Stabellini; xen-devel@lists.xensource.com
> Subject: RE: [Xen-devel] libxenlight and xl: missing features
>
> On Thu, 22 Apr 2010, Dan Magenheimer wrote:
> > I'll try to do the tmem-* commands after Xen Summit.
>
> Thanks, that would be appreciated :)
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: libxenlight and xl: missing features
2010-05-13 13:47 ` Dan Magenheimer
@ 2010-05-14 3:55 ` Yang Hongyang
0 siblings, 0 replies; 7+ messages in thread
From: Yang Hongyang @ 2010-05-14 3:55 UTC (permalink / raw)
To: Dan Magenheimer; +Cc: Eric Chanudet, xen-devel, Stefano Stabellini
Hi Dan,
On 05/13/2010 09:47 PM, Dan Magenheimer wrote:
> As I have not yet found the time to add the tmem-* commands
> to xl, and since others are actively reimplementing all of
> the xm commands, I would be grateful if someone would
> add in the tmem commands to xl as well. If there are any
> difficulties or questions, I would be happy to help.
Yu and Me will try to do that. It may take some time for
us to accomplish those tmem-* commands and may ask for your
help when met difficulties.
>
> Thanks in advance,
> Dan
>
>> -----Original Message-----
>> From: Stefano Stabellini [mailto:stefano.stabellini@eu.citrix.com]
>> Sent: Friday, April 23, 2010 5:06 AM
>> To: Dan Magenheimer
>> Cc: Stefano Stabellini; xen-devel@lists.xensource.com
>> Subject: RE: [Xen-devel] libxenlight and xl: missing features
>>
>> On Thu, 22 Apr 2010, Dan Magenheimer wrote:
>>> I'll try to do the tmem-* commands after Xen Summit.
>>
>> Thanks, that would be appreciated :)
>>
>
>
--
Regards
Yang Hongyang
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-05-14 3:55 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-04-22 16:44 libxenlight and xl: missing features Stefano Stabellini
2010-04-22 19:36 ` Dan Magenheimer
2010-04-23 11:06 ` Stefano Stabellini
2010-05-13 13:47 ` Dan Magenheimer
2010-05-14 3:55 ` Yang Hongyang
2010-04-30 2:26 ` Yu Zhiguo
2010-04-30 6:38 ` Stefano Stabellini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.