* [PATCH] gitweb: Don’t die_error in git_tag after already printing headers
@ 2010-08-27 17:38 Anders Kaseorg
2010-08-31 16:19 ` Jakub Narebski
0 siblings, 1 reply; 2+ messages in thread
From: Anders Kaseorg @ 2010-08-27 17:38 UTC (permalink / raw)
To: gitster; +Cc: git
This fixes an XML error when visiting a nonexistent tag
(?p=git.git;a=tag;h=refs/tags/BADNAME).
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
---
gitweb/gitweb.perl | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 84261bb..5dab825 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -5192,15 +5192,15 @@ sub git_summary {
}
sub git_tag {
- my $head = git_get_head_hash($project);
- git_header_html();
- git_print_page_nav('','', $head,undef,$head);
my %tag = parse_tag($hash);
if (! %tag) {
die_error(404, "Unknown tag object");
}
+ my $head = git_get_head_hash($project);
+ git_header_html();
+ git_print_page_nav('','', $head,undef,$head);
git_print_header_div('commit', esc_html($tag{'name'}), $hash);
print "<div class=\"title_text\">\n" .
"<table class=\"object_header\">\n" .
--
1.7.2.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gitweb: Don’t die_error in git_tag after already printing headers
2010-08-27 17:38 [PATCH] gitweb: Don’t die_error in git_tag after already printing headers Anders Kaseorg
@ 2010-08-31 16:19 ` Jakub Narebski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Narebski @ 2010-08-31 16:19 UTC (permalink / raw)
To: Anders Kaseorg; +Cc: gitster, git
Anders Kaseorg <andersk@MIT.EDU> writes:
> This fixes an XML error when visiting a nonexistent tag
> (?p=git.git;a=tag;h=refs/tags/BADNAME).
>
> Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Good catch!
Acked-by: Jakub Narebski <jnareb@gmail.com>
> ---
> gitweb/gitweb.perl | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 84261bb..5dab825 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -5192,15 +5192,15 @@ sub git_summary {
> }
>
> sub git_tag {
> - my $head = git_get_head_hash($project);
> - git_header_html();
> - git_print_page_nav('','', $head,undef,$head);
> my %tag = parse_tag($hash);
>
> if (! %tag) {
> die_error(404, "Unknown tag object");
> }
>
> + my $head = git_get_head_hash($project);
> + git_header_html();
> + git_print_page_nav('','', $head,undef,$head);
> git_print_header_div('commit', esc_html($tag{'name'}), $hash);
> print "<div class=\"title_text\">\n" .
> "<table class=\"object_header\">\n" .
> --
> 1.7.2.2
>
--
Jakub Narebski
Poland
ShadeHawk on #git
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-31 16:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-27 17:38 [PATCH] gitweb: Don’t die_error in git_tag after already printing headers Anders Kaseorg
2010-08-31 16:19 ` Jakub Narebski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.