All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gregory Bean <gbean@codeaurora.org>
To: Pavan Kondeti <pkondeti@codeaurora.org>
Cc: Gregory Bean <gbean@codeaurora.org>,
	dwalker@codeaurora.org, linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] msm: gpio: Add irq support to v2 gpiolib.
Date: Thu, 18 Nov 2010 11:20:28 -0800 (PST)	[thread overview]
Message-ID: <alpine.DEB.2.00.1011181115220.9788@gbean-linux.qualcomm.com> (raw)
In-Reply-To: <20101118111527.GD11700@codeaurora.org>

>> +	spin_lock_irqsave(&tlmm_lock, irq_flags);
>> +	for_each_set_bit(i, msm_gpio.enabled_irqs, NR_GPIO_IRQS) {
>> +		if (!test_bit(i, msm_gpio.wake_irqs))
>> +			writel(TARGET_PROC_NONE, GPIO_INTR_CFG_SU(i));
>> +	}
> If none of the enabled irqs is configured as a wakeup source, should not we
> disable the summary IRQ?

I do not believe there is a need.  If no irqs are wakeup sources, then
the summary irq is also not a wakeup source, see msm_gpio_irq_set_wake().
And if the GIC will mask the TLMM block appropriately during system PM
without further bit-twiddling from me, why complicate my PM hooks further?

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

WARNING: multiple messages have this Message-ID (diff)
From: gbean@codeaurora.org (Gregory Bean)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/2] msm: gpio: Add irq support to v2 gpiolib.
Date: Thu, 18 Nov 2010 11:20:28 -0800 (PST)	[thread overview]
Message-ID: <alpine.DEB.2.00.1011181115220.9788@gbean-linux.qualcomm.com> (raw)
In-Reply-To: <20101118111527.GD11700@codeaurora.org>

>> +	spin_lock_irqsave(&tlmm_lock, irq_flags);
>> +	for_each_set_bit(i, msm_gpio.enabled_irqs, NR_GPIO_IRQS) {
>> +		if (!test_bit(i, msm_gpio.wake_irqs))
>> +			writel(TARGET_PROC_NONE, GPIO_INTR_CFG_SU(i));
>> +	}
> If none of the enabled irqs is configured as a wakeup source, should not we
> disable the summary IRQ?

I do not believe there is a need.  If no irqs are wakeup sources, then
the summary irq is also not a wakeup source, see msm_gpio_irq_set_wake().
And if the GIC will mask the TLMM block appropriately during system PM
without further bit-twiddling from me, why complicate my PM hooks further?

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

  reply	other threads:[~2010-11-18 19:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-16 21:38 [PATCH v3 1/2] msm: gpio: Add v2 gpio support to MSM SoCs Gregory Bean
2010-11-16 21:38 ` Gregory Bean
2010-11-16 21:38 ` [PATCH v3 2/2] msm: gpio: Add irq support to v2 gpiolib Gregory Bean
2010-11-16 21:38   ` Gregory Bean
2010-11-18 11:15   ` Pavan Kondeti
2010-11-18 11:15     ` Pavan Kondeti
2010-11-18 19:20     ` Gregory Bean [this message]
2010-11-18 19:20       ` Gregory Bean
2010-11-18 10:52 ` [PATCH v3 1/2] msm: gpio: Add v2 gpio support to MSM SoCs Pavan Kondeti
2010-11-18 10:52   ` Pavan Kondeti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1011181115220.9788@gbean-linux.qualcomm.com \
    --to=gbean@codeaurora.org \
    --cc=dwalker@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pkondeti@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.