* [Qemu-devel] [PATCH 2/5] qemu and qemu-xen: fix segfault on con_disconnect
@ 2011-01-19 13:53 ` Stefano Stabellini
0 siblings, 0 replies; 2+ messages in thread
From: Stefano Stabellini @ 2011-01-19 13:53 UTC (permalink / raw)
To: xen-devel; +Cc: qemu-devel
The test on xendev->gnttabdev in con_disconnect is wrong: what
differentiates the consoles is the dev number.
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
diff --git a/hw/xen_console.c b/hw/xen_console.c
index d7099c4..0a2374c 100644
--- a/hw/xen_console.c
+++ b/hw/xen_console.c
@@ -258,7 +258,7 @@ static void con_disconnect(struct XenDevice *xendev)
xen_be_unbind_evtchn(&con->xendev);
if (con->sring) {
- if (!xendev->gnttabdev)
+ if (!xendev->dev)
munmap(con->sring, XC_PAGE_SIZE);
else
xc_gnttab_munmap(xendev->gnttabdev, con->sring, 1);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 2/5] qemu and qemu-xen: fix segfault on con_disconnect
@ 2011-01-19 13:53 ` Stefano Stabellini
0 siblings, 0 replies; 2+ messages in thread
From: Stefano Stabellini @ 2011-01-19 13:53 UTC (permalink / raw)
To: xen-devel; +Cc: qemu-devel
The test on xendev->gnttabdev in con_disconnect is wrong: what
differentiates the consoles is the dev number.
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
diff --git a/hw/xen_console.c b/hw/xen_console.c
index d7099c4..0a2374c 100644
--- a/hw/xen_console.c
+++ b/hw/xen_console.c
@@ -258,7 +258,7 @@ static void con_disconnect(struct XenDevice *xendev)
xen_be_unbind_evtchn(&con->xendev);
if (con->sring) {
- if (!xendev->gnttabdev)
+ if (!xendev->dev)
munmap(con->sring, XC_PAGE_SIZE);
else
xc_gnttab_munmap(xendev->gnttabdev, con->sring, 1);
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-19 13:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-19 13:53 [Qemu-devel] [PATCH 2/5] qemu and qemu-xen: fix segfault on con_disconnect Stefano Stabellini
2011-01-19 13:53 ` Stefano Stabellini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.