[PATCH]tools:xl: Fix for Windows UP crash on boot using xl

[PATCH]tools:xl: Fix for Windows UP crash on boot using xl

[Zhang, Fengzhe]

[-- Attachment #1: Type: text/plain, Size: 666 bytes --]

tools:xl: Fix for Windows UP crash on boot using xl

When parameter "vcpus" is not explicitly set in config file, cur_vpus is initialized to 0 instead of 1, which causes domU crash.

Signed-off-by: Fengzhe Zhang <fengzhe.zhang@intel.com>

diff -r 7b4c82f07281 tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c	Wed Jan 05 23:54:15 2011 +0000
+++ b/tools/libxl/xl_cmdimpl.c	Fri Jan 21 23:52:35 2011 +0800
@@ -328,6 +328,7 @@
 {
     memset(b_info, '\0', sizeof(*b_info));
     b_info->max_vcpus = 1;
+    b_info->cur_vcpus = 1;
     b_info->max_memkb = 32 * 1024;
     b_info->target_memkb = b_info->max_memkb;
     b_info->disable_migrate = 0;

[-- Attachment #2: windows_up_crash_fix.patch --]
[-- Type: application/octet-stream, Size: 666 bytes --]

tools:xl: Fix for Windows UP crash on boot using xl

When parameter "vcpus" is not explicitly set in config file, cur_vpus is initialized to 0 instead of 1, which causes domU crash.

Signed-off-by: Fengzhe Zhang <fengzhe.zhang@intel.com>

diff -r 7b4c82f07281 tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c	Wed Jan 05 23:54:15 2011 +0000
+++ b/tools/libxl/xl_cmdimpl.c	Fri Jan 21 23:52:35 2011 +0800
@@ -328,6 +328,7 @@
 {
     memset(b_info, '\0', sizeof(*b_info));
     b_info->max_vcpus = 1;
+    b_info->cur_vcpus = 1;
     b_info->max_memkb = 32 * 1024;
     b_info->target_memkb = b_info->max_memkb;
     b_info->disable_migrate = 0;

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH]tools:xl: Fix for Windows UP crash on boot using xl

[Stefano Stabellini]

On Fri, 21 Jan 2011, Zhang, Fengzhe wrote:
> tools:xl: Fix for Windows UP crash on boot using xl
> 
> When parameter "vcpus" is not explicitly set in config file, cur_vpus is initialized to 0 instead of 1, which causes domU crash.
> 

Thanks for debugging this!
The code you are changing below has been moved to
tools/libxl/libxl_create.c.
Could you please refresh your patch?


> Signed-off-by: Fengzhe Zhang <fengzhe.zhang@intel.com>
> 
> diff -r 7b4c82f07281 tools/libxl/xl_cmdimpl.c
> --- a/tools/libxl/xl_cmdimpl.c	Wed Jan 05 23:54:15 2011 +0000
> +++ b/tools/libxl/xl_cmdimpl.c	Fri Jan 21 23:52:35 2011 +0800
> @@ -328,6 +328,7 @@
>  {
>      memset(b_info, '\0', sizeof(*b_info));
>      b_info->max_vcpus = 1;
> +    b_info->cur_vcpus = 1;
>      b_info->max_memkb = 32 * 1024;
>      b_info->target_memkb = b_info->max_memkb;
>      b_info->disable_migrate = 0;
> 

Re: [PATCH]tools:xl: Fix for Windows UP crash on boot using xl

[Ian Jackson]

Stefano Stabellini writes ("Re: [Xen-devel] [PATCH]tools:xl: Fix for Windows UP crash on boot using xl"):
> Thanks for debugging this!
> The code you are changing below has been moved to
> tools/libxl/libxl_create.c.
> Could you please refresh your patch?

No need, I have fixed it up and applied the patch.

Thanks,
Ian.