RE: [PATCH][VTD][GFX] pass gfx_passthru parameter to QEMU

RE: [PATCH][VTD][GFX] pass gfx_passthru parameter to QEMU

[Kay, Allen M]

[-- Attachment #1: Type: text/plain, Size: 505 bytes --]

I noticed this pass is has not been checked into the latest staging tree yet.  Any reason?

-----Original Message-----
From: Kay, Allen M 
Sent: Thursday, January 27, 2011 6:00 PM
To: xen-devel
Cc: 'Stefano Stabellini'; Ian Campbell; 'Sergey Tovpeko'; Daniel De Graaf
Subject: [PATCH][VTD][GFX] pass gfx_passthru parameter to QEMU

Pass gfx_passthru parameter to QEMU.  Keep it boolean for now as QEMU does not expect any other integer value.

Signed-off-by: Allen Kay <allen.m.kay@intel.com>

[-- Attachment #2: gfx0127.patch --]
[-- Type: application/octet-stream, Size: 806 bytes --]

diff -r 74fb7eaa6597 tools/libxl/libxl_dm.c
--- a/tools/libxl/libxl_dm.c	Thu Jan 27 19:51:47 2011 +0000
+++ b/tools/libxl/libxl_dm.c	Fri Oct 01 11:48:36 2010 -0700
@@ -148,6 +148,9 @@
         if ( ioemu_vifs == 0 ) {
             flexarray_vappend(dm_args, "-net", "none", NULL);
         }
+        if (info->gfx_passthru) {
+            flexarray_append(dm_args, "-gfx_passthru");
+        }
     }
     if (info->saved_state) {
         flexarray_vappend(dm_args, "-loadvm", info->saved_state, NULL);
@@ -280,6 +283,9 @@
         if ( ioemu_vifs == 0 ) {
             flexarray_append(dm_args, "-net");
             flexarray_append(dm_args, "none");
+        }
+        if (info->gfx_passthru) {
+            flexarray_append(dm_args, "-gfx_passthru");
         }
     }
     if (info->saved_state) {

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

RE: [PATCH][VTD][GFX] pass gfx_passthru parameter to QEMU

[Stefano Stabellini]

On Mon, 31 Jan 2011, Kay, Allen M wrote:
> I noticed this pass is has not been checked into the latest staging tree yet.  Any reason?

No reason, with all the other xl patches we just forgot.
The patch is fine, but the second chuck is not useful considering that
new qemu doesn't have the code to do gfx passthrough yet.
Other than that:


Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

RE: [PATCH][VTD][GFX] pass gfx_passthru parameter to QEMU

[Ian Jackson]

Stefano Stabellini writes ("RE: [PATCH][VTD][GFX] pass gfx_passthru parameter to QEMU"):
> On Mon, 31 Jan 2011, Kay, Allen M wrote:
> > I noticed this pass is has not been checked into the latest staging tree yet.  Any reason?
> 
> No reason, with all the other xl patches we just forgot.
> The patch is fine, but the second chuck is not useful considering that
> new qemu doesn't have the code to do gfx passthrough yet.
> Other than that:

I have applied the whole patch in the hope that the new qemu will grow
that code eventually.  For now it can be a placeholder and at least it
makes things fail properly rather than simply ignoring the passthrough
attempt.

Sorry for missing the patch the first time round.  Part of the reason
was that Mailman (our mailing list software) is mangling headers very
badly, causing the messages to be rejected by the MTA on my colo so
the mail-to-news gateway through which I read xen-devel didn't see it.

Mailman will be too hard to fix quickly so I'll see about letting my
colo's MTA be a bit more relaxed.

Ian.

[PATCH][VTD][GFX] pass gfx_passthru parameter to QEMU

[Kay, Allen M]

[-- Attachment #1: Type: text/plain, Size: 164 bytes --]

Pass gfx_passthru parameter to QEMU.  Keep it boolean for now as QEMU does not expect any other integer value.

Signed-off-by: Allen Kay <allen.m.kay@intel.com>

[-- Attachment #2: gfx0127.patch --]
[-- Type: application/octet-stream, Size: 806 bytes --]

diff -r 74fb7eaa6597 tools/libxl/libxl_dm.c
--- a/tools/libxl/libxl_dm.c	Thu Jan 27 19:51:47 2011 +0000
+++ b/tools/libxl/libxl_dm.c	Fri Oct 01 11:48:36 2010 -0700
@@ -148,6 +148,9 @@
         if ( ioemu_vifs == 0 ) {
             flexarray_vappend(dm_args, "-net", "none", NULL);
         }
+        if (info->gfx_passthru) {
+            flexarray_append(dm_args, "-gfx_passthru");
+        }
     }
     if (info->saved_state) {
         flexarray_vappend(dm_args, "-loadvm", info->saved_state, NULL);
@@ -280,6 +283,9 @@
         if ( ioemu_vifs == 0 ) {
             flexarray_append(dm_args, "-net");
             flexarray_append(dm_args, "none");
+        }
+        if (info->gfx_passthru) {
+            flexarray_append(dm_args, "-gfx_passthru");
         }
     }
     if (info->saved_state) {

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel