Re: [Qemu-devel] [PATCH] xen: introduce xen_change_state_handler

[Stefano Stabellini <stefano.stabellini@eu.citrix.com>]

[-- Attachment #1: Type: text/plain, Size: 1769 bytes --]

I have just realized that I wrote the reply to this email long ago but I
have never sent it, it was sitting in my Draft mbox.

On Thu, 30 Jun 2011, Alexander Graf wrote:
> On 06/29/2011 01:16 PM, stefano.stabellini@eu.citrix.com wrote:
> > From: Anthony PERARD<anthony.perard@citrix.com>
> >
> > Remove the call to xenstore_record_dm_state from xen_main_loop_prepare
> > that is HVM specific.
> > Add a new vm_change_state_handler shared between xen_pv and xen_hvm
> > machines to record the VM state to xenstore.
> >
> > Signed-off-by: Anthony PERARD<anthony.perard@citrix.com>
> > Signed-off-by: Stefano Stabellini<stefano.stabellini@eu.citrix.com>
> > ---
> >   xen-all.c |   25 ++++++++++++++++++-------
> >   1 files changed, 18 insertions(+), 7 deletions(-)
> >
> > diff --git a/xen-all.c b/xen-all.c
> > index 3fd04ef..e8da35f 100644
> > --- a/xen-all.c
> > +++ b/xen-all.c
> > @@ -797,12 +797,17 @@ void xenstore_store_pv_console_info(int i, CharDriverState *chr)
> >       }
> >   }
> >
> > -static void xenstore_record_dm_state(XenIOState *s, const char *state)
> > +static void xenstore_record_dm_state(struct xs_handle *xs, const char *state)
> >   {
> >       char path[50];
> >
> > +    if (xs == NULL) {
> > +        fprintf(stderr, "xenstore connection not initialized\n");
> > +        exit(1);
> > +    }
> 
> /studio/tmp/agraf/xen-all.c: In function ‘xenstore_record_dm_state’:
> /studio/tmp/agraf/xen-all.c:744: error: ‘xs’ undeclared (first use in 
> this function)
> /studio/tmp/agraf/xen-all.c:744: error: (Each undeclared identifier is 
> reported only once
> /studio/tmp/agraf/xen-all.c:744: error: for each function it appears in.)

I think you had some conflicts applying the patch, I'll post it again
rebased on your xen-next branch.