From: Joel Reardon <joel@clambassador.com> To: Artem Bityutskiy <dedekind1@gmail.com> Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [patch] UBIFS: Add cryptographic functionality when a key is passed to the compress / decompress functions Date: Mon, 2 Apr 2012 16:48:42 +0200 (CEST) [thread overview] Message-ID: <alpine.DEB.2.00.1204021645070.29393@eristoteles.iwoars.net> (raw) In-Reply-To: <1333377383.22146.14.camel@sauron.fi.intel.com> > > You support only one length - please, kill ivlen parameter. > > Also, should ubifs_aes_crypt be static? I do not see any users outside > of compress.c. In this case remove the "ubifs_" prefix. But a > non-written convention, in UBIFS we _tend_ to prefix only non-static > functions with "ubifs_" and avoid having it for static functions. > Should length for key remain, and the IV is just the same? Or should the global #define just be used inside the aes function. There is another use where the data is decrypted and reencrypted with a different key. (during GC and if an erase block becomes bad.) In this case, the data is not decompressed and recompressed, only the encryption changes. However, for simplicity, and because its not frequent, we can make it static and use the compress functions to handle this. > > I guess the above goto is redundant? > It is, but I put it in for future developers who may add a new control case there after without expecting the above to 'fall through'.
WARNING: multiple messages have this Message-ID (diff)
From: Joel Reardon <joel@clambassador.com> To: Artem Bityutskiy <dedekind1@gmail.com> Cc: linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [patch] UBIFS: Add cryptographic functionality when a key is passed to the compress / decompress functions Date: Mon, 2 Apr 2012 16:48:42 +0200 (CEST) [thread overview] Message-ID: <alpine.DEB.2.00.1204021645070.29393@eristoteles.iwoars.net> (raw) In-Reply-To: <1333377383.22146.14.camel@sauron.fi.intel.com> > > You support only one length - please, kill ivlen parameter. > > Also, should ubifs_aes_crypt be static? I do not see any users outside > of compress.c. In this case remove the "ubifs_" prefix. But a > non-written convention, in UBIFS we _tend_ to prefix only non-static > functions with "ubifs_" and avoid having it for static functions. > Should length for key remain, and the IV is just the same? Or should the global #define just be used inside the aes function. There is another use where the data is decrypted and reencrypted with a different key. (during GC and if an erase block becomes bad.) In this case, the data is not decompressed and recompressed, only the encryption changes. However, for simplicity, and because its not frequent, we can make it static and use the compress functions to handle this. > > I guess the above goto is redundant? > It is, but I put it in for future developers who may add a new control case there after without expecting the above to 'fall through'.
next prev parent reply other threads:[~2012-04-02 14:48 UTC|newest] Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-02-09 15:24 [patch] Adding Secure Deletion to UBIFS Joel Reardon 2012-02-09 15:24 ` Joel Reardon 2012-02-09 15:24 ` Joel Reardon 2012-02-13 16:54 ` Artem Bityutskiy 2012-02-13 16:54 ` Artem Bityutskiy 2012-02-23 14:59 ` Joel Reardon 2012-02-23 14:59 ` Joel Reardon 2012-02-23 15:29 ` [patch] Add encryption key parameter to compress/decompress functions Joel Reardon 2012-02-23 15:29 ` Joel Reardon 2012-03-09 7:17 ` Artem Bityutskiy 2012-03-09 7:17 ` Artem Bityutskiy 2012-03-19 16:54 ` [patch] Add design document for UBIFS secure deletion Joel Reardon 2012-03-19 16:54 ` Joel Reardon 2012-03-20 20:10 ` Randy Dunlap 2012-03-20 20:10 ` Randy Dunlap 2012-03-21 13:26 ` Joel Reardon 2012-03-21 13:26 ` Joel Reardon 2012-03-21 16:20 ` Artem Bityutskiy 2012-03-21 16:20 ` Artem Bityutskiy 2012-03-21 16:10 ` Artem Bityutskiy 2012-03-21 16:10 ` Artem Bityutskiy 2012-03-23 13:50 ` Joel Reardon 2012-03-23 13:50 ` Joel Reardon 2012-03-23 15:38 ` Artem Bityutskiy 2012-03-23 15:38 ` Artem Bityutskiy 2012-03-23 16:38 ` Joel Reardon 2012-03-23 16:38 ` Joel Reardon 2012-03-26 15:03 ` Artem Bityutskiy 2012-03-26 15:03 ` Artem Bityutskiy 2012-02-29 17:09 ` [patch] Adding Secure Deletion to UBIFS Artem Bityutskiy 2012-02-29 17:09 ` Artem Bityutskiy 2012-03-15 14:48 ` [patch] Remove notion of key schemes Joel Reardon 2012-03-15 14:48 ` Joel Reardon 2012-03-16 12:43 ` Artem Bityutskiy 2012-03-16 12:43 ` Artem Bityutskiy 2012-03-16 12:51 ` Artem Bityutskiy 2012-03-16 12:51 ` Artem Bityutskiy 2012-03-16 13:34 ` Joel Reardon 2012-03-16 13:34 ` Joel Reardon 2012-03-16 13:41 ` Artem Bityutskiy 2012-03-16 13:41 ` Artem Bityutskiy 2012-03-16 15:02 ` Joel Reardon 2012-03-16 15:02 ` Joel Reardon 2012-03-19 14:56 ` Artem Bityutskiy 2012-03-19 14:56 ` Artem Bityutskiy 2012-02-20 20:15 ` [patch] Move CRC computation to separate function Joel Reardon 2012-02-20 20:15 ` Joel Reardon 2012-02-29 16:10 ` Artem Bityutskiy 2012-02-29 16:10 ` Artem Bityutskiy 2012-03-19 22:46 ` Joel Reardon 2012-03-19 22:46 ` Joel Reardon 2012-03-23 14:09 ` Artem Bityutskiy 2012-03-23 14:09 ` Artem Bityutskiy 2012-03-23 16:45 ` Joel Reardon 2012-03-23 16:45 ` Joel Reardon 2012-03-23 16:51 ` Artem Bityutskiy 2012-03-23 16:51 ` Artem Bityutskiy 2012-03-25 20:38 ` Joel Reardon 2012-03-25 20:38 ` Joel Reardon 2012-03-26 15:34 ` Artem Bityutskiy 2012-03-26 15:34 ` Artem Bityutskiy 2012-03-25 21:11 ` [patch] Add a encryption key parameter to the compress / decompress function Joel Reardon 2012-03-25 21:11 ` Joel Reardon 2012-03-25 21:38 ` [patch] Add cryptographic functionality when a key is passed to the compress / decompress functions Joel Reardon 2012-03-25 21:38 ` Joel Reardon 2012-03-27 8:33 ` Artem Bityutskiy 2012-03-27 8:33 ` Artem Bityutskiy 2012-03-29 14:39 ` [patch] UBIFS: " Joel Reardon 2012-03-29 14:39 ` Joel Reardon 2012-04-02 14:36 ` Artem Bityutskiy 2012-04-02 14:36 ` Artem Bityutskiy 2012-04-02 14:48 ` Joel Reardon [this message] 2012-04-02 14:48 ` Joel Reardon 2012-04-02 14:57 ` Artem Bityutskiy 2012-04-02 14:57 ` Artem Bityutskiy 2012-04-02 14:58 ` Joel Reardon 2012-04-02 14:58 ` Joel Reardon 2012-04-03 10:29 ` Joel Reardon 2012-04-03 10:29 ` Joel Reardon 2012-04-03 10:41 ` Guillaume LECERF 2012-04-03 10:41 ` Guillaume LECERF 2012-04-03 10:41 ` Guillaume LECERF 2012-04-03 11:35 ` Joel Reardon 2012-04-03 11:35 ` Joel Reardon 2012-04-12 14:05 ` Artem Bityutskiy 2012-04-12 14:05 ` Artem Bityutskiy 2012-03-27 8:27 ` [patch] Add a encryption key parameter to the compress / decompress function Artem Bityutskiy 2012-03-27 8:27 ` Artem Bityutskiy 2012-03-29 14:11 ` [patch] UBIFS: " Joel Reardon 2012-03-29 14:11 ` Joel Reardon 2012-04-02 14:02 ` Artem Bityutskiy 2012-04-02 14:02 ` Artem Bityutskiy 2012-02-29 17:25 ` [patch] Adding Secure Deletion to UBIFS Artem Bityutskiy 2012-02-29 17:25 ` Artem Bityutskiy 2012-03-01 13:41 ` Joel Reardon 2012-03-01 13:41 ` Joel Reardon 2012-03-09 7:36 ` Artem Bityutskiy 2012-03-09 7:36 ` Artem Bityutskiy 2012-03-09 19:29 ` Joel Reardon 2012-03-09 19:29 ` Joel Reardon 2012-03-12 13:30 ` Artem Bityutskiy 2012-03-12 13:30 ` Artem Bityutskiy 2012-03-12 13:34 ` Joel Reardon 2012-03-12 13:34 ` Joel Reardon 2012-03-12 13:36 ` Artem Bityutskiy 2012-03-12 13:36 ` Artem Bityutskiy 2012-03-12 13:37 ` Joel Reardon 2012-03-12 13:37 ` Joel Reardon 2012-03-14 10:20 ` Joel Reardon 2012-03-14 10:20 ` Joel Reardon 2012-03-14 10:27 ` Artem Bityutskiy 2012-03-14 10:27 ` Artem Bityutskiy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=alpine.DEB.2.00.1204021645070.29393@eristoteles.iwoars.net \ --to=joel@clambassador.com \ --cc=dedekind1@gmail.com \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.