From: Christoph Lameter <cl@linux.com> To: Glauber Costa <glommer@parallels.com> Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, kamezawa.hiroyu@jp.fujitsu.com, Tejun Heo <tj@kernel.org>, Li Zefan <lizefan@huawei.com>, Greg Thelen <gthelen@google.com>, Suleiman Souhlal <suleiman@google.com>, Michal Hocko <mhocko@suse.cz>, Johannes Weiner <hannes@cmpxchg.org>, devel@openvz.org, Pekka Enberg <penberg@cs.helsinki.fi> Subject: Re: [PATCH v2 04/29] slub: always get the cache from its page in kfree Date: Fri, 11 May 2012 14:20:36 -0500 (CDT) [thread overview] Message-ID: <alpine.DEB.2.00.1205111418350.386@router.home> (raw) In-Reply-To: <4FAD6449.2060201@parallels.com> On Fri, 11 May 2012, Glauber Costa wrote: > > I see that. But there are other subsystems from slab allocators that do > > the same. There are also objects that may be used by multiple processes. > > This is also true for normal user pages. And then, we do what memcg does: > first one to touch, gets accounted. I don't think deviating from the memcg > behavior for user pages makes much sense here. > > A cache won't go away while it still have objects, even after the memcg is > removed (it is marked as dead) Ok so we will have some dead pages around that are then repatriated to the / set? > > Hmmm.. Would be better to have a hierachy there. /proc/slabinfo is more > > legacy. > > I can take a look at that then. Assuming you agree with all the rest, is > looking into that a pre-requisite for merging, or is something that can be > deferred for a phase2 ? (We still don't do shrinkers, for instance, so this is > sure to have a phase2) Not a prerequisite for merging but note that I intend to rework the allocators to extract common code so that they have the same sysfs interface, error reporting and failure scenarios. We can at that time also add support for /sys/kernel/slab to memcg. (/sys/memcg/<name>/slab/* ?)
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Lameter <cl@linux.com> To: Glauber Costa <glommer@parallels.com> Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, kamezawa.hiroyu@jp.fujitsu.com, Tejun Heo <tj@kernel.org>, Li Zefan <lizefan@huawei.com>, Greg Thelen <gthelen@google.com>, Suleiman Souhlal <suleiman@google.com>, Michal Hocko <mhocko@suse.cz>, Johannes Weiner <hannes@cmpxchg.org>, devel@openvz.org, Pekka Enberg <penberg@cs.helsinki.fi> Subject: Re: [PATCH v2 04/29] slub: always get the cache from its page in kfree Date: Fri, 11 May 2012 14:20:36 -0500 (CDT) [thread overview] Message-ID: <alpine.DEB.2.00.1205111418350.386@router.home> (raw) In-Reply-To: <4FAD6449.2060201@parallels.com> On Fri, 11 May 2012, Glauber Costa wrote: > > I see that. But there are other subsystems from slab allocators that do > > the same. There are also objects that may be used by multiple processes. > > This is also true for normal user pages. And then, we do what memcg does: > first one to touch, gets accounted. I don't think deviating from the memcg > behavior for user pages makes much sense here. > > A cache won't go away while it still have objects, even after the memcg is > removed (it is marked as dead) Ok so we will have some dead pages around that are then repatriated to the / set? > > Hmmm.. Would be better to have a hierachy there. /proc/slabinfo is more > > legacy. > > I can take a look at that then. Assuming you agree with all the rest, is > looking into that a pre-requisite for merging, or is something that can be > deferred for a phase2 ? (We still don't do shrinkers, for instance, so this is > sure to have a phase2) Not a prerequisite for merging but note that I intend to rework the allocators to extract common code so that they have the same sysfs interface, error reporting and failure scenarios. We can at that time also add support for /sys/kernel/slab to memcg. (/sys/memcg/<name>/slab/* ?) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-05-11 19:20 UTC|newest] Thread overview: 167+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-05-11 17:44 [PATCH v2 00/29] kmem limitation for memcg Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` [PATCH v2 01/29] slab: dup name string Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-15 22:04 ` David Rientjes 2012-05-15 22:04 ` David Rientjes 2012-05-16 6:12 ` Glauber Costa 2012-05-16 6:12 ` Glauber Costa 2012-05-16 6:12 ` Glauber Costa 2012-05-11 17:44 ` [PATCH v2 02/29] slub: fix slab_state for slub Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:51 ` Christoph Lameter 2012-05-11 17:51 ` Christoph Lameter 2012-05-15 21:55 ` David Rientjes 2012-05-15 21:55 ` David Rientjes 2012-05-15 21:55 ` David Rientjes 2012-05-16 6:10 ` Glauber Costa 2012-05-16 6:10 ` Glauber Costa 2012-05-16 6:10 ` Glauber Costa 2012-05-17 10:14 ` Glauber Costa 2012-05-17 10:14 ` Glauber Costa 2012-05-17 10:14 ` Glauber Costa 2012-05-11 17:44 ` [PATCH v2 03/29] memcg: Always free struct memcg through schedule_work() Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` [PATCH v2 04/29] slub: always get the cache from its page in kfree Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:53 ` Christoph Lameter 2012-05-11 17:53 ` Christoph Lameter 2012-05-11 17:57 ` Glauber Costa 2012-05-11 17:57 ` Glauber Costa 2012-05-11 17:57 ` Glauber Costa 2012-05-11 18:06 ` Christoph Lameter 2012-05-11 18:06 ` Christoph Lameter 2012-05-11 18:11 ` Glauber Costa 2012-05-11 18:11 ` Glauber Costa 2012-05-11 18:11 ` Glauber Costa 2012-05-11 18:17 ` Christoph Lameter 2012-05-11 18:17 ` Christoph Lameter 2012-05-11 18:20 ` Glauber Costa 2012-05-11 18:20 ` Glauber Costa 2012-05-11 18:20 ` Glauber Costa 2012-05-11 18:32 ` Christoph Lameter 2012-05-11 18:32 ` Christoph Lameter 2012-05-11 18:32 ` Christoph Lameter 2012-05-11 18:42 ` Glauber Costa 2012-05-11 18:42 ` Glauber Costa 2012-05-11 18:42 ` Glauber Costa 2012-05-11 18:56 ` Christoph Lameter 2012-05-11 18:56 ` Christoph Lameter 2012-05-11 18:56 ` Christoph Lameter 2012-05-11 18:58 ` Glauber Costa 2012-05-11 18:58 ` Glauber Costa 2012-05-11 18:58 ` Glauber Costa 2012-05-11 19:09 ` Christoph Lameter 2012-05-11 19:09 ` Christoph Lameter 2012-05-11 19:11 ` Glauber Costa 2012-05-11 19:11 ` Glauber Costa 2012-05-11 19:11 ` Glauber Costa 2012-05-11 19:20 ` Christoph Lameter [this message] 2012-05-11 19:20 ` Christoph Lameter 2012-05-11 19:24 ` Glauber Costa 2012-05-11 19:24 ` Glauber Costa 2012-05-11 19:24 ` Glauber Costa 2012-05-11 17:44 ` [PATCH v2 05/29] slab: rename gfpflags to allocflags Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:54 ` Christoph Lameter 2012-05-11 17:54 ` Christoph Lameter 2012-05-15 21:57 ` David Rientjes 2012-05-15 21:57 ` David Rientjes 2012-05-11 17:44 ` [PATCH v2 06/29] memcg: Make it possible to use the stock for more than one page Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` [PATCH v2 07/29] memcg: Reclaim when more than one page needed Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` [PATCH v2 08/29] slab: use obj_size field of struct kmem_cache when not debugging Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` [PATCH v2 09/29] memcg: change defines to an enum Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` [PATCH v2 10/29] res_counter: don't force return value checking in res_counter_charge_nofail Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` [PATCH v2 11/29] cgroups: ability to stop res charge propagation on bounded ancestor Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-15 2:59 ` KAMEZAWA Hiroyuki 2012-05-15 2:59 ` KAMEZAWA Hiroyuki 2012-05-16 6:16 ` Glauber Costa 2012-05-16 6:16 ` Glauber Costa 2012-05-16 6:16 ` Glauber Costa 2012-05-11 17:44 ` [PATCH v2 12/29] kmem slab accounting basic infrastructure Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` [PATCH v2 13/29] slab/slub: struct memcg_params Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` [PATCH v2 14/29] slub: consider a memcg parameter in kmem_create_cache Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` [PATCH v2 15/29] slab: pass memcg parameter to kmem_cache_create Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` [PATCH v2 16/29] slub: create duplicate cache Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` [PATCH v2 17/29] slab: " Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` [PATCH v2 18/29] memcg: kmem controller charge/uncharge infrastructure Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-15 2:57 ` KAMEZAWA Hiroyuki 2012-05-15 2:57 ` KAMEZAWA Hiroyuki 2012-05-16 6:42 ` Glauber Costa 2012-05-16 6:42 ` Glauber Costa 2012-05-16 8:18 ` KAMEZAWA Hiroyuki 2012-05-16 8:18 ` KAMEZAWA Hiroyuki 2012-05-16 8:25 ` Glauber Costa 2012-05-16 8:25 ` Glauber Costa 2012-05-16 8:25 ` Glauber Costa 2012-05-16 9:15 ` KAMEZAWA Hiroyuki 2012-05-16 9:15 ` KAMEZAWA Hiroyuki 2012-05-16 9:15 ` KAMEZAWA Hiroyuki 2012-05-11 17:44 ` [PATCH v2 19/29] skip memcg kmem allocations in specified code regions Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-15 2:46 ` KAMEZAWA Hiroyuki 2012-05-15 2:46 ` KAMEZAWA Hiroyuki 2012-05-16 6:19 ` Glauber Costa 2012-05-16 6:19 ` Glauber Costa 2012-05-16 6:19 ` Glauber Costa 2012-05-16 7:55 ` KAMEZAWA Hiroyuki 2012-05-16 7:55 ` KAMEZAWA Hiroyuki 2012-05-16 7:55 ` KAMEZAWA Hiroyuki 2012-05-11 17:44 ` [PATCH v2 20/29] slub: charge allocation to a memcg Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` [PATCH v2 21/29] slab: per-memcg accounting of slab caches Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` [PATCH v2 22/29] memcg: disable kmem code when not in use Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` [PATCH v2 23/29] memcg: destroy memcg caches Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` [PATCH v2 24/29] memcg/slub: shrink dead caches Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` [PATCH v2 25/29] memcg: Track all the memcg children of a kmem_cache Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` [PATCH v2 26/29] memcg: Per-memcg memory.kmem.slabinfo file Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` [PATCH v2 27/29] slub: create slabinfo file for memcg Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` [PATCH v2 28/29] slub: track all children of a kmem cache Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 17:44 ` [PATCH v2 29/29] Documentation: add documentation for slab tracker for memcg Glauber Costa 2012-05-11 17:44 ` Glauber Costa 2012-05-11 18:05 ` [PATCH v2 00/29] kmem limitation " Glauber Costa 2012-05-11 18:05 ` Glauber Costa
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=alpine.DEB.2.00.1205111418350.386@router.home \ --to=cl@linux.com \ --cc=cgroups@vger.kernel.org \ --cc=devel@openvz.org \ --cc=glommer@parallels.com \ --cc=gthelen@google.com \ --cc=hannes@cmpxchg.org \ --cc=kamezawa.hiroyu@jp.fujitsu.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=lizefan@huawei.com \ --cc=mhocko@suse.cz \ --cc=penberg@cs.helsinki.fi \ --cc=suleiman@google.com \ --cc=tj@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.