[PATCH RESEND] ARM: OMAP4: hwmod data: add HWMOD_SWSUP_SIDLE to dss_hdmi to data

[PATCH RESEND] ARM: OMAP4: hwmod data: add HWMOD_SWSUP_SIDLE to dss_hdmi to data

[Ricardo Neri]

As per the OMAP4 documentation, audio over HDMI should be transmitted in
no-idle mode. This patch adds the HWMOD_SWSUP_SIDLE so that omap_hwmode uses
no-idle/force-idle settings instead of smart-idle mode.

This is required as the DSS interface clock is used as functional clock
for the HDMI wrapper audio FIFO. If no-idle mode is not used, audio could
be choppy, have bad quality or not be audible at all.

Signed-off-by: Ricardo Neri <ricardo.neri@ti.com>
---
 arch/arm/mach-omap2/omap_hwmod_44xx_data.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
index 950454a..0cd6ee1 100644
--- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
@@ -865,6 +865,11 @@ static struct omap_hwmod omap44xx_dss_hdmi_hwmod = {
 	},
 	.opt_clks	= dss_hdmi_opt_clks,
 	.opt_clks_cnt	= ARRAY_SIZE(dss_hdmi_opt_clks),
+	/*
+	 * HDMI audio requires to use no-idle mode. Hence,
+	 * set idle mode by software.
+	 */
+	.flags          = HWMOD_SWSUP_SIDLE,
 };
 
 /*
-- 
1.7.5.4

Re: [PATCH RESEND] ARM: OMAP4: hwmod data: add HWMOD_SWSUP_SIDLE to dss_hdmi to data

[Cousson, Benoit]

Hi Ricardo,

Thanks for the update.

On 6/21/2012 1:10 AM, Ricardo Neri wrote:
> As per the OMAP4 documentation, audio over HDMI should be transmitted in
> no-idle mode. This patch adds the HWMOD_SWSUP_SIDLE so that omap_hwmode uses
> no-idle/force-idle settings instead of smart-idle mode.
>
> This is required as the DSS interface clock is used as functional clock
> for the HDMI wrapper audio FIFO. If no-idle mode is not used, audio could
> be choppy, have bad quality or not be audible at all.
>
> Signed-off-by: Ricardo Neri <ricardo.neri@ti.com>

Acked-by: Benoit Cousson <b-cousson@ti.com>


Paul,
Will you take it as part of your fixes series for 3.5-rc?

Regards,
Benoit

> ---
>   arch/arm/mach-omap2/omap_hwmod_44xx_data.c |    5 +++++
>   1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> index 950454a..0cd6ee1 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> @@ -865,6 +865,11 @@ static struct omap_hwmod omap44xx_dss_hdmi_hwmod = {
>   	},
>   	.opt_clks	= dss_hdmi_opt_clks,
>   	.opt_clks_cnt	= ARRAY_SIZE(dss_hdmi_opt_clks),
> +	/*
> +	 * HDMI audio requires to use no-idle mode. Hence,
> +	 * set idle mode by software.
> +	 */
> +	.flags          = HWMOD_SWSUP_SIDLE,
>   };
>
>   /*
>

Re: [PATCH RESEND] ARM: OMAP4: hwmod data: add HWMOD_SWSUP_SIDLE to dss_hdmi to data

[Cousson, Benoit]

Hi Ricardo,

In fact the flags attribute was not located correctly with regard to the template used by the scripts.
I updated the script, the patch, the subject and fix a typo in the changelog.

Please find below the updated version.

Regards,
Benoit


---
>From 9a89d06f9de9a4efbfc49d0c5adf0fa0d0031bdf Mon Sep 17 00:00:00 2001
From: Ricardo Neri <ricardo.neri@ti.com>
Date: Thu, 21 Jun 2012 10:08:53 +0200
Subject: [PATCH] ARM: OMAP4: hwmod data: Force HDMI in no-idle while enabled

As per the OMAP4 documentation, audio over HDMI must be transmitted in
no-idle mode. This patch adds the HWMOD_SWSUP_SIDLE so that omap_hwmod uses
no-idle/force-idle settings instead of smart-idle mode.

This is required as the DSS interface clock is used as functional clock
for the HDMI wrapper audio FIFO. If no-idle mode is not used, audio could
be choppy, have bad quality or not be audible at all.

Signed-off-by: Ricardo Neri <ricardo.neri@ti.com>
[b-cousson@ti.com: Update the subject and align the .flags
location with the script template]
Signed-off-by: Benoit Cousson <b-cousson@ti.com>
---
 arch/arm/mach-omap2/omap_hwmod_44xx_data.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
index aae6e5e..f51b35f 100644
--- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
@@ -858,6 +858,11 @@ static struct omap_hwmod omap44xx_dss_hdmi_hwmod = {
 	.name		= "dss_hdmi",
 	.class		= &omap44xx_hdmi_hwmod_class,
 	.clkdm_name	= "l3_dss_clkdm",
+	/*
+	 * HDMI audio requires to use no-idle mode. Hence,
+	 * set idle mode by software.
+	 */
+	.flags		= HWMOD_SWSUP_SIDLE,
 	.mpu_irqs	= omap44xx_dss_hdmi_irqs,
 	.sdma_reqs	= omap44xx_dss_hdmi_sdma_reqs,
 	.main_clk	= "dss_48mhz_clk",
-- 
1.7.0.4

Re: [PATCH RESEND] ARM: OMAP4: hwmod data: add HWMOD_SWSUP_SIDLE to dss_hdmi to data

[Paul Walmsley]

On Thu, 21 Jun 2012, Cousson, Benoit wrote:

> Paul,
> Will you take it as part of your fixes series for 3.5-rc?

Yes, I'll take your updated version.


- Paul

Re: [PATCH RESEND] ARM: OMAP4: hwmod data: add HWMOD_SWSUP_SIDLE to dss_hdmi to data

[Paul Walmsley]

On Thu, 21 Jun 2012, Cousson, Benoit wrote:

> Hi Ricardo,
> 
> In fact the flags attribute was not located correctly with regard to the template used by the scripts.
> I updated the script, the patch, the subject and fix a typo in the changelog.
> 
> Please find below the updated version.

Thanks, queued for 3.5-rc.

- Paul

> 
> 
> ---
> >From 9a89d06f9de9a4efbfc49d0c5adf0fa0d0031bdf Mon Sep 17 00:00:00 2001
> From: Ricardo Neri <ricardo.neri@ti.com>
> Date: Thu, 21 Jun 2012 10:08:53 +0200
> Subject: [PATCH] ARM: OMAP4: hwmod data: Force HDMI in no-idle while enabled
> 
> As per the OMAP4 documentation, audio over HDMI must be transmitted in
> no-idle mode. This patch adds the HWMOD_SWSUP_SIDLE so that omap_hwmod uses
> no-idle/force-idle settings instead of smart-idle mode.
> 
> This is required as the DSS interface clock is used as functional clock
> for the HDMI wrapper audio FIFO. If no-idle mode is not used, audio could
> be choppy, have bad quality or not be audible at all.
> 
> Signed-off-by: Ricardo Neri <ricardo.neri@ti.com>
> [b-cousson@ti.com: Update the subject and align the .flags
> location with the script template]
> Signed-off-by: Benoit Cousson <b-cousson@ti.com>
> ---
>  arch/arm/mach-omap2/omap_hwmod_44xx_data.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> index aae6e5e..f51b35f 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> @@ -858,6 +858,11 @@ static struct omap_hwmod omap44xx_dss_hdmi_hwmod = {
>  	.name		= "dss_hdmi",
>  	.class		= &omap44xx_hdmi_hwmod_class,
>  	.clkdm_name	= "l3_dss_clkdm",
> +	/*
> +	 * HDMI audio requires to use no-idle mode. Hence,
> +	 * set idle mode by software.
> +	 */
> +	.flags		= HWMOD_SWSUP_SIDLE,
>  	.mpu_irqs	= omap44xx_dss_hdmi_irqs,
>  	.sdma_reqs	= omap44xx_dss_hdmi_sdma_reqs,
>  	.main_clk	= "dss_48mhz_clk",
> -- 
> 1.7.0.4
> 
> 


- Paul