* remove dependency on PyXML from xen?
@ 2012-07-24 19:04 M A Young
2012-07-24 19:36 ` Konrad Rzeszutek Wilk
0 siblings, 1 reply; 10+ messages in thread
From: M A Young @ 2012-07-24 19:04 UTC (permalink / raw)
To: xen-devel
Fedora is keen to stop using PyXML and I have been sent a bug report
https://bugzilla.redhat.com/show_bug.cgi?id=842843 which includes a patch
to remove the use of XMLPrettyPrint in tools/python/xen/xm/create.py . I
am going to try this in the Fedora build, but I was wondering if it makes
sense to do this in the official xen releases as well.
Michael Young
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: remove dependency on PyXML from xen?
2012-07-24 19:04 remove dependency on PyXML from xen? M A Young
@ 2012-07-24 19:36 ` Konrad Rzeszutek Wilk
2012-07-25 8:43 ` Ian Campbell
0 siblings, 1 reply; 10+ messages in thread
From: Konrad Rzeszutek Wilk @ 2012-07-24 19:36 UTC (permalink / raw)
To: M A Young; +Cc: xen-devel
On Tue, Jul 24, 2012 at 08:04:30PM +0100, M A Young wrote:
> Fedora is keen to stop using PyXML and I have been sent a bug report
> https://bugzilla.redhat.com/show_bug.cgi?id=842843 which includes a
> patch to remove the use of XMLPrettyPrint in
> tools/python/xen/xm/create.py . I am going to try this in the Fedora
> build, but I was wondering if it makes sense to do this in the
> official xen releases as well.
Yes.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: remove dependency on PyXML from xen?
2012-07-24 19:36 ` Konrad Rzeszutek Wilk
@ 2012-07-25 8:43 ` Ian Campbell
2012-08-12 18:03 ` [PATCH] " M A Young
0 siblings, 1 reply; 10+ messages in thread
From: Ian Campbell @ 2012-07-25 8:43 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk; +Cc: xen-devel, M A Young
On Tue, 2012-07-24 at 20:36 +0100, Konrad Rzeszutek Wilk wrote:
> On Tue, Jul 24, 2012 at 08:04:30PM +0100, M A Young wrote:
> > Fedora is keen to stop using PyXML and I have been sent a bug report
> > https://bugzilla.redhat.com/show_bug.cgi?id=842843 which includes a
> > patch to remove the use of XMLPrettyPrint in
> > tools/python/xen/xm/create.py . I am going to try this in the Fedora
> > build, but I was wondering if it makes sense to do this in the
> > official xen releases as well.
>
> Yes.
Agreed.
According to the bug we've already moved from PyXML to lxml
(22235:b8cc53d22545 from the looks of it) and simply missed this one use
of PyXML.
Ian.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] Re: remove dependency on PyXML from xen?
2012-07-25 8:43 ` Ian Campbell
@ 2012-08-12 18:03 ` M A Young
2012-08-16 16:10 ` Ian Campbell
2012-08-17 13:13 ` Ian Campbell
0 siblings, 2 replies; 10+ messages in thread
From: M A Young @ 2012-08-12 18:03 UTC (permalink / raw)
To: Ian Campbell; +Cc: xen-devel, Konrad Rzeszutek Wilk
[-- Attachment #1: Type: TEXT/PLAIN, Size: 790 bytes --]
On Wed, 25 Jul 2012, Ian Campbell wrote:
> On Tue, 2012-07-24 at 20:36 +0100, Konrad Rzeszutek Wilk wrote:
>> On Tue, Jul 24, 2012 at 08:04:30PM +0100, M A Young wrote:
>>> Fedora is keen to stop using PyXML and I have been sent a bug report
>>> https://bugzilla.redhat.com/show_bug.cgi?id=842843 which includes a
>>> patch to remove the use of XMLPrettyPrint in
>>> tools/python/xen/xm/create.py . I am going to try this in the Fedora
>>> build, but I was wondering if it makes sense to do this in the
>>> official xen releases as well.
>>
>> Yes.
>
> Agreed.
>
> According to the bug we've already moved from PyXML to lxml
> (22235:b8cc53d22545 from the looks of it) and simply missed this one use
> of PyXML.
Here is the patch from that bug (trivially) rebased to 4.2.
Michael Young
[-- Attachment #2: Type: TEXT/PLAIN, Size: 801 bytes --]
Replace the use of XMLPrettyPrint from PyXML in xm with stdlib functionality.
This was reported by Toshio Ernie Kuratomi at
https://bugzilla.redhat.com/show_bug.cgi?id=842843
Signed-off-by: Michael Young <m.a.young@durham.ac.uk>
--- xen-4.2.0/tools/python/xen/xm/create.py.orig 2012-05-12 16:40:48.000000000 +0100
+++ xen-4.2.0/tools/python/xen/xm/create.py 2012-08-12 17:59:56.464270707 +0100
@@ -1543,8 +1543,7 @@
SXPPrettyPrint.prettyprint(config)
if opts.vals.xmldryrun and serverType == SERVER_XEN_API:
- from xml.dom.ext import PrettyPrint as XMLPrettyPrint
- XMLPrettyPrint(doc)
+ print doc.toprettyxml()
if opts.vals.dryrun or opts.vals.xmldryrun:
return
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Re: remove dependency on PyXML from xen?
2012-08-12 18:03 ` [PATCH] " M A Young
@ 2012-08-16 16:10 ` Ian Campbell
2012-08-17 13:13 ` Ian Campbell
1 sibling, 0 replies; 10+ messages in thread
From: Ian Campbell @ 2012-08-16 16:10 UTC (permalink / raw)
To: M A Young; +Cc: xen-devel, Ian Jackson, Konrad Rzeszutek Wilk
On Sun, 2012-08-12 at 19:03 +0100, M A Young wrote:
> On Wed, 25 Jul 2012, Ian Campbell wrote:
>
> > On Tue, 2012-07-24 at 20:36 +0100, Konrad Rzeszutek Wilk wrote:
> >> On Tue, Jul 24, 2012 at 08:04:30PM +0100, M A Young wrote:
> >>> Fedora is keen to stop using PyXML and I have been sent a bug report
> >>> https://bugzilla.redhat.com/show_bug.cgi?id=842843 which includes a
> >>> patch to remove the use of XMLPrettyPrint in
> >>> tools/python/xen/xm/create.py . I am going to try this in the Fedora
> >>> build, but I was wondering if it makes sense to do this in the
> >>> official xen releases as well.
> >>
> >> Yes.
> >
> > Agreed.
> >
> > According to the bug we've already moved from PyXML to lxml
> > (22235:b8cc53d22545 from the looks of it) and simply missed this one use
> > of PyXML.
>
> Here is the patch from that bug (trivially) rebased to 4.2.
Seems good to me, although xend is deprecated this patch is pretty
simple and the goal a useful one.
Ian.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Re: remove dependency on PyXML from xen?
2012-08-12 18:03 ` [PATCH] " M A Young
2012-08-16 16:10 ` Ian Campbell
@ 2012-08-17 13:13 ` Ian Campbell
2012-08-20 19:44 ` M A Young
1 sibling, 1 reply; 10+ messages in thread
From: Ian Campbell @ 2012-08-17 13:13 UTC (permalink / raw)
To: M A Young; +Cc: xen-devel, Konrad Rzeszutek Wilk
On Sun, 2012-08-12 at 19:03 +0100, M A Young wrote:
> On Wed, 25 Jul 2012, Ian Campbell wrote:
>
> > On Tue, 2012-07-24 at 20:36 +0100, Konrad Rzeszutek Wilk wrote:
> >> On Tue, Jul 24, 2012 at 08:04:30PM +0100, M A Young wrote:
> >>> Fedora is keen to stop using PyXML and I have been sent a bug report
> >>> https://bugzilla.redhat.com/show_bug.cgi?id=842843 which includes a
> >>> patch to remove the use of XMLPrettyPrint in
> >>> tools/python/xen/xm/create.py . I am going to try this in the Fedora
> >>> build, but I was wondering if it makes sense to do this in the
> >>> official xen releases as well.
> >>
> >> Yes.
> >
> > Agreed.
> >
> > According to the bug we've already moved from PyXML to lxml
> > (22235:b8cc53d22545 from the looks of it) and simply missed this one use
> > of PyXML.
>
> Here is the patch from that bug (trivially) rebased to 4.2.
Acked-by: Ian Campbell <ian.campbell@citrix.com>
and pushed. Is the following section of README still accurate? At least
the mention of "PyXML" seems wrong to me.
Python Runtime Libraries
========================
Xend (the Xen daemon) has the following runtime dependencies:
* Python 2.3 or later.
In some distros, the XML-aspects to the standard library
(xml.dom.minidom etc) are broken out into a separate python-xml package.
This is also required.
In more recent versions of Debian and Ubuntu the XML-aspects are included
in the base python package however (python-xml has been removed
from Debian in squeeze and from Ubuntu in intrepid).
URL: http://www.python.org/
Debian: python
* For optional SSL support, pyOpenSSL:
URL: http://pyopenssl.sourceforge.net/
Debian: python-pyopenssl
* For optional PAM support, PyPAM:
URL: http://www.pangalactic.org/PyPAM/
Debian: python-pam
* For optional XenAPI support in XM, PyXML:
URL: http://codespeak.net/lxml/
Debian: python-lxml
YUM: python-lxml
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Re: remove dependency on PyXML from xen?
2012-08-17 13:13 ` Ian Campbell
@ 2012-08-20 19:44 ` M A Young
2012-08-21 8:31 ` [PATCH] README: Update references to PyXML to lxml (Was: Re: [PATCH] Re: remove dependency on PyXML from xen?) Ian Campbell
0 siblings, 1 reply; 10+ messages in thread
From: M A Young @ 2012-08-20 19:44 UTC (permalink / raw)
To: Ian Campbell; +Cc: xen-devel, Konrad Rzeszutek Wilk
On Fri, 17 Aug 2012, Ian Campbell wrote:
> ...
> and pushed. Is the following section of README still accurate? At least
> the mention of "PyXML" seems wrong to me.
>
> Python Runtime Libraries
> ========================
>
> Xend (the Xen daemon) has the following runtime dependencies:
>
> * Python 2.3 or later.
> In some distros, the XML-aspects to the standard library
> (xml.dom.minidom etc) are broken out into a separate python-xml package.
> This is also required.
> In more recent versions of Debian and Ubuntu the XML-aspects are included
> in the base python package however (python-xml has been removed
> from Debian in squeeze and from Ubuntu in intrepid).
>
> URL: http://www.python.org/
> Debian: python
>
> * For optional SSL support, pyOpenSSL:
> URL: http://pyopenssl.sourceforge.net/
> Debian: python-pyopenssl
>
> * For optional PAM support, PyPAM:
> URL: http://www.pangalactic.org/PyPAM/
> Debian: python-pam
>
> * For optional XenAPI support in XM, PyXML:
> URL: http://codespeak.net/lxml/
> Debian: python-lxml
> YUM: python-lxml
Yes, it should be lxml not PyXML. The link could be upgraded as well as
http://codespeak.net/lxml/ redirects to http://lxml.de/ .
I also found mention of PyXML in tools/python/logging/logging-0.4.9.2/ in
the files README.txt, python_logging.html, and test/logrecv.py (in an
error message) as a dependency for ZSI though I don't think xen ever uses
the code.
Michael Young
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] README: Update references to PyXML to lxml (Was: Re: [PATCH] Re: remove dependency on PyXML from xen?)
2012-08-20 19:44 ` M A Young
@ 2012-08-21 8:31 ` Ian Campbell
2012-08-30 15:00 ` Ian Jackson
0 siblings, 1 reply; 10+ messages in thread
From: Ian Campbell @ 2012-08-21 8:31 UTC (permalink / raw)
To: M A Young; +Cc: xen-devel, Konrad Rzeszutek Wilk
On Mon, 2012-08-20 at 20:44 +0100, M A Young wrote:
> On Fri, 17 Aug 2012, Ian Campbell wrote:
>
> > ...
> > and pushed. Is the following section of README still accurate? At least
> > the mention of "PyXML" seems wrong to me.
> >
> > Python Runtime Libraries
> > ========================
> >
> > Xend (the Xen daemon) has the following runtime dependencies:
> >
> > * Python 2.3 or later.
> > In some distros, the XML-aspects to the standard library
> > (xml.dom.minidom etc) are broken out into a separate python-xml package.
> > This is also required.
> > In more recent versions of Debian and Ubuntu the XML-aspects are included
> > in the base python package however (python-xml has been removed
> > from Debian in squeeze and from Ubuntu in intrepid).
> >
> > URL: http://www.python.org/
> > Debian: python
> >
> > * For optional SSL support, pyOpenSSL:
> > URL: http://pyopenssl.sourceforge.net/
> > Debian: python-pyopenssl
> >
> > * For optional PAM support, PyPAM:
> > URL: http://www.pangalactic.org/PyPAM/
> > Debian: python-pam
> >
> > * For optional XenAPI support in XM, PyXML:
> > URL: http://codespeak.net/lxml/
> > Debian: python-lxml
> > YUM: python-lxml
>
> Yes, it should be lxml not PyXML. The link could be upgraded as well as
> http://codespeak.net/lxml/ redirects to http://lxml.de/ .
Thanks, patch below.
> I also found mention of PyXML in tools/python/logging/logging-0.4.9.2/ in
> the files README.txt, python_logging.html, and test/logrecv.py (in an
> error message) as a dependency for ZSI though I don't think xen ever uses
> the code.
Great, yet another imported source base!
It seems like the functionality is now part of mainline python. From
looking at Debian it seems that python 2.5+ contains this module
directly.
According to tools/python/logging/setup.py it is at least only installed
if the system version of python does not support it.
AFAICT this is only used by xend and the bit which uses pyxml is not
used.
8<--------------------------
# HG changeset patch
# User Ian Campbell <ian.campbell@citrix.com>
# Date 1345537817 -3600
# Node ID 7ba9eaf898afafac6cf3956d01c86b861ec5d853
# Parent b51f4c5a08480297d13439e66793a9002d9b49e9
README: Update references to PyXML to lxml
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
diff -r b51f4c5a0848 -r 7ba9eaf898af README
--- a/README Tue Aug 21 09:20:41 2012 +0100
+++ b/README Tue Aug 21 09:30:17 2012 +0100
@@ -148,9 +148,9 @@ Xend (the Xen daemon) has the following
URL: http://www.pangalactic.org/PyPAM/
Debian: python-pam
- * For optional XenAPI support in XM, PyXML:
- URL: http://codespeak.net/lxml/
- Debian: python-lxml
+ * For optional XenAPI support in XM, lxml:
+ URL: http://lxml.de/
+ Debian: python-lxml
YUM: python-lxml
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] README: Update references to PyXML to lxml (Was: Re: [PATCH] Re: remove dependency on PyXML from xen?)
2012-08-21 8:31 ` [PATCH] README: Update references to PyXML to lxml (Was: Re: [PATCH] Re: remove dependency on PyXML from xen?) Ian Campbell
@ 2012-08-30 15:00 ` Ian Jackson
2012-08-31 9:43 ` Ian Campbell
0 siblings, 1 reply; 10+ messages in thread
From: Ian Jackson @ 2012-08-30 15:00 UTC (permalink / raw)
To: Ian Campbell; +Cc: xen-devel, Konrad Rzeszutek Wilk, M A Young
Ian Campbell writes ("[Xen-devel] [PATCH] README: Update references to PyXML to lxml (Was: Re: [PATCH] Re: remove dependency on PyXML from xen?)"):
> README: Update references to PyXML to lxml
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] README: Update references to PyXML to lxml (Was: Re: [PATCH] Re: remove dependency on PyXML from xen?)
2012-08-30 15:00 ` Ian Jackson
@ 2012-08-31 9:43 ` Ian Campbell
0 siblings, 0 replies; 10+ messages in thread
From: Ian Campbell @ 2012-08-31 9:43 UTC (permalink / raw)
To: Ian Jackson; +Cc: xen-devel, Konrad Rzeszutek Wilk, M A Young
On Thu, 2012-08-30 at 16:00 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[Xen-devel] [PATCH] README: Update references to PyXML to lxml (Was: Re: [PATCH] Re: remove dependency on PyXML from xen?)"):
> > README: Update references to PyXML to lxml
>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2012-08-31 9:43 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-24 19:04 remove dependency on PyXML from xen? M A Young
2012-07-24 19:36 ` Konrad Rzeszutek Wilk
2012-07-25 8:43 ` Ian Campbell
2012-08-12 18:03 ` [PATCH] " M A Young
2012-08-16 16:10 ` Ian Campbell
2012-08-17 13:13 ` Ian Campbell
2012-08-20 19:44 ` M A Young
2012-08-21 8:31 ` [PATCH] README: Update references to PyXML to lxml (Was: Re: [PATCH] Re: remove dependency on PyXML from xen?) Ian Campbell
2012-08-30 15:00 ` Ian Jackson
2012-08-31 9:43 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.