All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Walmsley <paul@pwsan.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: Tony Lindgren <tony@atomide.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Mugunthan V N <mugunthanvnm@ti.com>
Subject: Re: Fwd: [PATCH 2/5] ARM: OMAP3+: hwmod: Add AM33XX HWMOD data for davinci_mdio
Date: Thu, 18 Oct 2012 03:46:15 +0000 (UTC)	[thread overview]
Message-ID: <alpine.DEB.2.00.1210180313360.6893@utopia.booyaka.com> (raw)
In-Reply-To: <20121018030654.GE2867@netboy.at.omicron.at>

On Thu, 18 Oct 2012, Richard Cochran wrote:

> So there has been this cpsw driver since v3.4-rc1~177^2~5
> 
>    df82859 netdev: driver: ethernet: Add TI CPSW driver
> 
> and four people signed off on it, so it must have been working at one
> point.

The signoffs just mean that those people are asserting that the code is 
covered under an appropriate license, or are passing it on through the 
maintainer hierarchy.  See 

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=Documentation/SubmittingPatches;h=c379a2a6949f1c1cac04fb6f185c633512f37061;hb=HEAD#l298

It doesn't necessarily mean that the driver is usable in that kernel 
release.

> Since the device tree make-over, the driver is a derelict, and thus the 
> present patch is fixing a regression.

Probably the driver was submitted before any SoC integration support was 
available.  Grepping for 'cpsw' under arch/ turns up only AM33xx.  AM335x 
didn't have device enumeration support in the mainline kernel until 3.7, 
via commit a2cfc509bc4eeef9f5c4607b1203f17f22ea2a36 ("ARM: OMAP3+: hwmod: 
Add AM33XX HWMOD data").  So I don't see how it could have worked with 
mainline.

> I just want the already merged driver to work with the vanilla
> kernel. Is that too much to ask?

It's a very reasonable wish and your patches are certainly appreciated.

But it seems that the CPSW has never worked in the mainline kernel.  So 
this particular patch is not fixing a regression.  Therefore we shouldn't 
send it upstream during the -rc time period.  Instead we'll schedule it to 
be sent a few weeks later, during the 3.8 merge window.

Either way, the patch is likely to make it into the mainline kernel.  
It's just that it will probably take a few weeks longer than you might 
like.


- Paul

WARNING: multiple messages have this Message-ID (diff)
From: paul@pwsan.com (Paul Walmsley)
To: linux-arm-kernel@lists.infradead.org
Subject: Fwd: [PATCH 2/5] ARM: OMAP3+: hwmod: Add AM33XX HWMOD data for davinci_mdio
Date: Thu, 18 Oct 2012 03:46:15 +0000 (UTC)	[thread overview]
Message-ID: <alpine.DEB.2.00.1210180313360.6893@utopia.booyaka.com> (raw)
In-Reply-To: <20121018030654.GE2867@netboy.at.omicron.at>

On Thu, 18 Oct 2012, Richard Cochran wrote:

> So there has been this cpsw driver since v3.4-rc1~177^2~5
> 
>    df82859 netdev: driver: ethernet: Add TI CPSW driver
> 
> and four people signed off on it, so it must have been working at one
> point.

The signoffs just mean that those people are asserting that the code is 
covered under an appropriate license, or are passing it on through the 
maintainer hierarchy.  See 

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=Documentation/SubmittingPatches;h=c379a2a6949f1c1cac04fb6f185c633512f37061;hb=HEAD#l298

It doesn't necessarily mean that the driver is usable in that kernel 
release.

> Since the device tree make-over, the driver is a derelict, and thus the 
> present patch is fixing a regression.

Probably the driver was submitted before any SoC integration support was 
available.  Grepping for 'cpsw' under arch/ turns up only AM33xx.  AM335x 
didn't have device enumeration support in the mainline kernel until 3.7, 
via commit a2cfc509bc4eeef9f5c4607b1203f17f22ea2a36 ("ARM: OMAP3+: hwmod: 
Add AM33XX HWMOD data").  So I don't see how it could have worked with 
mainline.

> I just want the already merged driver to work with the vanilla
> kernel. Is that too much to ask?

It's a very reasonable wish and your patches are certainly appreciated.

But it seems that the CPSW has never worked in the mainline kernel.  So 
this particular patch is not fixing a regression.  Therefore we shouldn't 
send it upstream during the -rc time period.  Instead we'll schedule it to 
be sent a few weeks later, during the 3.8 merge window.

Either way, the patch is likely to make it into the mainline kernel.  
It's just that it will probably take a few weeks longer than you might 
like.


- Paul

  reply	other threads:[~2012-10-18  3:46 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-17 18:13 Fwd: [PATCH 2/5] ARM: OMAP3+: hwmod: Add AM33XX HWMOD data for davinci_mdio Richard Cochran
2012-10-17 18:13 ` Richard Cochran
2012-10-17 23:38 ` Paul Walmsley
2012-10-17 23:38   ` Paul Walmsley
2012-10-17 23:50   ` Tony Lindgren
2012-10-17 23:50     ` Tony Lindgren
2012-10-18  3:06     ` Richard Cochran
2012-10-18  3:06       ` Richard Cochran
2012-10-18  3:46       ` Paul Walmsley [this message]
2012-10-18  3:46         ` Paul Walmsley
2012-10-18 18:27         ` Richard Cochran
2012-10-18 18:27           ` Richard Cochran
2012-10-18 18:42           ` Paul Walmsley
2012-10-18 18:42             ` Paul Walmsley
2012-10-18 18:44         ` Richard Cochran
2012-10-18 18:44           ` Richard Cochran
2012-10-18 19:27           ` Paul Walmsley
2012-10-18 19:27             ` Paul Walmsley
2012-10-19  6:08             ` Richard Cochran
2012-10-19  6:08               ` Richard Cochran
2012-10-18 20:48           ` Vaibhav Hiremath
2012-10-18 20:48             ` Vaibhav Hiremath
2012-10-19  6:16             ` Richard Cochran
2012-10-19  6:16               ` Richard Cochran
2012-10-19 16:00               ` Tony Lindgren
2012-10-19 16:00                 ` Tony Lindgren
2012-10-19 16:32                 ` Matt Porter
2012-10-19 16:32                   ` Matt Porter
2012-10-26  8:23                 ` Hiremath, Vaibhav
2012-10-26  8:23                   ` Hiremath, Vaibhav
2012-10-26 18:06                   ` Tony Lindgren
2012-10-26 18:06                     ` Tony Lindgren
2012-10-29  4:58                     ` Hiremath, Vaibhav
2012-10-29  4:58                       ` Hiremath, Vaibhav
2012-10-29  7:50                       ` Richard Cochran
2012-10-29  7:50                         ` Richard Cochran
2012-10-29  8:27                         ` Hiremath, Vaibhav
2012-10-29  8:27                           ` Hiremath, Vaibhav
2012-10-23 10:12               ` Hiremath, Vaibhav
2012-10-23 10:12                 ` Hiremath, Vaibhav
2012-10-24  5:08                 ` Richard Cochran
2012-10-24  5:08                   ` Richard Cochran
2012-10-26  8:23                   ` Hiremath, Vaibhav
2012-10-26  8:23                     ` Hiremath, Vaibhav
2012-10-18  8:30       ` Koen Kooi
2012-10-18  8:30         ` Koen Kooi
2012-10-18 20:48 ` Fwd: " Vaibhav Hiremath
2012-10-18 20:48   ` Vaibhav Hiremath
2012-10-18 22:49   ` Paul Walmsley
2012-10-18 22:49     ` Paul Walmsley
2012-10-29  5:19   ` Paul Walmsley
2012-10-29  5:19     ` Paul Walmsley
2012-10-29  5:22     ` Hiremath, Vaibhav
2012-10-29  5:22       ` Hiremath, Vaibhav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1210180313360.6893@utopia.booyaka.com \
    --to=paul@pwsan.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mugunthanvnm@ti.com \
    --cc=richardcochran@gmail.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.