From: David Rientjes <rientjes@google.com>
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-acpi@vger.kernel.org, Len Brown <len.brown@intel.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Andrew Morton <akpm@linux-foundation.org>,
Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
Jiang Liu <jiang.liu@huawei.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Minchan Kim <minchan.kim@gmail.com>, Mel Gorman <mgorman@suse.de>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Toshi Kani <toshi.kani@hp.com>, Jiang Liu <liuj97@gmail.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Christoph Lameter <cl@linux.com>
Subject: Re: [Patch v5 3/7] acpi_memhotplug.c: fix memory leak when memory device is unbound from the module acpi_memhotplug
Date: Thu, 15 Nov 2012 15:34:59 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.00.1211151533500.27188@chino.kir.corp.google.com> (raw)
In-Reply-To: <1352962777-24407-4-git-send-email-wency@cn.fujitsu.com>
On Thu, 15 Nov 2012, Wen Congyang wrote:
> We allocate memory to store acpi_memory_info, so we should free it before
> freeing mem_device.
>
> CC: David Rientjes <rientjes@google.com>
> CC: Jiang Liu <liuj97@gmail.com>
> CC: Len Brown <len.brown@intel.com>
> CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> CC: Paul Mackerras <paulus@samba.org>
> CC: Christoph Lameter <cl@linux.com>
> Cc: Minchan Kim <minchan.kim@gmail.com>
> CC: Andrew Morton <akpm@linux-foundation.org>
> CC: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> CC: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
> CC: Rafael J. Wysocki <rjw@sisk.pl>
> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
Acked-by: David Rientjes <rientjes@google.com>
It's a little strange to be re-initializing mem_device->res_list right
before freeing mem_device in acpi_memory_device_free(), though. Owell :)
WARNING: multiple messages have this Message-ID (diff)
From: David Rientjes <rientjes@google.com>
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-acpi@vger.kernel.org, Len Brown <len.brown@intel.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Andrew Morton <akpm@linux-foundation.org>,
Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
Jiang Liu <jiang.liu@huawei.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Minchan Kim <minchan.kim@gmail.com>, Mel Gorman <mgorman@suse.de>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Toshi Kani <toshi.kani@hp.com>, Jiang Liu <liuj97@gmail.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Christoph Lameter <cl@linux.com>
Subject: Re: [Patch v5 3/7] acpi_memhotplug.c: fix memory leak when memory device is unbound from the module acpi_memhotplug
Date: Thu, 15 Nov 2012 15:34:59 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.00.1211151533500.27188@chino.kir.corp.google.com> (raw)
In-Reply-To: <1352962777-24407-4-git-send-email-wency@cn.fujitsu.com>
On Thu, 15 Nov 2012, Wen Congyang wrote:
> We allocate memory to store acpi_memory_info, so we should free it before
> freeing mem_device.
>
> CC: David Rientjes <rientjes@google.com>
> CC: Jiang Liu <liuj97@gmail.com>
> CC: Len Brown <len.brown@intel.com>
> CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> CC: Paul Mackerras <paulus@samba.org>
> CC: Christoph Lameter <cl@linux.com>
> Cc: Minchan Kim <minchan.kim@gmail.com>
> CC: Andrew Morton <akpm@linux-foundation.org>
> CC: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> CC: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
> CC: Rafael J. Wysocki <rjw@sisk.pl>
> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
Acked-by: David Rientjes <rientjes@google.com>
It's a little strange to be re-initializing mem_device->res_list right
before freeing mem_device in acpi_memory_device_free(), though. Owell :)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-11-15 23:35 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 6:59 [Patch v5 0/7] acpi,memory-hotplug: implement framework for hot removing memory Wen Congyang
2012-11-15 6:59 ` Wen Congyang
2012-11-15 6:59 ` [Patch v5 1/7] acpi,memory-hotplug : add memory offline code to acpi_memory_device_remove() Wen Congyang
2012-11-15 6:59 ` Wen Congyang
2012-11-15 23:03 ` David Rientjes
2012-11-15 23:03 ` David Rientjes
2012-11-15 6:59 ` [Patch v5 2/7] acpi,memory-hotplug: deal with eject request in hotplug queue Wen Congyang
2012-11-15 6:59 ` Wen Congyang
2012-11-15 9:13 ` Yasuaki Ishimatsu
2012-11-15 9:13 ` Yasuaki Ishimatsu
2012-11-15 22:09 ` Toshi Kani
2012-11-15 22:09 ` Toshi Kani
2012-11-15 23:32 ` David Rientjes
2012-11-15 23:32 ` David Rientjes
2012-11-16 1:54 ` Wen Congyang
2012-11-16 1:54 ` Wen Congyang
2012-11-15 6:59 ` [Patch v5 3/7] acpi_memhotplug.c: fix memory leak when memory device is unbound from the module acpi_memhotplug Wen Congyang
2012-11-15 6:59 ` Wen Congyang
2012-11-15 9:15 ` Yasuaki Ishimatsu
2012-11-15 9:15 ` Yasuaki Ishimatsu
2012-11-15 23:34 ` David Rientjes [this message]
2012-11-15 23:34 ` David Rientjes
2012-11-15 6:59 ` [Patch v5 4/7] acpi_memhotplug.c: free memory device if acpi_memory_enable_device() failed Wen Congyang
2012-11-15 6:59 ` Wen Congyang
2012-11-15 9:17 ` Yasuaki Ishimatsu
2012-11-15 9:17 ` Yasuaki Ishimatsu
2012-11-15 9:17 ` Yasuaki Ishimatsu
2012-11-15 23:36 ` David Rientjes
2012-11-15 23:36 ` David Rientjes
2012-11-15 6:59 ` [Patch v5 5/7] acpi_memhotplug.c: don't allow to eject the memory device if it is being used Wen Congyang
2012-11-15 6:59 ` Wen Congyang
2012-11-15 9:20 ` Yasuaki Ishimatsu
2012-11-15 9:20 ` Yasuaki Ishimatsu
2012-11-15 23:39 ` David Rientjes
2012-11-15 23:39 ` David Rientjes
2012-11-29 13:15 ` andywu106建国
2012-11-29 13:15 ` andywu106建国
2012-11-15 6:59 ` [Patch v5 6/7] acpi_memhotplug.c: bind the memory device when the driver is being loaded Wen Congyang
2012-11-15 6:59 ` Wen Congyang
2012-11-15 9:22 ` Yasuaki Ishimatsu
2012-11-15 9:22 ` Yasuaki Ishimatsu
2012-11-15 9:22 ` Yasuaki Ishimatsu
2012-11-15 23:40 ` David Rientjes
2012-11-15 23:40 ` David Rientjes
2012-11-15 6:59 ` [Patch v5 7/7] acpi_memhotplug.c: auto bind the memory device which is hotplugged before the driver is loaded Wen Congyang
2012-11-15 6:59 ` Wen Congyang
2012-11-15 9:57 ` Yasuaki Ishimatsu
2012-11-15 9:57 ` Yasuaki Ishimatsu
2012-11-15 22:45 ` Toshi Kani
2012-11-15 22:45 ` Toshi Kani
2012-11-15 22:51 ` [Patch v5 0/7] acpi,memory-hotplug: implement framework for hot removing memory David Rientjes
2012-11-15 22:51 ` David Rientjes
2012-11-15 23:22 ` Rafael J. Wysocki
2012-11-15 23:22 ` Rafael J. Wysocki
2012-11-15 23:33 ` Rafael J. Wysocki
2012-11-15 23:33 ` Rafael J. Wysocki
2012-11-16 0:28 ` Rafael J. Wysocki
2012-11-16 0:28 ` Rafael J. Wysocki
2012-11-16 0:40 ` Rafael J. Wysocki
2012-11-16 0:40 ` Rafael J. Wysocki
2012-11-16 0:40 ` Toshi Kani
2012-11-16 0:40 ` Toshi Kani
2012-11-16 1:02 ` Rafael J. Wysocki
2012-11-16 1:02 ` Rafael J. Wysocki
2012-11-16 1:07 ` Yasuaki Ishimatsu
2012-11-16 1:07 ` Yasuaki Ishimatsu
2012-11-16 1:07 ` Yasuaki Ishimatsu
2012-11-16 1:28 ` Rafael J. Wysocki
2012-11-16 1:28 ` Rafael J. Wysocki
2012-11-16 1:31 ` Yasuaki Ishimatsu
2012-11-16 1:31 ` Yasuaki Ishimatsu
2012-11-16 1:31 ` Yasuaki Ishimatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1211151533500.27188@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=cl@linux.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=jiang.liu@huawei.com \
--cc=konrad.wilk@oracle.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=laijs@cn.fujitsu.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuj97@gmail.com \
--cc=mgorman@suse.de \
--cc=minchan.kim@gmail.com \
--cc=paulus@samba.org \
--cc=rjw@sisk.pl \
--cc=toshi.kani@hp.com \
--cc=wency@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.