Re: [collectd] [PATCH 0/2] Ceph collectd plugin

Re: [collectd] [PATCH 0/2] Ceph collectd plugin

[Sage Weil]

Hi Florian!

Sorry for the slow reply...

On Mon, 21 Jan 2013, Florian Forster wrote:
> Hi Sage :)
> 
> thank you very much for your code!
> 
> On Fri, Jan 18, 2013 at 05:17:17PM -0800, Sage Weil wrote:
> > There is an additional patch here to properly detect the libjson
> > dependency that comes from Yves Mettier.  Feel free to adjust the
> > changelog if you want to sign it off differently or something.
> 
> other plugins that use JSON in one way or another use the "yajl" library
> [0]. How much work would it be to refactor the code to use this library
> instead?

The *_tree API Yves mentions[1] looks like it would work.  It would just 
require rewriting a bunch of code that already work, and I don't think 
I'll have time to do that any time soon.  That's not a particularly 
satisfying answer, I'm sure!  :(

Is this a blocker for getting this plugin merged?  I can fish around on 
ceph-devel and see if someone else has some time wrangle it...

Thanks!
sage

[1] http://lloyd.github.com/yajl/yajl-2.0.1/yajl__tree_8h.html