All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] MIPS: math-emu: dsemul: Remove an unused bit in ADDIUPC emulation
@ 2016-01-30  9:09 ` Maciej W. Rozycki
  0 siblings, 0 replies; 2+ messages in thread
From: Maciej W. Rozycki @ 2016-01-30  9:09 UTC (permalink / raw)
  To: Ralf Baechle; +Cc: linux-mips

Avoid a reader's confusion, as the calculation is correct either way.

Signed-off-by: Maciej W. Rozycki <macro@imgtec.com>
---
linux-umips-dsemul-addiupc-nit.diff
Index: linux-sfr-test/arch/mips/math-emu/dsemul.c
===================================================================
--- linux-sfr-test.orig/arch/mips/math-emu/dsemul.c	2016-01-29 14:11:03.000000000 +0000
+++ linux-sfr-test/arch/mips/math-emu/dsemul.c	2016-01-29 14:13:53.613960000 +0000
@@ -60,7 +60,7 @@ int mips_dsemul(struct pt_regs *regs, mi
 			unsigned int rs;
 			s32 v;
 
-			rs = (((insn.mm_a_format.rs + 0x1e) & 0xf) + 2);
+			rs = (((insn.mm_a_format.rs + 0xe) & 0xf) + 2);
 			v = regs->cp0_epc & ~3;
 			v += insn.mm_a_format.simmediate << 2;
 			regs->regs[rs] = (long)v;

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH] MIPS: math-emu: dsemul: Remove an unused bit in ADDIUPC emulation
@ 2016-01-30  9:09 ` Maciej W. Rozycki
  0 siblings, 0 replies; 2+ messages in thread
From: Maciej W. Rozycki @ 2016-01-30  9:09 UTC (permalink / raw)
  To: Ralf Baechle; +Cc: linux-mips

Avoid a reader's confusion, as the calculation is correct either way.

Signed-off-by: Maciej W. Rozycki <macro@imgtec.com>
---
linux-umips-dsemul-addiupc-nit.diff
Index: linux-sfr-test/arch/mips/math-emu/dsemul.c
===================================================================
--- linux-sfr-test.orig/arch/mips/math-emu/dsemul.c	2016-01-29 14:11:03.000000000 +0000
+++ linux-sfr-test/arch/mips/math-emu/dsemul.c	2016-01-29 14:13:53.613960000 +0000
@@ -60,7 +60,7 @@ int mips_dsemul(struct pt_regs *regs, mi
 			unsigned int rs;
 			s32 v;
 
-			rs = (((insn.mm_a_format.rs + 0x1e) & 0xf) + 2);
+			rs = (((insn.mm_a_format.rs + 0xe) & 0xf) + 2);
 			v = regs->cp0_epc & ~3;
 			v += insn.mm_a_format.simmediate << 2;
 			regs->regs[rs] = (long)v;

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-01-30  9:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-30  9:09 [PATCH] MIPS: math-emu: dsemul: Remove an unused bit in ADDIUPC emulation Maciej W. Rozycki
2016-01-30  9:09 ` Maciej W. Rozycki

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.