From: "Maciej W. Rozycki" <macro@imgtec.com>
To: James Hogan <james.hogan@imgtec.com>
Cc: Ralf Baechle <ralf@linux-mips.org>, <linux-mips@linux-mips.org>,
<stable@vger.kernel.org>
Subject: Re: [PATCH] MIPS: Fix -mabi=64 build of vdso.lds
Date: Fri, 7 Oct 2016 16:18:54 +0100 [thread overview]
Message-ID: <alpine.DEB.2.00.1610071615090.31859@tp.orcam.me.uk> (raw)
In-Reply-To: <20161007083858.GK19354@jhogan-linux.le.imgtec.org>
On Fri, 7 Oct 2016, James Hogan wrote:
> > Also I've noticed $(aflags-vdso) duplicate `-I' and `-E' options already
> > included with $(ccflags-vdso); I wonder if the duplicates should simply be
> > removed or whether $(cflags-vdso) ought to filter from $(KBUILD_CFLAGS)
> > and $(aflags-vdso) -- from $(KBUILD_AFLAGS) instead (or $(ccflags-vdso)
> > should just take the options from $(KBUILD_CPPFLAGS)). Also why `-E' is
> > supposed to take an argument? Can you please have a look at it?
>
> I think -E is to catch -EL / -EB.
Ahh, forgot about the existence of these!
> Removing the duplication is easily
> fixed (I'll post a patch soon). As for whether it should filter from the
> other KBUILD_ flags, I'm inclined to avoid changing it unless we can be
> sure it will be more robust as a result.
I've only been trying to figure out what Alex might have intended here.
Obviously given that otherwise the current setup seems to work I tend to
agree with you in that a simple removal of the duplication is the safest
path of the least resistance fix.
Maciej
WARNING: multiple messages have this Message-ID (diff)
From: "Maciej W. Rozycki" <macro@imgtec.com>
To: James Hogan <james.hogan@imgtec.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, stable@vger.kernel.org
Subject: Re: [PATCH] MIPS: Fix -mabi=64 build of vdso.lds
Date: Fri, 7 Oct 2016 16:18:54 +0100 [thread overview]
Message-ID: <alpine.DEB.2.00.1610071615090.31859@tp.orcam.me.uk> (raw)
Message-ID: <20161007151854.VDjksVGThSnVfoSptNzQmLXIAtzkRRaX2vWTlu00jQo@z> (raw)
In-Reply-To: <20161007083858.GK19354@jhogan-linux.le.imgtec.org>
On Fri, 7 Oct 2016, James Hogan wrote:
> > Also I've noticed $(aflags-vdso) duplicate `-I' and `-E' options already
> > included with $(ccflags-vdso); I wonder if the duplicates should simply be
> > removed or whether $(cflags-vdso) ought to filter from $(KBUILD_CFLAGS)
> > and $(aflags-vdso) -- from $(KBUILD_AFLAGS) instead (or $(ccflags-vdso)
> > should just take the options from $(KBUILD_CPPFLAGS)). Also why `-E' is
> > supposed to take an argument? Can you please have a look at it?
>
> I think -E is to catch -EL / -EB.
Ahh, forgot about the existence of these!
> Removing the duplication is easily
> fixed (I'll post a patch soon). As for whether it should filter from the
> other KBUILD_ flags, I'm inclined to avoid changing it unless we can be
> sure it will be more robust as a result.
I've only been trying to figure out what Alex might have intended here.
Obviously given that otherwise the current setup seems to work I tend to
agree with you in that a simple removal of the duplication is the safest
path of the least resistance fix.
Maciej
next prev parent reply other threads:[~2016-10-07 15:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 22:10 [PATCH] MIPS: Fix -mabi=64 build of vdso.lds James Hogan
2016-10-06 22:10 ` James Hogan
2016-10-06 23:52 ` Maciej W. Rozycki
2016-10-06 23:52 ` Maciej W. Rozycki
2016-10-06 23:52 ` Maciej W. Rozycki
2016-10-07 8:38 ` James Hogan
2016-10-07 8:38 ` James Hogan
2016-10-07 15:18 ` Maciej W. Rozycki [this message]
2016-10-07 15:18 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1610071615090.31859@tp.orcam.me.uk \
--to=macro@imgtec.com \
--cc=james.hogan@imgtec.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.