All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anders Kaseorg <andersk@MIT.EDU>
To: Paul Mackerras <paulus@samba.org>
Cc: git@vger.kernel.org
Subject: [PATCH v2 3/3] gitk: Allow displaying time zones from author and commit timestamps
Date: Sun, 29 May 2011 23:06:34 -0400 (EDT)	[thread overview]
Message-ID: <alpine.DEB.2.02.1105292305390.23145@dr-wily.mit.edu> (raw)
In-Reply-To: <alpine.DEB.2.02.1105291740410.23145@dr-wily.mit.edu>

Now gitk can be configured to display author and commit dates in their
original timezone, by putting %z into datetimeformat in ~/.gitk.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
---
 gitk |   18 +++++++++++++++++-
 1 files changed, 17 insertions(+), 1 deletions(-)

diff --git a/gitk b/gitk
index 8e15572..c77771e 100755
--- a/gitk
+++ b/gitk
@@ -11021,7 +11021,23 @@ proc prefsok {} {
 proc formatdate {d} {
     global datetimeformat
     if {$d ne {}} {
-	set d [clock format [lindex $d 0] -format $datetimeformat]
+	# If $datetimeformat includes a timezone, display in the
+	# timezone of the argument.  Otherwise, display in local time.
+	if {[string match {*%[zZ]*} $datetimeformat]} {
+	    if {[catch {set d [clock format [lindex $d 0] -timezone [lindex $d 1] -format $datetimeformat]}]} {
+		# Tcl < 8.5 does not support -timezone.  Emulate it by
+		# setting TZ=Unknown±NNNN.
+		global env
+		catch {set savedTZ $env(TZ)}
+		set zone [lindex $d 1]
+		set sign [string map {+ - - +} [string index $zone 0]]
+		set env(TZ) Unknown$sign[string range $zone 1 2]:[string range $zone 3 4]
+		set d [clock format [lindex $d 0] -format $datetimeformat]
+		if {[catch {set env(TZ) $savedTZ}]} {unset env(TZ)}
+	    }
+	} else {
+	    set d [clock format [lindex $d 0] -format $datetimeformat]
+	}
     }
     return $d
 }
-- 
1.7.5.3

  reply	other threads:[~2011-05-30  3:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-19 19:46 [PATCH 1/3] gitk: Remove unused $cdate array Anders Kaseorg
2011-01-19 19:47 ` [PATCH 2/3] gitk: Remember time zones from author and commit timestamps Anders Kaseorg
2011-01-19 19:47 ` [PATCH 3/3] gitk: Allow displaying " Anders Kaseorg
2011-05-29  4:46   ` Paul Mackerras
2011-05-30  3:05     ` Anders Kaseorg
2011-05-30  3:06       ` Anders Kaseorg [this message]
2011-05-30 19:35         ` [PATCH v2 " Andreas Schwab
2011-05-30 21:45           ` Anders Kaseorg
2011-05-30 21:47             ` [PATCH v3 " Anders Kaseorg
2011-05-30  5:35       ` [PATCH " Jakub Narebski
2011-05-30  6:17         ` Tim Guirgies
2011-05-30  6:29           ` Jakub Narebski
2011-05-30 21:35             ` Anders Kaseorg
2011-05-30 22:17               ` Andreas Schwab
2011-05-30 22:41                 ` [PATCH v4 " Anders Kaseorg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.02.1105292305390.23145@dr-wily.mit.edu \
    --to=andersk@mit.edu \
    --cc=git@vger.kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.