From: Jakub Narebski <jnareb@gmail.com>
To: Anders Kaseorg <andersk@MIT.EDU>
Cc: Paul Mackerras <paulus@samba.org>, git@vger.kernel.org
Subject: Re: [PATCH 3/3] gitk: Allow displaying time zones from author and commit timestamps
Date: Sun, 29 May 2011 22:35:08 -0700 (PDT) [thread overview]
Message-ID: <m3mxi4yco5.fsf@localhost.localdomain> (raw)
In-Reply-To: <alpine.DEB.2.02.1105291740410.23145@dr-wily.mit.edu>
Anders Kaseorg <andersk@MIT.EDU> writes:
> On Sun, 29 May 2011, Paul Mackerras wrote:
> > > @@ -11018,7 +11018,18 @@ proc prefsok {} {
> > > proc formatdate {d} {
> > > global datetimeformat
> > > if {$d ne {}} {
> > > - set d [clock format [lindex $d 0] -format $datetimeformat]
> > > + if {[string match {*%[zZ]*} $datetimeformat]} {
> > > + if {[catch {set d [clock format [lindex $d 0] -timezone [lindex $d 1] -format $datetimeformat]}]} {
> > > + # Tcl < 8.5 does not support -timezone.
> > > + global env
> > > + set zone [lindex $d 1]
> > > + set env(TZ) "IDK[string range $zone 0 2]:[string range $zone 3 end]"
> >
> > What is this about? Where is the IDK prefix for timezones defined or
> > described?
>
> Yeah, sorry, that deserved a bit more explanation. This is a kludge to
> get Tcl 8.4 to format dates in the right timezone. IDK is an arbitrary
> made up 3-letter code (“I Don’t Know”), since a UTC offset can’t generally
> be converted into a zone name. The format of TZ is described at:
> http://www.gnu.org/software/libc/manual/html_node/TZ-Variable.html
> http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html
>
> Actually, reading that again, I just realized that I need to invert the
> sign. Also that it can be longer than 3 letters; I’ll use “Unknown”
> instead.
Why not use UTC+N timezone (note: please check of for +HHMM it is
UTC+HH or UTC-HH) for timezone with given numeric offset from
Coordinated Universal Time?
BTW. UTC because http://www.nist.gov/pml/div688/utcnist.cfm#cut
--
Jakub Narebski
Poland
ShadeHawk on #git
next prev parent reply other threads:[~2011-05-30 5:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 19:46 [PATCH 1/3] gitk: Remove unused $cdate array Anders Kaseorg
2011-01-19 19:47 ` [PATCH 2/3] gitk: Remember time zones from author and commit timestamps Anders Kaseorg
2011-01-19 19:47 ` [PATCH 3/3] gitk: Allow displaying " Anders Kaseorg
2011-05-29 4:46 ` Paul Mackerras
2011-05-30 3:05 ` Anders Kaseorg
2011-05-30 3:06 ` [PATCH v2 " Anders Kaseorg
2011-05-30 19:35 ` Andreas Schwab
2011-05-30 21:45 ` Anders Kaseorg
2011-05-30 21:47 ` [PATCH v3 " Anders Kaseorg
2011-05-30 5:35 ` Jakub Narebski [this message]
2011-05-30 6:17 ` [PATCH " Tim Guirgies
2011-05-30 6:29 ` Jakub Narebski
2011-05-30 21:35 ` Anders Kaseorg
2011-05-30 22:17 ` Andreas Schwab
2011-05-30 22:41 ` [PATCH v4 " Anders Kaseorg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3mxi4yco5.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=andersk@MIT.EDU \
--cc=git@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.