Re: [PATCH] mmc: Added quirks for Ricoh 1180:e823 lower base clock frequency

From: Manoj Iyer <manoj.iyer@canonical.com>
To: Chris Ball <cjb@laptop.org>
Cc: Manoj Iyer <manoj.iyer@canonical.com>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org, jbarnes@virtuousgeek.org,
	matsumur@nts.ricoh.co.jp, linux-pci@vger.kernel.org,
	linux-mmc@vger.kernel.org
Subject: Re: [PATCH] mmc: Added quirks for Ricoh 1180:e823 lower base clock frequency
Date: Mon, 18 Jul 2011 16:12:48 -0500 (CDT)	[thread overview]
Message-ID: <alpine.DEB.2.02.1107181606290.1677@lazy> (raw)
In-Reply-To: <m2d3h7b8pv.fsf@bob.laptop.org>

> I see, thanks.  So we're lacking any data on what speed the card would
> normally provide.  Perhaps you could try that card on a different
> controller, just so we're able to see whether it's usually possible
> to get closer to 45M/sec with it?

Sure, let me generate some data on based on Ricoh R5C822.

>
> I think I'll take your patch as-is for 3.1 -- since if there is a
> performance degradation, it's on cards that simply don't work at all
> right now -- and if you're able to work on a followup patch that only
> performs the clock-lowering after the first error, I think that'd be a
> handy patch to have around.  Does that sound good?
>

That sounds good to me, that way we limit degradation in performance only 
to previously non-working cards. I will send the V2 soon.

> Thanks!
>
> - Chris.
> -- 
> Chris Ball   <cjb@laptop.org>   <http://printf.net/>
> One Laptop Per Child
>
>
Thanks a ton.
--
====================
Manoj Iyer
Ubuntu/Canonical
Hardware Enablement
====================