All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Manoj Iyer <manoj.iyer@canonical.com>
Cc: linux-kernel@vger.kernel.org, jbarnes@virtuousgeek.org,
	matsumur@nts.ricoh.co.jp, linux-pci@vger.kernel.org,
	linux-mmc@vger.kernel.org
Subject: Re: [PATCH] mmc: Added quirks for Ricoh 1180:e823 lower base clock frequency
Date: Tue, 12 Jul 2011 12:20:17 -0400	[thread overview]
Message-ID: <m2ipr779oe.fsf@bob.laptop.org> (raw)
In-Reply-To: <alpine.DEB.2.02.1107121050480.1767@lazy> (Manoj Iyer's message of "Tue, 12 Jul 2011 11:01:15 -0500 (CDT)")

Hi Manoj,

On Tue, Jul 12 2011, Manoj Iyer wrote:
> Test System: ThinkPad X220 Tablet, using Sandisk 2GB Class 2 SD, I did
> not see any considerable change in read/write times. Also, tested a
> Transcend MMCPlus 2GB card, before the patch was applied it would not
> mount the card, and would cause IO errors on read/write, but after the
> patch it mounts and works correctly.
> [..]
> ============ BEFORE THE PATCH ===============
> Sandisk 2GB Class2 SD
> =============================================
> === WRITE ===
> u@u:~$ ls -lh test.file
> -rw-r--r-- 1 u u 10M 2011-07-12 10:19 test.file
> u@u:~$ time cp test.file /media/E0FD-1813/copyto
>
> real    0m0.480s
> user    0m0.000s
> sys     0m0.024s
> [..]
> ============ AFTER THE PATCH =============
> Sandisk 2GB Class2 SD
> ==========================================
>
> === WRITE ===
> u@u:~$ time cp ./test.file /media/E0FD-1813/copyto1
>
> real    0m0.757s
> user    0m0.000s
> sys     0m0.044s

This suggests that there *was* a considerable difference in write speed, no?

It might be helpful to use Arnd's flashbench tool¹ for further benchmarking,
since it does the right thing with using direct I/O access without caches.

Thanks,

- Chris.

¹: http://git.linaro.org/gitweb?p=people/arnd/flashbench.git
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

  reply	other threads:[~2011-07-12 16:20 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-11 21:28 [Patch 0/1] mmc: Added quirks for Ricoh 1180:e823 lower base clock frequency Manoj Iyer
2011-07-11 21:28 ` [PATCH] " Manoj Iyer
2011-07-11 21:53   ` Chris Ball
2011-07-11 22:55     ` Manoj Iyer
2011-07-12 16:01     ` Manoj Iyer
2011-07-12 16:20       ` Chris Ball [this message]
2011-07-12 17:09         ` Manoj Iyer
2011-07-12 17:30           ` Chris Ball
2011-07-12 18:00             ` Arnd Bergmann
2011-07-13 14:45               ` Chris Ball
2011-07-13 15:42                 ` Manoj Iyer
2011-07-13 16:35                   ` Arnd Bergmann
2011-07-13 16:46                     ` Manoj Iyer
2011-07-13 16:55                       ` Chris Ball
2011-07-13 17:02                         ` Manoj Iyer
2011-07-13 17:08                           ` Chris Ball
2011-07-18 20:36                             ` Manoj Iyer
2011-07-18 20:40                               ` Chris Ball
2011-07-18 20:47                                 ` Manoj Iyer
2011-07-18 21:05                                   ` Chris Ball
2011-07-18 21:12                                     ` Manoj Iyer
2011-07-19 19:43                                     ` Manoj Iyer
2012-11-22  0:29                                   ` Chris Ball
2012-11-26 16:42                                     ` Manoj Iyer
2012-11-26 16:57                                       ` Chris Ball
2011-07-13 16:50                     ` Chris Ball
2011-07-13 16:54                       ` Manoj Iyer
2011-07-18 23:27                         ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2ipr779oe.fsf@bob.laptop.org \
    --to=cjb@laptop.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=manoj.iyer@canonical.com \
    --cc=matsumur@nts.ricoh.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.