All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Walmsley <pwalmsley@nvidia.com>
To: Prashant Gaikwad <pgaikwad@nvidia.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
	"mturquette@linaro.org" <mturquette@linaro.org>,
	Peter De Schrijver <pdeschrijver@nvidia.com>,
	Aleksandr Frid <afrid@nvidia.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/3] clk: tegra: T114: add DFLL DVCO reset control
Date: Tue, 11 Jun 2013 09:47:13 +0000 (UTC)	[thread overview]
Message-ID: <alpine.DEB.2.02.1306110944130.22645@utopia.booyaka.com> (raw)
In-Reply-To: <51B6D239.5030905@nvidia.com>

On Tue, 11 Jun 2013, Prashant Gaikwad wrote:

> Why not implement these APIs in DFLL clock driver itself and pass RST address
> register to driver?

The DFLL DVCO reset registers are CAR registers, not DFLL registers.  
Functions that operate on registers in one IP block shouldn't be located 
in another IP block's driver.


- Paul

WARNING: multiple messages have this Message-ID (diff)
From: pwalmsley@nvidia.com (Paul Walmsley)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] clk: tegra: T114: add DFLL DVCO reset control
Date: Tue, 11 Jun 2013 09:47:13 +0000 (UTC)	[thread overview]
Message-ID: <alpine.DEB.2.02.1306110944130.22645@utopia.booyaka.com> (raw)
In-Reply-To: <51B6D239.5030905@nvidia.com>

On Tue, 11 Jun 2013, Prashant Gaikwad wrote:

> Why not implement these APIs in DFLL clock driver itself and pass RST address
> register to driver?

The DFLL DVCO reset registers are CAR registers, not DFLL registers.  
Functions that operate on registers in one IP block shouldn't be located 
in another IP block's driver.


- Paul

  reply	other threads:[~2013-06-11  9:47 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-07 12:18 [PATCH 0/3] clk: tegra: T114: add DFLL prerequisites Paul Walmsley
2013-06-07 12:18 ` Paul Walmsley
2013-06-07 12:18 ` Paul Walmsley
     [not found] ` <20130607121505.21868.72360.stgit-orwA252wQtA@public.gmane.org>
2013-06-07 12:18   ` [PATCH 1/3] clk: tegra: T114: add FCPU clock shaper programming, needed by the DFLL Paul Walmsley
2013-06-07 12:18     ` Paul Walmsley
2013-06-07 12:18     ` Paul Walmsley
2013-06-07 12:19   ` [PATCH 2/3] clk: tegra: T114: add DFLL source clocks Paul Walmsley
2013-06-07 12:19     ` Paul Walmsley
2013-06-07 12:19     ` Paul Walmsley
     [not found]     ` <20130607121858.21868.73882.stgit-orwA252wQtA@public.gmane.org>
2013-06-07 16:53       ` Stephen Warren
2013-06-07 16:53         ` Stephen Warren
2013-06-07 16:53         ` Stephen Warren
2013-06-07 12:19 ` [PATCH 3/3] clk: tegra: T114: add DFLL DVCO reset control Paul Walmsley
2013-06-07 12:19   ` Paul Walmsley
     [not found]   ` <20130607121901.21868.65416.stgit-orwA252wQtA@public.gmane.org>
2013-06-07 16:57     ` Stephen Warren
2013-06-07 16:57       ` Stephen Warren
2013-06-07 16:57       ` Stephen Warren
     [not found]       ` <51B21105.1080301-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-06-07 17:06         ` Paul Walmsley
2013-06-07 17:06           ` Paul Walmsley
2013-06-07 17:06           ` Paul Walmsley
     [not found]           ` <alpine.DEB.2.02.1306071703050.7753-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org>
2013-06-11  7:31             ` Prashant Gaikwad
2013-06-11  7:31               ` Prashant Gaikwad
2013-06-11  7:31               ` Prashant Gaikwad
2013-06-11  9:47               ` Paul Walmsley [this message]
2013-06-11  9:47                 ` Paul Walmsley
2013-06-11  9:47                 ` Paul Walmsley
     [not found]                 ` <alpine.DEB.2.02.1306110944130.22645-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org>
2013-06-16  4:22                   ` Mike Turquette
2013-06-16  4:22                     ` Mike Turquette
2013-06-16  4:22                     ` Mike Turquette
2013-06-17 20:22                     ` Paul Walmsley
2013-06-17 20:22                       ` Paul Walmsley
2013-06-17 20:22                       ` Paul Walmsley
     [not found]                       ` <alpine.DEB.2.02.1306172019270.17176-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org>
2013-06-18 18:28                         ` Mike Turquette
2013-06-18 18:28                           ` Mike Turquette
2013-06-18 18:28                           ` Mike Turquette
2013-06-18 18:33                           ` Paul Walmsley
2013-06-18 18:33                             ` Paul Walmsley
2013-06-18 18:33                             ` Paul Walmsley
2013-06-19  8:45     ` Peter De Schrijver
2013-06-19  8:45       ` Peter De Schrijver
2013-06-19  8:45       ` Peter De Schrijver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.02.1306110944130.22645@utopia.booyaka.com \
    --to=pwalmsley@nvidia.com \
    --cc=afrid@nvidia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mturquette@linaro.org \
    --cc=pdeschrijver@nvidia.com \
    --cc=pgaikwad@nvidia.com \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.