From: Julia Lawall <julia.lawall@lip6.fr> To: Viresh Kumar <viresh.kumar@linaro.org> Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, kernel-janitors@vger.kernel.org, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/16] drivers/cpufreq/pxa3xx-cpufreq.c: Avoid using ARRAY_AND_SIZE(e) as a function argument Date: Mon, 12 Aug 2013 07:45:26 +0200 (CEST) [thread overview] Message-ID: <alpine.DEB.2.02.1308120743030.2038@localhost6.localdomain6> (raw) In-Reply-To: <CAKohpo=MfrUTYQKvJHP1Gns3kUfjqG6r9T8+7ZZ98-8yb0BZXw@mail.gmail.com> On Mon, 12 Aug 2013, Viresh Kumar wrote: > On 11 August 2013 22:21, Julia Lawall <Julia.Lawall@lip6.fr> wrote: > > From: Julia Lawall <Julia.Lawall@lip6.fr> > > > > Replace ARRAY_AND_SIZE(e) in function argument position to avoid hiding the > > arity of the called function. > > Makes sense. > > > The semantic match that makes this change is as follows: > > (http://coccinelle.lip6.fr/) > > What is this doing here? I'm not sure to understand the sense of the question. The semantic patch explains exactly what considerations were used when making the transformation. That is, any function call, having a call to ARRAY_AND_SIZE as an argument is rewritten to replace the call to ARRAY_AND_SIZE with the correspondingtwo arguments. The transformation was performed entirely automatically, although in a lot of cases it was necessary to add newlines afterwards. julia > > // <smpl> > > @@ > > expression e,f; > > @@ > > > > f(..., > > - ARRAY_AND_SIZE(e) > > + e,ARRAY_SIZE(e) > > ,...) > > // </smpl> > > > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > > > --- > > Not compiled. > > > > drivers/cpufreq/pxa3xx-cpufreq.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia.lawall@lip6.fr> To: Viresh Kumar <viresh.kumar@linaro.org> Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, kernel-janitors@vger.kernel.org, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/16] drivers/cpufreq/pxa3xx-cpufreq.c: Avoid using ARRAY_AND_SIZE(e) as a function argu Date: Mon, 12 Aug 2013 05:45:26 +0000 [thread overview] Message-ID: <alpine.DEB.2.02.1308120743030.2038@localhost6.localdomain6> (raw) In-Reply-To: <CAKohpo=MfrUTYQKvJHP1Gns3kUfjqG6r9T8+7ZZ98-8yb0BZXw@mail.gmail.com> On Mon, 12 Aug 2013, Viresh Kumar wrote: > On 11 August 2013 22:21, Julia Lawall <Julia.Lawall@lip6.fr> wrote: > > From: Julia Lawall <Julia.Lawall@lip6.fr> > > > > Replace ARRAY_AND_SIZE(e) in function argument position to avoid hiding the > > arity of the called function. > > Makes sense. > > > The semantic match that makes this change is as follows: > > (http://coccinelle.lip6.fr/) > > What is this doing here? I'm not sure to understand the sense of the question. The semantic patch explains exactly what considerations were used when making the transformation. That is, any function call, having a call to ARRAY_AND_SIZE as an argument is rewritten to replace the call to ARRAY_AND_SIZE with the correspondingtwo arguments. The transformation was performed entirely automatically, although in a lot of cases it was necessary to add newlines afterwards. julia > > // <smpl> > > @@ > > expression e,f; > > @@ > > > > f(..., > > - ARRAY_AND_SIZE(e) > > + e,ARRAY_SIZE(e) > > ,...) > > // </smpl> > > > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > > > --- > > Not compiled. > > > > drivers/cpufreq/pxa3xx-cpufreq.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
next prev parent reply other threads:[~2013-08-12 5:45 UTC|newest] Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-08-11 16:51 [PATCH 0/16] Avoid using ARRAY_AND_SIZE(e) as a function argument Julia Lawall 2013-08-11 16:51 ` Julia Lawall 2013-08-11 16:51 ` [PATCH 1/16] sound/soc/pxa/mioa701_wm9713.c: " Julia Lawall 2013-08-11 16:51 ` Julia Lawall 2013-08-11 16:51 ` Julia Lawall 2013-08-11 16:51 ` Julia Lawall 2013-08-11 18:06 ` Mark Brown 2013-08-11 18:06 ` Mark Brown 2013-08-11 18:06 ` [PATCH 1/16] sound/soc/pxa/mioa701_wm9713.c: Avoid using ARRAY_AND_SIZE(e) as a function argumen Mark Brown 2013-08-11 16:51 ` [PATCH 2/16] arch/arm/mach-pxa: Avoid using ARRAY_AND_SIZE(e) as a function argument Julia Lawall 2013-08-11 16:51 ` Julia Lawall 2013-08-11 16:51 ` Julia Lawall 2013-08-11 16:51 ` [PATCH 3/16] arch/arm/mach-ux500/cpu-db8500.c: " Julia Lawall 2013-08-11 16:51 ` Julia Lawall 2013-08-11 16:51 ` Julia Lawall 2013-08-20 9:13 ` Linus Walleij 2013-08-20 9:13 ` Linus Walleij 2013-08-20 9:13 ` [PATCH 3/16] arch/arm/mach-ux500/cpu-db8500.c: Avoid using ARRAY_AND_SIZE(e) as a function argum Linus Walleij 2013-08-11 16:51 ` [PATCH 4/16] arch/arm/mach-pxa/z2.c: Avoid using ARRAY_AND_SIZE(e) as a function argument Julia Lawall 2013-08-11 16:51 ` Julia Lawall 2013-08-11 16:51 ` Julia Lawall 2013-08-11 16:51 ` [PATCH 5/16] arch/arm/mach-pxa/vpac270.c: " Julia Lawall 2013-08-11 16:51 ` Julia Lawall 2013-08-11 16:51 ` Julia Lawall 2013-08-11 16:51 ` [PATCH 6/16] arch/arm/mach-pxa: " Julia Lawall 2013-08-11 16:51 ` Julia Lawall 2013-08-11 16:51 ` Julia Lawall 2013-08-11 16:51 ` [PATCH 7/16] arch/arm/mach-pxa/colibri-pxa270-income.c: " Julia Lawall 2013-08-11 16:51 ` Julia Lawall 2013-08-11 16:51 ` [PATCH 7/16] arch/arm/mach-pxa/colibri-pxa270-income.c: Avoid using ARRAY_AND_SIZE(e) as a function Julia Lawall 2013-08-11 16:51 ` [PATCH 8/16] arch/arm/mach-pxa/palmz72.c: Avoid using ARRAY_AND_SIZE(e) as a function argument Julia Lawall 2013-08-11 16:51 ` Julia Lawall 2013-08-11 16:51 ` Julia Lawall 2013-08-11 16:51 ` [PATCH 9/16] arch/arm/mach-pxa/mioa701.c: " Julia Lawall 2013-08-11 16:51 ` Julia Lawall 2013-08-11 16:51 ` Julia Lawall 2013-08-12 19:58 ` Robert Jarzmik 2013-08-12 19:58 ` Robert Jarzmik 2013-08-12 19:58 ` Robert Jarzmik 2013-08-12 20:24 ` Julia Lawall 2013-08-12 20:24 ` Julia Lawall 2013-08-12 20:24 ` Julia Lawall 2013-08-11 16:51 ` [PATCH 10/16] arch/arm/mach-mmp: " Julia Lawall 2013-08-11 16:51 ` Julia Lawall 2013-08-11 16:51 ` Julia Lawall 2013-08-11 16:51 ` [PATCH 11/16] arch/arm/mach-pxa/palmtreo.c: " Julia Lawall 2013-08-11 16:51 ` Julia Lawall 2013-08-11 16:51 ` Julia Lawall 2013-08-13 0:34 ` Tomas Cech 2013-08-13 0:34 ` Tomas Cech 2013-08-13 0:34 ` Tomas Cech 2013-08-11 16:51 ` [PATCH 12/16] drivers/cpufreq/pxa3xx-cpufreq.c: " Julia Lawall 2013-08-11 16:51 ` Julia Lawall 2013-08-12 5:26 ` Viresh Kumar 2013-08-12 5:38 ` [PATCH 12/16] drivers/cpufreq/pxa3xx-cpufreq.c: Avoid using ARRAY_AND_SIZE(e) as a function argu Viresh Kumar 2013-08-12 5:45 ` Julia Lawall [this message] 2013-08-12 5:45 ` Julia Lawall 2013-08-12 5:46 ` [PATCH 12/16] drivers/cpufreq/pxa3xx-cpufreq.c: Avoid using ARRAY_AND_SIZE(e) as a function argument Viresh Kumar 2013-08-12 5:58 ` [PATCH 12/16] drivers/cpufreq/pxa3xx-cpufreq.c: Avoid using ARRAY_AND_SIZE(e) as a function argu Viresh Kumar 2013-08-12 5:48 ` [PATCH 12/16] drivers/cpufreq/pxa3xx-cpufreq.c: Avoid using ARRAY_AND_SIZE(e) as a function argument Julia Lawall 2013-08-12 5:48 ` [PATCH 12/16] drivers/cpufreq/pxa3xx-cpufreq.c: Avoid using ARRAY_AND_SIZE(e) as a function argu Julia Lawall 2013-08-12 5:50 ` [PATCH 12/16] drivers/cpufreq/pxa3xx-cpufreq.c: Avoid using ARRAY_AND_SIZE(e) as a function argument Viresh Kumar 2013-08-12 5:50 ` [PATCH 12/16] drivers/cpufreq/pxa3xx-cpufreq.c: Avoid using ARRAY_AND_SIZE(e) as a function argu Viresh Kumar 2013-08-13 13:22 ` [PATCH 12/16] drivers/cpufreq/pxa3xx-cpufreq.c: Avoid using ARRAY_AND_SIZE(e) as a function argument Rafael J. Wysocki 2013-08-13 13:22 ` [PATCH 12/16] drivers/cpufreq/pxa3xx-cpufreq.c: Avoid using ARRAY_AND_SIZE(e) as a function argu Rafael J. Wysocki 2013-08-11 16:51 ` [PATCH 13/16] arch/arm/mach-pxa/hx4700.c: Avoid using ARRAY_AND_SIZE(e) as a function argument Julia Lawall 2013-08-11 16:51 ` Julia Lawall 2013-08-11 16:51 ` Julia Lawall 2013-08-11 16:51 ` [PATCH 14/16] arch/arm/mach-pxa/ezx.c: " Julia Lawall 2013-08-11 16:51 ` Julia Lawall 2013-08-11 16:51 ` Julia Lawall 2013-08-11 16:51 ` [PATCH 15/16] arch/arm/mach-kirkwood: " Julia Lawall 2013-08-11 16:51 ` Julia Lawall 2013-08-11 16:51 ` Julia Lawall 2013-08-12 19:14 ` Jason Cooper 2013-08-12 19:14 ` Jason Cooper 2013-08-12 19:14 ` Jason Cooper 2013-08-11 16:51 ` [PATCH 16/16] arch/arm/mach-pxa/stargate2.c: " Julia Lawall 2013-08-11 16:51 ` Julia Lawall 2013-08-11 16:51 ` Julia Lawall 2013-08-12 8:22 ` [PATCH 16/16] arch/arm/mach-pxa/stargate2.c: Avoid using ARRAY_AND_SIZE(e) as a function argumen Jonathan Cameron 2013-08-12 9:22 ` [PATCH 16/16] arch/arm/mach-pxa/stargate2.c: Avoid using ARRAY_AND_SIZE(e) as a function argument Jonathan Cameron 2013-08-12 9:22 ` Jonathan Cameron
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=alpine.DEB.2.02.1308120743030.2038@localhost6.localdomain6 \ --to=julia.lawall@lip6.fr \ --cc=cpufreq@vger.kernel.org \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=rjw@sisk.pl \ --cc=viresh.kumar@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.