From: Stefano Stabellini <stefano.stabellini@eu.citrix.com> To: Catalin Marinas <catalin.marinas@arm.com> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "Ian.Campbell@citrix.com" <Ian.Campbell@citrix.com> Subject: Re: [PATCH v6 10/19] xen: introduce xen_alloc/free_coherent_pages Date: Wed, 2 Oct 2013 18:03:46 +0100 [thread overview] Message-ID: <alpine.DEB.2.02.1310021754580.26077@kaball.uk.xensource.com> (raw) In-Reply-To: <DB675896-3FF2-409B-A2C6-24295C197A3F@arm.com> On Tue, 1 Oct 2013, Catalin Marinas wrote: > On 30 Sep 2013, at 16:31, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote: > > On Fri, Sep 27, 2013 at 05:09:58PM +0100, Stefano Stabellini wrote: > >> xen_swiotlb_alloc_coherent needs to allocate a coherent buffer for cpu > >> and devices. On native x86 and ARMv8 is sufficient to call > >> __get_free_pages in order to get a coherent buffer, while on ARM we need > >> to call the native dma_ops->alloc implementation. > >> > >> When arm64 stops using the swiotlb by default and starts having multiple > >> dma_ops implementations, we'll use __get_dma_ops there too. > > > > I presume this is a future TODO, not some further patch (in which > > case you should say in here the title of it). If it is a TODO could > > you stick that in the sentence here somewhere to make it crytal clear that > > it is not implemented. > > Thanks for pointing this out. The arm64 patch shouldn't be different > from arm here. I thought a subsequent patch already added > __get_dma_ops() for arm64. Yes, the arm64 patch already added __get_dma_ops. However I am not using __get_dma_ops to implement xen_alloc_coherent_pages for arm64 because I can just use __get_free_pages for the moment: > diff --git a/arch/arm64/include/asm/xen/page-coherent.h b/arch/arm64/include/asm/xen/page-coherent.h > new file mode 100644 > index 0000000..0d6ad25 > --- /dev/null > +++ b/arch/arm64/include/asm/xen/page-coherent.h > @@ -0,0 +1,24 @@ > +#ifndef _ASM_ARM64_XEN_PAGE_COHERENT_H > +#define _ASM_ARM64_XEN_PAGE_COHERENT_H > + > +#include <asm/page.h> > +#include <linux/dma-attrs.h> > +#include <linux/dma-mapping.h> > + > +static inline void *xen_alloc_coherent_pages(struct device *hwdev, size_t size, > + dma_addr_t *dma_handle, gfp_t flags, > + struct dma_attrs *attrs) > +{ > + void *vstart = (void*)__get_free_pages(flags, get_order(size)); > + *dma_handle = virt_to_phys(vstart); > + return vstart; > +} > + > +static inline void xen_free_coherent_pages(struct device *hwdev, size_t size, > + void *cpu_addr, dma_addr_t dma_handle, > + struct dma_attrs *attrs) > +{ > + free_pages((unsigned long) cpu_addr, get_order(size)); > +} > + > +#endif /* _ASM_ARM64_XEN_PAGE_COHERENT_H */
WARNING: multiple messages have this Message-ID (diff)
From: stefano.stabellini@eu.citrix.com (Stefano Stabellini) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v6 10/19] xen: introduce xen_alloc/free_coherent_pages Date: Wed, 2 Oct 2013 18:03:46 +0100 [thread overview] Message-ID: <alpine.DEB.2.02.1310021754580.26077@kaball.uk.xensource.com> (raw) In-Reply-To: <DB675896-3FF2-409B-A2C6-24295C197A3F@arm.com> On Tue, 1 Oct 2013, Catalin Marinas wrote: > On 30 Sep 2013, at 16:31, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote: > > On Fri, Sep 27, 2013 at 05:09:58PM +0100, Stefano Stabellini wrote: > >> xen_swiotlb_alloc_coherent needs to allocate a coherent buffer for cpu > >> and devices. On native x86 and ARMv8 is sufficient to call > >> __get_free_pages in order to get a coherent buffer, while on ARM we need > >> to call the native dma_ops->alloc implementation. > >> > >> When arm64 stops using the swiotlb by default and starts having multiple > >> dma_ops implementations, we'll use __get_dma_ops there too. > > > > I presume this is a future TODO, not some further patch (in which > > case you should say in here the title of it). If it is a TODO could > > you stick that in the sentence here somewhere to make it crytal clear that > > it is not implemented. > > Thanks for pointing this out. The arm64 patch shouldn't be different > from arm here. I thought a subsequent patch already added > __get_dma_ops() for arm64. Yes, the arm64 patch already added __get_dma_ops. However I am not using __get_dma_ops to implement xen_alloc_coherent_pages for arm64 because I can just use __get_free_pages for the moment: > diff --git a/arch/arm64/include/asm/xen/page-coherent.h b/arch/arm64/include/asm/xen/page-coherent.h > new file mode 100644 > index 0000000..0d6ad25 > --- /dev/null > +++ b/arch/arm64/include/asm/xen/page-coherent.h > @@ -0,0 +1,24 @@ > +#ifndef _ASM_ARM64_XEN_PAGE_COHERENT_H > +#define _ASM_ARM64_XEN_PAGE_COHERENT_H > + > +#include <asm/page.h> > +#include <linux/dma-attrs.h> > +#include <linux/dma-mapping.h> > + > +static inline void *xen_alloc_coherent_pages(struct device *hwdev, size_t size, > + dma_addr_t *dma_handle, gfp_t flags, > + struct dma_attrs *attrs) > +{ > + void *vstart = (void*)__get_free_pages(flags, get_order(size)); > + *dma_handle = virt_to_phys(vstart); > + return vstart; > +} > + > +static inline void xen_free_coherent_pages(struct device *hwdev, size_t size, > + void *cpu_addr, dma_addr_t dma_handle, > + struct dma_attrs *attrs) > +{ > + free_pages((unsigned long) cpu_addr, get_order(size)); > +} > + > +#endif /* _ASM_ARM64_XEN_PAGE_COHERENT_H */
next prev parent reply other threads:[~2013-10-02 17:04 UTC|newest] Thread overview: 133+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-09-27 16:09 [PATCH v6 0/19] enable swiotlb-xen on arm and arm64 Stefano Stabellini 2013-09-27 16:09 ` Stefano Stabellini 2013-09-27 16:09 ` Stefano Stabellini 2013-09-27 16:09 ` [PATCH v6 01/19] arm: make SWIOTLB available Stefano Stabellini 2013-09-27 16:09 ` Stefano Stabellini 2013-09-27 16:09 ` Stefano Stabellini 2013-09-27 16:09 ` [PATCH v6 02/19] arm64: define DMA_ERROR_CODE Stefano Stabellini 2013-09-27 16:09 ` Stefano Stabellini 2013-09-27 16:09 ` Stefano Stabellini 2013-09-30 10:47 ` Catalin Marinas 2013-09-30 10:47 ` Catalin Marinas 2013-09-30 10:47 ` Catalin Marinas 2013-09-27 16:09 ` [PATCH v6 03/19] xen: introduce XENMEM_exchange_and_pin and XENMEM_unpin Stefano Stabellini 2013-09-27 16:09 ` Stefano Stabellini 2013-09-27 16:09 ` Stefano Stabellini 2013-09-30 14:54 ` Konrad Rzeszutek Wilk 2013-09-30 14:54 ` Konrad Rzeszutek Wilk 2013-09-27 16:09 ` [PATCH v6 04/19] xen: make xen_create_contiguous_region return the dma address Stefano Stabellini 2013-09-27 16:09 ` Stefano Stabellini 2013-09-27 16:09 ` Stefano Stabellini 2013-09-27 16:09 ` [PATCH v6 05/19] swiotlb-xen: support autotranslate guests Stefano Stabellini 2013-09-27 16:09 ` Stefano Stabellini 2013-09-27 16:09 ` Stefano Stabellini 2013-09-27 16:09 ` [PATCH v6 06/19] xen/arm,arm64: enable SWIOTLB_XEN Stefano Stabellini 2013-09-27 16:09 ` Stefano Stabellini 2013-09-27 16:09 ` Stefano Stabellini 2013-09-30 15:14 ` Konrad Rzeszutek Wilk 2013-09-30 15:14 ` Konrad Rzeszutek Wilk 2013-09-27 16:09 ` [PATCH v6 07/19] swiotlb-xen: introduce xen_swiotlb_set_dma_mask Stefano Stabellini 2013-09-27 16:09 ` Stefano Stabellini 2013-09-27 16:09 ` Stefano Stabellini 2013-09-27 16:09 ` [PATCH v6 08/19] arm/xen: get_dma_ops: return xen_dma_ops if we are running on Xen Stefano Stabellini 2013-09-27 16:09 ` Stefano Stabellini 2013-09-27 16:09 ` Stefano Stabellini 2013-09-30 15:17 ` Konrad Rzeszutek Wilk 2013-09-30 15:17 ` Konrad Rzeszutek Wilk 2013-09-30 15:17 ` Konrad Rzeszutek Wilk 2013-09-27 16:09 ` [PATCH v6 09/19] arm64/xen: " Stefano Stabellini 2013-09-27 16:09 ` Stefano Stabellini 2013-09-27 16:09 ` Stefano Stabellini 2013-09-30 10:48 ` Catalin Marinas 2013-09-30 10:48 ` Catalin Marinas 2013-09-30 10:48 ` Catalin Marinas 2013-09-27 16:09 ` [PATCH v6 10/19] xen: introduce xen_alloc/free_coherent_pages Stefano Stabellini 2013-09-27 16:09 ` Stefano Stabellini 2013-09-27 16:09 ` Stefano Stabellini 2013-09-30 15:31 ` Konrad Rzeszutek Wilk 2013-09-30 15:31 ` Konrad Rzeszutek Wilk 2013-10-01 13:40 ` Catalin Marinas 2013-10-01 13:40 ` Catalin Marinas 2013-10-01 13:40 ` Catalin Marinas 2013-10-02 17:03 ` Stefano Stabellini [this message] 2013-10-02 17:03 ` Stefano Stabellini 2013-10-02 17:03 ` Stefano Stabellini 2013-10-02 17:07 ` Catalin Marinas 2013-10-02 17:07 ` Catalin Marinas 2013-10-02 17:07 ` Catalin Marinas 2013-10-02 17:14 ` Stefano Stabellini 2013-10-02 17:14 ` Stefano Stabellini 2013-10-02 17:14 ` Stefano Stabellini 2013-09-27 16:09 ` [PATCH v6 11/19] swiotlb-xen: use xen_alloc/free_coherent_pages Stefano Stabellini 2013-09-27 16:09 ` Stefano Stabellini 2013-09-27 16:09 ` Stefano Stabellini 2013-09-30 15:34 ` Konrad Rzeszutek Wilk 2013-09-30 15:34 ` Konrad Rzeszutek Wilk 2013-09-27 16:10 ` [PATCH v6 12/19] swiotlb: don't assume that io_tlb_start-io_tlb_end is coherent Stefano Stabellini 2013-09-27 16:10 ` Stefano Stabellini 2013-09-27 16:10 ` Stefano Stabellini 2013-09-30 15:56 ` Konrad Rzeszutek Wilk 2013-09-30 15:56 ` Konrad Rzeszutek Wilk 2013-10-02 17:31 ` Stefano Stabellini 2013-10-02 17:31 ` Stefano Stabellini 2013-10-02 17:31 ` Stefano Stabellini 2013-10-04 13:23 ` Konrad Rzeszutek Wilk 2013-10-04 13:23 ` Konrad Rzeszutek Wilk 2013-09-27 16:10 ` [PATCH v6 13/19] ASoC: Samsung: Rename dma_ops by samsung_dma_ops Stefano Stabellini 2013-09-27 16:10 ` Stefano Stabellini 2013-09-27 16:10 ` Stefano Stabellini 2013-09-27 16:10 ` [PATCH v6 14/19] swiotlb: print a warning when the swiotlb is full Stefano Stabellini 2013-09-27 16:10 ` Stefano Stabellini 2013-09-27 16:10 ` Stefano Stabellini 2013-09-30 15:58 ` Konrad Rzeszutek Wilk 2013-09-30 15:58 ` Konrad Rzeszutek Wilk 2013-10-09 17:31 ` Stefano Stabellini 2013-10-09 17:31 ` Stefano Stabellini 2013-10-09 17:31 ` Stefano Stabellini 2013-09-27 16:10 ` [PATCH v6 15/19] swiotlb-xen: call dma_capable only if dev->dma_mask is allocated Stefano Stabellini 2013-09-27 16:10 ` Stefano Stabellini 2013-09-27 16:10 ` Stefano Stabellini 2013-09-30 16:02 ` Konrad Rzeszutek Wilk 2013-09-30 16:02 ` Konrad Rzeszutek Wilk 2013-10-02 17:13 ` Stefano Stabellini 2013-10-02 17:13 ` Stefano Stabellini 2013-10-02 17:13 ` Stefano Stabellini 2013-10-02 17:22 ` Konrad Rzeszutek Wilk 2013-10-02 17:22 ` Konrad Rzeszutek Wilk 2013-10-02 17:22 ` Konrad Rzeszutek Wilk 2013-10-03 18:35 ` Rob Herring 2013-10-03 18:35 ` Rob Herring 2013-10-03 18:35 ` Rob Herring 2013-09-27 16:10 ` [PATCH v6 16/19] arm,arm64: do not always merge biovec if we are running on Xen Stefano Stabellini 2013-09-27 16:10 ` Stefano Stabellini 2013-09-27 16:10 ` [PATCH v6 16/19] arm, arm64: " Stefano Stabellini 2013-09-30 16:06 ` [PATCH v6 16/19] arm,arm64: " Konrad Rzeszutek Wilk 2013-09-30 16:06 ` [PATCH v6 16/19] arm, arm64: " Konrad Rzeszutek Wilk 2013-09-30 16:06 ` Konrad Rzeszutek Wilk 2013-10-09 17:54 ` [PATCH v6 16/19] arm,arm64: " Stefano Stabellini 2013-10-09 17:54 ` Stefano Stabellini 2013-10-09 17:54 ` Stefano Stabellini 2013-09-27 16:10 ` [PATCH v6 17/19] xen: introduce XENMEM_pin Stefano Stabellini 2013-09-27 16:10 ` Stefano Stabellini 2013-09-27 16:10 ` Stefano Stabellini 2013-09-30 17:22 ` Konrad Rzeszutek Wilk 2013-09-30 17:22 ` Konrad Rzeszutek Wilk 2013-09-27 16:10 ` [PATCH v6 18/19] swiotlb-xen: introduce a rbtree to track phys to bus mappings Stefano Stabellini 2013-09-27 16:10 ` Stefano Stabellini 2013-09-27 16:10 ` Stefano Stabellini 2013-09-30 17:27 ` Konrad Rzeszutek Wilk 2013-09-30 17:27 ` Konrad Rzeszutek Wilk 2013-10-02 17:23 ` Stefano Stabellini 2013-10-02 17:23 ` Stefano Stabellini 2013-10-02 17:23 ` Stefano Stabellini 2013-10-09 17:25 ` Stefano Stabellini 2013-10-09 17:25 ` Stefano Stabellini 2013-10-09 17:25 ` Stefano Stabellini 2013-09-27 16:10 ` [PATCH v6 19/19] swiotlb-xen: instead of bouncing on the swiotlb, pin single pages Stefano Stabellini 2013-09-27 16:10 ` Stefano Stabellini 2013-09-27 16:10 ` Stefano Stabellini 2013-09-30 17:39 ` Konrad Rzeszutek Wilk 2013-09-30 17:39 ` Konrad Rzeszutek Wilk 2013-10-09 17:27 ` Stefano Stabellini 2013-10-09 17:27 ` Stefano Stabellini 2013-10-09 17:27 ` Stefano Stabellini
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=alpine.DEB.2.02.1310021754580.26077@kaball.uk.xensource.com \ --to=stefano.stabellini@eu.citrix.com \ --cc=Ian.Campbell@citrix.com \ --cc=catalin.marinas@arm.com \ --cc=konrad.wilk@oracle.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=xen-devel@lists.xensource.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.