From: David Rientjes <rientjes@google.com>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Ingo Molnar <mingo@kernel.org>,
linux-mm@kvack.org, josh@joshtriplett.org
Subject: Re: [PATCH 5/9] mm: Mark functions as static in migrate.c
Date: Fri, 7 Feb 2014 12:49:53 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.02.1402071249420.4212@chino.kir.corp.google.com> (raw)
In-Reply-To: <2f62d7bb34ad1797b2990524239d4de90f8073a4.1391167128.git.rashika.kheria@gmail.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 581 bytes --]
On Fri, 7 Feb 2014, Rashika Kheria wrote:
> Mark functions as static in migrate.c because they are not used outside
> this file.
>
> This eliminates the following warnings in mm/migrate.c:
> mm/migrate.c:1595:6: warning: no previous prototype for ‘numamigrate_update_ratelimit’ [-Wmissing-prototypes]
> mm/migrate.c:1619:5: warning: no previous prototype for ‘numamigrate_isolate_page’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Acked-by: David Rientjes <rientjes@google.com>
WARNING: multiple messages have this Message-ID (diff)
From: David Rientjes <rientjes@google.com>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Ingo Molnar <mingo@kernel.org>,
linux-mm@kvack.org, josh@joshtriplett.org
Subject: Re: [PATCH 5/9] mm: Mark functions as static in migrate.c
Date: Fri, 7 Feb 2014 12:49:53 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.02.1402071249420.4212@chino.kir.corp.google.com> (raw)
In-Reply-To: <2f62d7bb34ad1797b2990524239d4de90f8073a4.1391167128.git.rashika.kheria@gmail.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 581 bytes --]
On Fri, 7 Feb 2014, Rashika Kheria wrote:
> Mark functions as static in migrate.c because they are not used outside
> this file.
>
> This eliminates the following warnings in mm/migrate.c:
> mm/migrate.c:1595:6: warning: no previous prototype for a??numamigrate_update_ratelimita?? [-Wmissing-prototypes]
> mm/migrate.c:1619:5: warning: no previous prototype for a??numamigrate_isolate_pagea?? [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Acked-by: David Rientjes <rientjes@google.com>
next prev parent reply other threads:[~2014-02-07 20:49 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 12:01 [PATCH 1/9] mm: Mark function as static in compaction.c Rashika Kheria
2014-02-07 12:01 ` Rashika Kheria
2014-02-07 12:03 ` [PATCH 2/9] mm: Mark functions as static in memory.c Rashika Kheria
2014-02-07 12:03 ` Rashika Kheria
2014-02-07 13:03 ` Rik van Riel
2014-02-07 13:03 ` Rik van Riel
2014-02-07 20:47 ` David Rientjes
2014-02-07 20:47 ` David Rientjes
2014-02-07 12:04 ` [PATCH 3/9] mm: Mark function as static in mmap.c Rashika Kheria
2014-02-07 12:04 ` Rashika Kheria
2014-02-07 13:16 ` Rik van Riel
2014-02-07 13:16 ` Rik van Riel
2014-02-07 20:47 ` David Rientjes
2014-02-07 20:47 ` David Rientjes
2014-02-07 12:07 ` [PATCH 4/9] mm: Mark function as static in process_vm_access.c Rashika Kheria
2014-02-07 12:07 ` Rashika Kheria
2014-02-07 20:49 ` David Rientjes
2014-02-07 20:49 ` David Rientjes
2014-02-07 12:08 ` [PATCH 5/9] mm: Mark functions as static in migrate.c Rashika Kheria
2014-02-07 12:08 ` Rashika Kheria
2014-02-07 13:16 ` Rik van Riel
2014-02-07 13:16 ` Rik van Riel
2014-02-07 20:49 ` David Rientjes [this message]
2014-02-07 20:49 ` David Rientjes
2014-02-07 12:10 ` [PATCH 6/9] mm: Mark function as static in memcontrol.c Rashika Kheria
2014-02-07 12:10 ` Rashika Kheria
2014-02-07 12:10 ` Rashika Kheria
2014-02-07 20:55 ` David Rientjes
2014-02-07 20:55 ` David Rientjes
2014-02-07 20:55 ` David Rientjes
[not found] ` <a7658fc8f2ab015bffe83de1448cc3db79d2a9fc.1391167128.git.rashika.kheria-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-02-07 12:11 ` [PATCH 7/9] mm: Mark functions as static in page_cgroup.c Rashika Kheria
2014-02-07 12:11 ` Rashika Kheria
2014-02-07 12:11 ` Rashika Kheria
2014-02-07 12:11 ` Rashika Kheria
2014-02-07 20:56 ` David Rientjes
2014-02-07 20:56 ` David Rientjes
2014-02-07 20:56 ` David Rientjes
[not found] ` <6054d570fc83c3d4f3de240d6da488f876e21450.1391167128.git.rashika.kheria-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-02-07 20:56 ` David Rientjes
2014-02-10 8:23 ` Michal Hocko
2014-02-10 8:23 ` Michal Hocko
2014-02-07 12:12 ` [PATCH 8/9] mm: Mark function as static in nobootmem.c Rashika Kheria
2014-02-07 12:12 ` Rashika Kheria
2014-02-07 20:57 ` David Rientjes
2014-02-07 20:57 ` David Rientjes
2014-02-07 12:15 ` [PATCH 9/9] mm: Remove ifdef condition in include/linux/mm.h Rashika Kheria
2014-02-07 12:15 ` Rashika Kheria
2014-02-07 13:18 ` Rik van Riel
2014-02-07 13:18 ` Rik van Riel
2014-02-07 21:04 ` David Rientjes
2014-02-07 21:04 ` David Rientjes
2014-02-07 21:07 ` Josh Triplett
2014-02-07 21:07 ` Josh Triplett
2014-02-07 21:15 ` David Rientjes
2014-02-07 21:15 ` David Rientjes
2014-02-07 22:30 ` Andrew Morton
2014-02-07 22:30 ` Andrew Morton
2014-02-07 23:09 ` David Rientjes
2014-02-07 23:09 ` David Rientjes
2014-02-07 23:27 ` Josh Triplett
2014-02-07 23:27 ` Josh Triplett
2014-02-08 1:02 ` David Rientjes
2014-02-08 1:02 ` David Rientjes
2014-02-08 1:25 ` Josh Triplett
2014-02-08 1:25 ` Josh Triplett
2014-02-07 12:51 ` [PATCH 1/9] mm: Mark function as static in compaction.c Rik van Riel
2014-02-07 12:51 ` Rik van Riel
2014-02-07 20:43 ` David Rientjes
2014-02-07 20:43 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1402071249420.4212@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=rashika.kheria@gmail.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.