All of lore.kernel.org
 help / color / mirror / Atom feed
* [Cocci] [PATCH] scripts/coccinelle: Use PTR_ERR_OR_ZERO
@ 2014-01-27  6:51 Sachin Kamat
  2014-02-06  3:09 ` Sachin Kamat
  2014-04-08 15:29   ` [Cocci] " Michal Marek
  0 siblings, 2 replies; 7+ messages in thread
From: Sachin Kamat @ 2014-01-27  6:51 UTC (permalink / raw)
  To: cocci

PTR_RET is deprecated. Do not recommend its usage anymore.
Use PTR_ERR_OR_ZERO instead.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 scripts/coccinelle/api/ptr_ret.cocci |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/scripts/coccinelle/api/ptr_ret.cocci b/scripts/coccinelle/api/ptr_ret.cocci
index e18f8402e37c..dd58dab5d411 100644
--- a/scripts/coccinelle/api/ptr_ret.cocci
+++ b/scripts/coccinelle/api/ptr_ret.cocci
@@ -7,7 +7,7 @@
 // URL: http://coccinelle.lip6.fr/
 // Options: --no-includes --include-headers
 //
-// Keywords: ERR_PTR, PTR_ERR, PTR_RET, PTR_ERR_OR_ZERO
+// Keywords: ERR_PTR, PTR_ERR, PTR_ERR_OR_ZERO
 // Version min: 2.6.39
 //
 
@@ -62,35 +62,35 @@ position p3;
 p << r1.p1;
 @@
 
-coccilib.org.print_todo(p[0], "WARNING: PTR_RET can be used")
+coccilib.org.print_todo(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
 
 
 @script:python depends on org@
 p << r2.p2;
 @@
 
-coccilib.org.print_todo(p[0], "WARNING: PTR_RET can be used")
+coccilib.org.print_todo(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
 
 @script:python depends on org@
 p << r3.p3;
 @@
 
-coccilib.org.print_todo(p[0], "WARNING: PTR_RET can be used")
+coccilib.org.print_todo(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
 
 @script:python depends on report@
 p << r1.p1;
 @@
 
-coccilib.report.print_report(p[0], "WARNING: PTR_RET can be used")
+coccilib.report.print_report(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
 
 @script:python depends on report@
 p << r2.p2;
 @@
 
-coccilib.report.print_report(p[0], "WARNING: PTR_RET can be used")
+coccilib.report.print_report(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
 
 @script:python depends on report@
 p << r3.p3;
 @@
 
-coccilib.report.print_report(p[0], "WARNING: PTR_RET can be used")
+coccilib.report.print_report(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [Cocci] [PATCH] scripts/coccinelle: Use PTR_ERR_OR_ZERO
  2014-01-27  6:51 [Cocci] [PATCH] scripts/coccinelle: Use PTR_ERR_OR_ZERO Sachin Kamat
@ 2014-02-06  3:09 ` Sachin Kamat
  2014-02-08 20:11   ` Julia Lawall
  2014-04-08 15:29   ` [Cocci] " Michal Marek
  1 sibling, 1 reply; 7+ messages in thread
From: Sachin Kamat @ 2014-02-06  3:09 UTC (permalink / raw)
  To: cocci

On 27 January 2014 12:21, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> PTR_RET is deprecated. Do not recommend its usage anymore.
> Use PTR_ERR_OR_ZERO instead.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  scripts/coccinelle/api/ptr_ret.cocci |   14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/scripts/coccinelle/api/ptr_ret.cocci b/scripts/coccinelle/api/ptr_ret.cocci
> index e18f8402e37c..dd58dab5d411 100644
> --- a/scripts/coccinelle/api/ptr_ret.cocci
> +++ b/scripts/coccinelle/api/ptr_ret.cocci
> @@ -7,7 +7,7 @@
>  // URL: http://coccinelle.lip6.fr/
>  // Options: --no-includes --include-headers
>  //
> -// Keywords: ERR_PTR, PTR_ERR, PTR_RET, PTR_ERR_OR_ZERO
> +// Keywords: ERR_PTR, PTR_ERR, PTR_ERR_OR_ZERO
>  // Version min: 2.6.39
>  //
>
> @@ -62,35 +62,35 @@ position p3;
>  p << r1.p1;
>  @@
>
> -coccilib.org.print_todo(p[0], "WARNING: PTR_RET can be used")
> +coccilib.org.print_todo(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
>
>
>  @script:python depends on org@
>  p << r2.p2;
>  @@
>
> -coccilib.org.print_todo(p[0], "WARNING: PTR_RET can be used")
> +coccilib.org.print_todo(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
>
>  @script:python depends on org@
>  p << r3.p3;
>  @@
>
> -coccilib.org.print_todo(p[0], "WARNING: PTR_RET can be used")
> +coccilib.org.print_todo(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
>
>  @script:python depends on report@
>  p << r1.p1;
>  @@
>
> -coccilib.report.print_report(p[0], "WARNING: PTR_RET can be used")
> +coccilib.report.print_report(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
>
>  @script:python depends on report@
>  p << r2.p2;
>  @@
>
> -coccilib.report.print_report(p[0], "WARNING: PTR_RET can be used")
> +coccilib.report.print_report(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
>
>  @script:python depends on report@
>  p << r3.p3;
>  @@
>
> -coccilib.report.print_report(p[0], "WARNING: PTR_RET can be used")
> +coccilib.report.print_report(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
> --
> 1.7.9.5
>

Gentle ping..

-- 
With warm regards,
Sachin

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Cocci] [PATCH] scripts/coccinelle: Use PTR_ERR_OR_ZERO
  2014-02-06  3:09 ` Sachin Kamat
@ 2014-02-08 20:11   ` Julia Lawall
  2014-02-17  4:01     ` Sachin Kamat
  2014-03-10 15:27     ` Sachin Kamat
  0 siblings, 2 replies; 7+ messages in thread
From: Julia Lawall @ 2014-02-08 20:11 UTC (permalink / raw)
  To: cocci



On Thu, 6 Feb 2014, Sachin Kamat wrote:

> On 27 January 2014 12:21, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> > PTR_RET is deprecated. Do not recommend its usage anymore.
> > Use PTR_ERR_OR_ZERO instead.

Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>


> >
> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> > ---
> >  scripts/coccinelle/api/ptr_ret.cocci |   14 +++++++-------
> >  1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/scripts/coccinelle/api/ptr_ret.cocci b/scripts/coccinelle/api/ptr_ret.cocci
> > index e18f8402e37c..dd58dab5d411 100644
> > --- a/scripts/coccinelle/api/ptr_ret.cocci
> > +++ b/scripts/coccinelle/api/ptr_ret.cocci
> > @@ -7,7 +7,7 @@
> >  // URL: http://coccinelle.lip6.fr/
> >  // Options: --no-includes --include-headers
> >  //
> > -// Keywords: ERR_PTR, PTR_ERR, PTR_RET, PTR_ERR_OR_ZERO
> > +// Keywords: ERR_PTR, PTR_ERR, PTR_ERR_OR_ZERO
> >  // Version min: 2.6.39
> >  //
> >
> > @@ -62,35 +62,35 @@ position p3;
> >  p << r1.p1;
> >  @@
> >
> > -coccilib.org.print_todo(p[0], "WARNING: PTR_RET can be used")
> > +coccilib.org.print_todo(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
> >
> >
> >  @script:python depends on org@
> >  p << r2.p2;
> >  @@
> >
> > -coccilib.org.print_todo(p[0], "WARNING: PTR_RET can be used")
> > +coccilib.org.print_todo(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
> >
> >  @script:python depends on org@
> >  p << r3.p3;
> >  @@
> >
> > -coccilib.org.print_todo(p[0], "WARNING: PTR_RET can be used")
> > +coccilib.org.print_todo(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
> >
> >  @script:python depends on report@
> >  p << r1.p1;
> >  @@
> >
> > -coccilib.report.print_report(p[0], "WARNING: PTR_RET can be used")
> > +coccilib.report.print_report(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
> >
> >  @script:python depends on report@
> >  p << r2.p2;
> >  @@
> >
> > -coccilib.report.print_report(p[0], "WARNING: PTR_RET can be used")
> > +coccilib.report.print_report(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
> >
> >  @script:python depends on report@
> >  p << r3.p3;
> >  @@
> >
> > -coccilib.report.print_report(p[0], "WARNING: PTR_RET can be used")
> > +coccilib.report.print_report(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
> > --
> > 1.7.9.5
> >
> 
> Gentle ping..
> 
> -- 
> With warm regards,
> Sachin
> 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Cocci] [PATCH] scripts/coccinelle: Use PTR_ERR_OR_ZERO
  2014-02-08 20:11   ` Julia Lawall
@ 2014-02-17  4:01     ` Sachin Kamat
  2014-03-10 15:27     ` Sachin Kamat
  1 sibling, 0 replies; 7+ messages in thread
From: Sachin Kamat @ 2014-02-17  4:01 UTC (permalink / raw)
  To: cocci

Hi Michal,

On 9 February 2014 01:41, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
> On Thu, 6 Feb 2014, Sachin Kamat wrote:
>
>> On 27 January 2014 12:21, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>> > PTR_RET is deprecated. Do not recommend its usage anymore.
>> > Use PTR_ERR_OR_ZERO instead.
>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
>
>
>> >
>> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

I believe this patch would be going through your tree?

-- 
With warm regards,
Sachin

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Cocci] [PATCH] scripts/coccinelle: Use PTR_ERR_OR_ZERO
  2014-02-08 20:11   ` Julia Lawall
  2014-02-17  4:01     ` Sachin Kamat
@ 2014-03-10 15:27     ` Sachin Kamat
  1 sibling, 0 replies; 7+ messages in thread
From: Sachin Kamat @ 2014-03-10 15:27 UTC (permalink / raw)
  To: cocci

On 9 February 2014 01:41, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
> On Thu, 6 Feb 2014, Sachin Kamat wrote:
>
>> On 27 January 2014 12:21, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>> > PTR_RET is deprecated. Do not recommend its usage anymore.
>> > Use PTR_ERR_OR_ZERO instead.
>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
>
>
>> >
>> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> > ---

 Ping Michal.


-- 
With warm regards,
Sachin

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] scripts/coccinelle: Use PTR_ERR_OR_ZERO
  2014-01-27  6:51 [Cocci] [PATCH] scripts/coccinelle: Use PTR_ERR_OR_ZERO Sachin Kamat
@ 2014-04-08 15:29   ` Michal Marek
  2014-04-08 15:29   ` [Cocci] " Michal Marek
  1 sibling, 0 replies; 7+ messages in thread
From: Michal Marek @ 2014-04-08 15:29 UTC (permalink / raw)
  To: Sachin Kamat
  Cc: cocci, Julia.Lawall, Gilles.Muller, nicolas.palix, patches, lkml

On 2014-01-27 07:51, Sachin Kamat wrote:
> PTR_RET is deprecated. Do not recommend its usage anymore.
> Use PTR_ERR_OR_ZERO instead.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

Applied to kbuild.git#misc, sorry for the delay. But please always add
lkml to the cc list.

Thanks,
Michal


> ---
>  scripts/coccinelle/api/ptr_ret.cocci |   14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/scripts/coccinelle/api/ptr_ret.cocci b/scripts/coccinelle/api/ptr_ret.cocci
> index e18f8402e37c..dd58dab5d411 100644
> --- a/scripts/coccinelle/api/ptr_ret.cocci
> +++ b/scripts/coccinelle/api/ptr_ret.cocci
> @@ -7,7 +7,7 @@
>  // URL: http://coccinelle.lip6.fr/
>  // Options: --no-includes --include-headers
>  //
> -// Keywords: ERR_PTR, PTR_ERR, PTR_RET, PTR_ERR_OR_ZERO
> +// Keywords: ERR_PTR, PTR_ERR, PTR_ERR_OR_ZERO
>  // Version min: 2.6.39
>  //
>  
> @@ -62,35 +62,35 @@ position p3;
>  p << r1.p1;
>  @@
>  
> -coccilib.org.print_todo(p[0], "WARNING: PTR_RET can be used")
> +coccilib.org.print_todo(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
>  
>  
>  @script:python depends on org@
>  p << r2.p2;
>  @@
>  
> -coccilib.org.print_todo(p[0], "WARNING: PTR_RET can be used")
> +coccilib.org.print_todo(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
>  
>  @script:python depends on org@
>  p << r3.p3;
>  @@
>  
> -coccilib.org.print_todo(p[0], "WARNING: PTR_RET can be used")
> +coccilib.org.print_todo(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
>  
>  @script:python depends on report@
>  p << r1.p1;
>  @@
>  
> -coccilib.report.print_report(p[0], "WARNING: PTR_RET can be used")
> +coccilib.report.print_report(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
>  
>  @script:python depends on report@
>  p << r2.p2;
>  @@
>  
> -coccilib.report.print_report(p[0], "WARNING: PTR_RET can be used")
> +coccilib.report.print_report(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
>  
>  @script:python depends on report@
>  p << r3.p3;
>  @@
>  
> -coccilib.report.print_report(p[0], "WARNING: PTR_RET can be used")
> +coccilib.report.print_report(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
> 


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Cocci] [PATCH] scripts/coccinelle: Use PTR_ERR_OR_ZERO
@ 2014-04-08 15:29   ` Michal Marek
  0 siblings, 0 replies; 7+ messages in thread
From: Michal Marek @ 2014-04-08 15:29 UTC (permalink / raw)
  To: cocci

On 2014-01-27 07:51, Sachin Kamat wrote:
> PTR_RET is deprecated. Do not recommend its usage anymore.
> Use PTR_ERR_OR_ZERO instead.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

Applied to kbuild.git#misc, sorry for the delay. But please always add
lkml to the cc list.

Thanks,
Michal


> ---
>  scripts/coccinelle/api/ptr_ret.cocci |   14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/scripts/coccinelle/api/ptr_ret.cocci b/scripts/coccinelle/api/ptr_ret.cocci
> index e18f8402e37c..dd58dab5d411 100644
> --- a/scripts/coccinelle/api/ptr_ret.cocci
> +++ b/scripts/coccinelle/api/ptr_ret.cocci
> @@ -7,7 +7,7 @@
>  // URL: http://coccinelle.lip6.fr/
>  // Options: --no-includes --include-headers
>  //
> -// Keywords: ERR_PTR, PTR_ERR, PTR_RET, PTR_ERR_OR_ZERO
> +// Keywords: ERR_PTR, PTR_ERR, PTR_ERR_OR_ZERO
>  // Version min: 2.6.39
>  //
>  
> @@ -62,35 +62,35 @@ position p3;
>  p << r1.p1;
>  @@
>  
> -coccilib.org.print_todo(p[0], "WARNING: PTR_RET can be used")
> +coccilib.org.print_todo(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
>  
>  
>  @script:python depends on org@
>  p << r2.p2;
>  @@
>  
> -coccilib.org.print_todo(p[0], "WARNING: PTR_RET can be used")
> +coccilib.org.print_todo(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
>  
>  @script:python depends on org@
>  p << r3.p3;
>  @@
>  
> -coccilib.org.print_todo(p[0], "WARNING: PTR_RET can be used")
> +coccilib.org.print_todo(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
>  
>  @script:python depends on report@
>  p << r1.p1;
>  @@
>  
> -coccilib.report.print_report(p[0], "WARNING: PTR_RET can be used")
> +coccilib.report.print_report(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
>  
>  @script:python depends on report@
>  p << r2.p2;
>  @@
>  
> -coccilib.report.print_report(p[0], "WARNING: PTR_RET can be used")
> +coccilib.report.print_report(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
>  
>  @script:python depends on report@
>  p << r3.p3;
>  @@
>  
> -coccilib.report.print_report(p[0], "WARNING: PTR_RET can be used")
> +coccilib.report.print_report(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
> 

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2014-04-08 15:29 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-27  6:51 [Cocci] [PATCH] scripts/coccinelle: Use PTR_ERR_OR_ZERO Sachin Kamat
2014-02-06  3:09 ` Sachin Kamat
2014-02-08 20:11   ` Julia Lawall
2014-02-17  4:01     ` Sachin Kamat
2014-03-10 15:27     ` Sachin Kamat
2014-04-08 15:29 ` Michal Marek
2014-04-08 15:29   ` [Cocci] " Michal Marek

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.