Re: [patch 07/26] pci: pcie-designware: Remove irq_desc abuse

Re: [patch 07/26] pci: pcie-designware: Remove irq_desc abuse

[Jingoo Han]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 1608 bytes --]

On Monday, February 24, 2014 6:40 AM, Thomas Gleixner wrote:
> 
> There is no reason to care about irq_desc in that context, escpecially
> as irq_data for that interrupt is retrieved as well.
> 
> Use the proper accessor for the msi descriptor
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Jingoo Han <jg1.han@samsung.com>
> Cc: Mohit Kumar <mohit.kumar@st.com>
> Cc: pci <linux-pci@vger.kernel.org>

Acked-by: Jingoo Han <jg1.han@samsung.com>

A few days ago, I noticed that irq_data_get_msi() can be used.
However, I did not submit the same patch. I really appreciate
your patch. :-)

Best regards,
Jingoo Han

> ---
>  drivers/pci/host/pcie-designware.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> Index: tip/drivers/pci/host/pcie-designware.c
> ===================================================================
> --- tip.orig/drivers/pci/host/pcie-designware.c
> +++ tip/drivers/pci/host/pcie-designware.c
> @@ -294,14 +294,12 @@ no_valid_irq:
>  static void clear_irq(unsigned int irq)
>  {
>  	unsigned int pos, nvec;
> -	struct irq_desc *desc;
>  	struct msi_desc *msi;
>  	struct pcie_port *pp;
>  	struct irq_data *data = irq_get_irq_data(irq);
> 
>  	/* get the port structure */
> -	desc = irq_to_desc(irq);
> -	msi = irq_desc_get_msi_desc(desc);
> +	msi = irq_data_get_msi(data);
>  	pp = sys_to_pcie(msi->dev->bus->sysdata);
>  	if (!pp) {
>  		BUG();ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [patch 07/26] pci: pcie-designware: Remove irq_desc abuse

[Jingoo Han]

T24gTW9uZGF5LCBGZWJydWFyeSAyNCwgMjAxNCA2OjQwIEFNLCBUaG9tYXMgR2xlaXhuZXIgd3Jv
dGU6DQo+IA0KPiBUaGVyZSBpcyBubyByZWFzb24gdG8gY2FyZSBhYm91dCBpcnFfZGVzYyBpbiB0
aGF0IGNvbnRleHQsIGVzY3BlY2lhbGx5DQo+IGFzIGlycV9kYXRhIGZvciB0aGF0IGludGVycnVw
dCBpcyByZXRyaWV2ZWQgYXMgd2VsbC4NCj4gDQo+IFVzZSB0aGUgcHJvcGVyIGFjY2Vzc29yIGZv
ciB0aGUgbXNpIGRlc2NyaXB0b3INCj4gDQo+IFNpZ25lZC1vZmYtYnk6IFRob21hcyBHbGVpeG5l
ciA8dGdseEBsaW51dHJvbml4LmRlPg0KPiBDYzogQmpvcm4gSGVsZ2FhcyA8YmhlbGdhYXNAZ29v
Z2xlLmNvbT4NCj4gQ2M6IEppbmdvbyBIYW4gPGpnMS5oYW5Ac2Ftc3VuZy5jb20+DQo+IENjOiBN
b2hpdCBLdW1hciA8bW9oaXQua3VtYXJAc3QuY29tPg0KPiBDYzogcGNpIDxsaW51eC1wY2lAdmdl
ci5rZXJuZWwub3JnPg0KDQpBY2tlZC1ieTogSmluZ29vIEhhbiA8amcxLmhhbkBzYW1zdW5nLmNv
bT4NCg0KQSBmZXcgZGF5cyBhZ28sIEkgbm90aWNlZCB0aGF0IGlycV9kYXRhX2dldF9tc2koKSBj
YW4gYmUgdXNlZC4NCkhvd2V2ZXIsIEkgZGlkIG5vdCBzdWJtaXQgdGhlIHNhbWUgcGF0Y2guIEkg
cmVhbGx5IGFwcHJlY2lhdGUNCnlvdXIgcGF0Y2guIDotKQ0KDQpCZXN0IHJlZ2FyZHMsDQpKaW5n
b28gSGFuDQoNCj4gLS0tDQo+ICBkcml2ZXJzL3BjaS9ob3N0L3BjaWUtZGVzaWdud2FyZS5jIHwg
ICAgNCArLS0tDQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDMgZGVsZXRpb25z
KC0pDQo+IA0KPiBJbmRleDogdGlwL2RyaXZlcnMvcGNpL2hvc3QvcGNpZS1kZXNpZ253YXJlLmMN
Cj4gPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PQ0KPiAtLS0gdGlwLm9yaWcvZHJpdmVycy9wY2kvaG9zdC9wY2llLWRlc2ln
bndhcmUuYw0KPiArKysgdGlwL2RyaXZlcnMvcGNpL2hvc3QvcGNpZS1kZXNpZ253YXJlLmMNCj4g
QEAgLTI5NCwxNCArMjk0LDEyIEBAIG5vX3ZhbGlkX2lycToNCj4gIHN0YXRpYyB2b2lkIGNsZWFy
X2lycSh1bnNpZ25lZCBpbnQgaXJxKQ0KPiAgew0KPiAgCXVuc2lnbmVkIGludCBwb3MsIG52ZWM7
DQo+IC0Jc3RydWN0IGlycV9kZXNjICpkZXNjOw0KPiAgCXN0cnVjdCBtc2lfZGVzYyAqbXNpOw0K
PiAgCXN0cnVjdCBwY2llX3BvcnQgKnBwOw0KPiAgCXN0cnVjdCBpcnFfZGF0YSAqZGF0YSA9IGly
cV9nZXRfaXJxX2RhdGEoaXJxKTsNCj4gDQo+ICAJLyogZ2V0IHRoZSBwb3J0IHN0cnVjdHVyZSAq
Lw0KPiAtCWRlc2MgPSBpcnFfdG9fZGVzYyhpcnEpOw0KPiAtCW1zaSA9IGlycV9kZXNjX2dldF9t
c2lfZGVzYyhkZXNjKTsNCj4gKwltc2kgPSBpcnFfZGF0YV9nZXRfbXNpKGRhdGEpOw0KPiAgCXBw
ID0gc3lzX3RvX3BjaWUobXNpLT5kZXYtPmJ1cy0+c3lzZGF0YSk7DQo+ICAJaWYgKCFwcCkgew0K
PiAgCQlCVUcoKTs=

Re: [patch 07/26] pci: pcie-designware: Remove irq_desc abuse

[Bjorn Helgaas]

On Sun, Feb 23, 2014 at 4:33 PM, Jingoo Han <jg1.han@samsung.com> wrote:
> On Monday, February 24, 2014 6:40 AM, Thomas Gleixner wrote:
>>
>> There is no reason to care about irq_desc in that context, escpecially
>> as irq_data for that interrupt is retrieved as well.
>>
>> Use the proper accessor for the msi descriptor
>>
>> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>> Cc: Bjorn Helgaas <bhelgaas@google.com>
>> Cc: Jingoo Han <jg1.han@samsung.com>
>> Cc: Mohit Kumar <mohit.kumar@st.com>
>> Cc: pci <linux-pci@vger.kernel.org>
>
> Acked-by: Jingoo Han <jg1.han@samsung.com>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

Thomas, I assume you'll merge this along with the rest of your series.
 I don't have any pending changes in this area.

Bjorn

> A few days ago, I noticed that irq_data_get_msi() can be used.
> However, I did not submit the same patch. I really appreciate
> your patch. :-)
>
> Best regards,
> Jingoo Han
>
>> ---
>>  drivers/pci/host/pcie-designware.c |    4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> Index: tip/drivers/pci/host/pcie-designware.c
>> ===================================================================
>> --- tip.orig/drivers/pci/host/pcie-designware.c
>> +++ tip/drivers/pci/host/pcie-designware.c
>> @@ -294,14 +294,12 @@ no_valid_irq:
>>  static void clear_irq(unsigned int irq)
>>  {
>>       unsigned int pos, nvec;
>> -     struct irq_desc *desc;
>>       struct msi_desc *msi;
>>       struct pcie_port *pp;
>>       struct irq_data *data = irq_get_irq_data(irq);
>>
>>       /* get the port structure */
>> -     desc = irq_to_desc(irq);
>> -     msi = irq_desc_get_msi_desc(desc);
>> +     msi = irq_data_get_msi(data);
>>       pp = sys_to_pcie(msi->dev->bus->sysdata);
>>       if (!pp) {
>>               BUG();

Re: [patch 07/26] pci: pcie-designware: Remove irq_desc abuse

[Thomas Gleixner]

On Mon, 24 Feb 2014, Bjorn Helgaas wrote:
> On Sun, Feb 23, 2014 at 4:33 PM, Jingoo Han <jg1.han@samsung.com> wrote:
> > On Monday, February 24, 2014 6:40 AM, Thomas Gleixner wrote:
> >>
> >> There is no reason to care about irq_desc in that context, escpecially
> >> as irq_data for that interrupt is retrieved as well.
> >>
> >> Use the proper accessor for the msi descriptor
> >>
> >> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> >> Cc: Bjorn Helgaas <bhelgaas@google.com>
> >> Cc: Jingoo Han <jg1.han@samsung.com>
> >> Cc: Mohit Kumar <mohit.kumar@st.com>
> >> Cc: pci <linux-pci@vger.kernel.org>
> >
> > Acked-by: Jingoo Han <jg1.han@samsung.com>
> 
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> 
> Thomas, I assume you'll merge this along with the rest of your series.
>  I don't have any pending changes in this area.

I can do, but it does not depend on anything else, so you can pick it
up as well. Either way is fine.

Thanks,

	tglx

Re: [patch 07/26] pci: pcie-designware: Remove irq_desc abuse

[Bjorn Helgaas]

On Mon, Feb 24, 2014 at 3:06 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Mon, 24 Feb 2014, Bjorn Helgaas wrote:
>> On Sun, Feb 23, 2014 at 4:33 PM, Jingoo Han <jg1.han@samsung.com> wrote:
>> > On Monday, February 24, 2014 6:40 AM, Thomas Gleixner wrote:
>> >>
>> >> There is no reason to care about irq_desc in that context, escpecially
>> >> as irq_data for that interrupt is retrieved as well.
>> >>
>> >> Use the proper accessor for the msi descriptor
>> >>
>> >> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>> >> Cc: Bjorn Helgaas <bhelgaas@google.com>
>> >> Cc: Jingoo Han <jg1.han@samsung.com>
>> >> Cc: Mohit Kumar <mohit.kumar@st.com>
>> >> Cc: pci <linux-pci@vger.kernel.org>
>> >
>> > Acked-by: Jingoo Han <jg1.han@samsung.com>
>>
>> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
>>
>> Thomas, I assume you'll merge this along with the rest of your series.
>>  I don't have any pending changes in this area.
>
> I can do, but it does not depend on anything else, so you can pick it
> up as well. Either way is fine.

I never know what to do with these.  I suggested that you pick it up
so the whole series would be together, because I assumed it would make
more sense in the git history to have all these similar changes
grouped together.  But maybe that really doesn't matter.

What's the recommended practice?

Bjorn

Re: [patch 07/26] pci: pcie-designware: Remove irq_desc abuse

[Thomas Gleixner]

On Mon, 24 Feb 2014, Bjorn Helgaas wrote:

> On Mon, Feb 24, 2014 at 3:06 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> > On Mon, 24 Feb 2014, Bjorn Helgaas wrote:
> >> On Sun, Feb 23, 2014 at 4:33 PM, Jingoo Han <jg1.han@samsung.com> wrote:
> >> > On Monday, February 24, 2014 6:40 AM, Thomas Gleixner wrote:
> >> >>
> >> >> There is no reason to care about irq_desc in that context, escpecially
> >> >> as irq_data for that interrupt is retrieved as well.
> >> >>
> >> >> Use the proper accessor for the msi descriptor
> >> >>
> >> >> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> >> >> Cc: Bjorn Helgaas <bhelgaas@google.com>
> >> >> Cc: Jingoo Han <jg1.han@samsung.com>
> >> >> Cc: Mohit Kumar <mohit.kumar@st.com>
> >> >> Cc: pci <linux-pci@vger.kernel.org>
> >> >
> >> > Acked-by: Jingoo Han <jg1.han@samsung.com>
> >>
> >> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> >>
> >> Thomas, I assume you'll merge this along with the rest of your series.
> >>  I don't have any pending changes in this area.
> >
> > I can do, but it does not depend on anything else, so you can pick it
> > up as well. Either way is fine.
> 
> I never know what to do with these.  I suggested that you pick it up
> so the whole series would be together, because I assumed it would make
> more sense in the git history to have all these similar changes
> grouped together.  But maybe that really doesn't matter.
> 
> What's the recommended practice?

Dunno. There is no rule. I'll merge it up with the rest of the lot.

Thanks,

	tglx

[patch 07/26] pci: pcie-designware: Remove irq_desc abuse

[Thomas Gleixner]

[-- Attachment #1: pci-pcie-designware-remove-irq-desc-abuse.patch --]
[-- Type: text/plain, Size: 1107 bytes --]

There is no reason to care about irq_desc in that context, escpecially
as irq_data for that interrupt is retrieved as well.

Use the proper accessor for the msi descriptor

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Jingoo Han <jg1.han@samsung.com>
Cc: Mohit Kumar <mohit.kumar@st.com>
Cc: pci <linux-pci@vger.kernel.org>
---
 drivers/pci/host/pcie-designware.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Index: tip/drivers/pci/host/pcie-designware.c
===================================================================
--- tip.orig/drivers/pci/host/pcie-designware.c
+++ tip/drivers/pci/host/pcie-designware.c
@@ -294,14 +294,12 @@ no_valid_irq:
 static void clear_irq(unsigned int irq)
 {
 	unsigned int pos, nvec;
-	struct irq_desc *desc;
 	struct msi_desc *msi;
 	struct pcie_port *pp;
 	struct irq_data *data = irq_get_irq_data(irq);
 
 	/* get the port structure */
-	desc = irq_to_desc(irq);
-	msi = irq_desc_get_msi_desc(desc);
+	msi = irq_data_get_msi(data);
 	pp = sys_to_pcie(msi->dev->bus->sysdata);
 	if (!pp) {
 		BUG();

[patch 07/26] pci: pcie-designware: Remove irq_desc abuse

[Thomas Gleixner]

There is no reason to care about irq_desc in that context, escpecially
as irq_data for that interrupt is retrieved as well.

Use the proper accessor for the msi descriptor

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Jingoo Han <jg1.han@samsung.com>
Cc: Mohit Kumar <mohit.kumar@st.com>
Cc: pci <linux-pci@vger.kernel.org>
---
 drivers/pci/host/pcie-designware.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Index: tip/drivers/pci/host/pcie-designware.c
===================================================================
--- tip.orig/drivers/pci/host/pcie-designware.c
+++ tip/drivers/pci/host/pcie-designware.c
@@ -294,14 +294,12 @@ no_valid_irq:
 static void clear_irq(unsigned int irq)
 {
 	unsigned int pos, nvec;
-	struct irq_desc *desc;
 	struct msi_desc *msi;
 	struct pcie_port *pp;
 	struct irq_data *data = irq_get_irq_data(irq);
 
 	/* get the port structure */
-	desc = irq_to_desc(irq);
-	msi = irq_desc_get_msi_desc(desc);
+	msi = irq_data_get_msi(data);
 	pp = sys_to_pcie(msi->dev->bus->sysdata);
 	if (!pp) {
 		BUG();