All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mm: make copy_pte_range static again
@ 2014-07-01  8:17 ` Jerome Marchand
  0 siblings, 0 replies; 4+ messages in thread
From: Jerome Marchand @ 2014-07-01  8:17 UTC (permalink / raw)
  To: linux-mm; +Cc: linux-kernel, Andrea Arcangeli

Commit 71e3aac (thp: transparent hugepage core) adds copy_pte_range
prototype to huge_mm.h. I'm not sure why (or if) this function have
been used outside of memory.c, but it currently isn't.
This patch makes copy_pte_range() static again.

Signed-off-by: Jerome Marchand <jmarchan@redhat.com>
---
 include/linux/huge_mm.h | 4 ----
 mm/memory.c             | 2 +-
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h
index b826239..63579cb 100644
--- a/include/linux/huge_mm.h
+++ b/include/linux/huge_mm.h
@@ -93,10 +93,6 @@ extern bool is_vma_temporary_stack(struct vm_area_struct *vma);
 #endif /* CONFIG_DEBUG_VM */
 
 extern unsigned long transparent_hugepage_flags;
-extern int copy_pte_range(struct mm_struct *dst_mm, struct mm_struct *src_mm,
-			  pmd_t *dst_pmd, pmd_t *src_pmd,
-			  struct vm_area_struct *vma,
-			  unsigned long addr, unsigned long end);
 extern int split_huge_page_to_list(struct page *page, struct list_head *list);
 static inline int split_huge_page(struct page *page)
 {
diff --git a/mm/memory.c b/mm/memory.c
index 09e2cd0..13141ae 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -884,7 +884,7 @@ out_set_pte:
 	return 0;
 }
 
-int copy_pte_range(struct mm_struct *dst_mm, struct mm_struct *src_mm,
+static int copy_pte_range(struct mm_struct *dst_mm, struct mm_struct *src_mm,
 		   pmd_t *dst_pmd, pmd_t *src_pmd, struct vm_area_struct *vma,
 		   unsigned long addr, unsigned long end)
 {
-- 
1.9.3


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] mm: make copy_pte_range static again
@ 2014-07-01  8:17 ` Jerome Marchand
  0 siblings, 0 replies; 4+ messages in thread
From: Jerome Marchand @ 2014-07-01  8:17 UTC (permalink / raw)
  To: linux-mm; +Cc: linux-kernel, Andrea Arcangeli

Commit 71e3aac (thp: transparent hugepage core) adds copy_pte_range
prototype to huge_mm.h. I'm not sure why (or if) this function have
been used outside of memory.c, but it currently isn't.
This patch makes copy_pte_range() static again.

Signed-off-by: Jerome Marchand <jmarchan@redhat.com>
---
 include/linux/huge_mm.h | 4 ----
 mm/memory.c             | 2 +-
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h
index b826239..63579cb 100644
--- a/include/linux/huge_mm.h
+++ b/include/linux/huge_mm.h
@@ -93,10 +93,6 @@ extern bool is_vma_temporary_stack(struct vm_area_struct *vma);
 #endif /* CONFIG_DEBUG_VM */
 
 extern unsigned long transparent_hugepage_flags;
-extern int copy_pte_range(struct mm_struct *dst_mm, struct mm_struct *src_mm,
-			  pmd_t *dst_pmd, pmd_t *src_pmd,
-			  struct vm_area_struct *vma,
-			  unsigned long addr, unsigned long end);
 extern int split_huge_page_to_list(struct page *page, struct list_head *list);
 static inline int split_huge_page(struct page *page)
 {
diff --git a/mm/memory.c b/mm/memory.c
index 09e2cd0..13141ae 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -884,7 +884,7 @@ out_set_pte:
 	return 0;
 }
 
-int copy_pte_range(struct mm_struct *dst_mm, struct mm_struct *src_mm,
+static int copy_pte_range(struct mm_struct *dst_mm, struct mm_struct *src_mm,
 		   pmd_t *dst_pmd, pmd_t *src_pmd, struct vm_area_struct *vma,
 		   unsigned long addr, unsigned long end)
 {
-- 
1.9.3

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] mm: make copy_pte_range static again
  2014-07-01  8:17 ` Jerome Marchand
@ 2014-07-01 23:35   ` David Rientjes
  -1 siblings, 0 replies; 4+ messages in thread
From: David Rientjes @ 2014-07-01 23:35 UTC (permalink / raw)
  To: Jerome Marchand; +Cc: linux-mm, linux-kernel, Andrea Arcangeli

On Tue, 1 Jul 2014, Jerome Marchand wrote:

> Commit 71e3aac (thp: transparent hugepage core) adds copy_pte_range
> prototype to huge_mm.h. I'm not sure why (or if) this function have
> been used outside of memory.c, but it currently isn't.
> This patch makes copy_pte_range() static again.
> 
> Signed-off-by: Jerome Marchand <jmarchan@redhat.com>

Acked-by: David Rientjes <rientjes@google.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mm: make copy_pte_range static again
@ 2014-07-01 23:35   ` David Rientjes
  0 siblings, 0 replies; 4+ messages in thread
From: David Rientjes @ 2014-07-01 23:35 UTC (permalink / raw)
  To: Jerome Marchand; +Cc: linux-mm, linux-kernel, Andrea Arcangeli

On Tue, 1 Jul 2014, Jerome Marchand wrote:

> Commit 71e3aac (thp: transparent hugepage core) adds copy_pte_range
> prototype to huge_mm.h. I'm not sure why (or if) this function have
> been used outside of memory.c, but it currently isn't.
> This patch makes copy_pte_range() static again.
> 
> Signed-off-by: Jerome Marchand <jmarchan@redhat.com>

Acked-by: David Rientjes <rientjes@google.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-07-01 23:36 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-01  8:17 [PATCH] mm: make copy_pte_range static again Jerome Marchand
2014-07-01  8:17 ` Jerome Marchand
2014-07-01 23:35 ` David Rientjes
2014-07-01 23:35   ` David Rientjes

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.