From: Julia Lawall <julia.lawall@lip6.fr> To: Josh Triplett <josh@joshtriplett.org> Cc: Paul Mackerras <paulus@samba.org>, kernel-janitors@vger.kernel.org, Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>, Tomi Valkeinen <tomi.valkeinen@ti.com>, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 8/9 v2] video: fbdev: aty: use c99 initializers in structures Date: Sat, 23 Aug 2014 17:50:28 +0200 (CEST) [thread overview] Message-ID: <alpine.DEB.2.02.1408231749030.2068@localhost6.localdomain6> (raw) In-Reply-To: <20140823152015.GB2074@thin> >From nobody Sat Aug 23 12:48:19 CEST 2014 From: Julia Lawall <Julia.Lawall@lip6.fr> To: Paul Mackerras <paulus@samba.org> Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,Tomi Valkeinen <tomi.valkeinen@ti.com>,linux-fbdev@vger.kernel.org,linux-kernel@vger.kernel.org Subject: [PATCH 8/9] video: fbdev: aty: use c99 initializers in structures From: Julia Lawall <Julia.Lawall@lip6.fr> Use c99 initializers for structures. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @decl@ identifier i1,fld; type T; field list[n] fs; @@ struct i1 { fs T fld; ...}; @bad@ identifier decl.i1,i2; expression e; initializer list[decl.n] is; @@ struct i1 i2 = { is, + .fld = e - e ,...}; // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- The patches in this series do not depend on each other. v2: Move close braces down to the next line and add trailing commas, as suggested by Josh Triplett. diff --git a/drivers/video/fbdev/aty/aty128fb.c b/drivers/video/fbdev/aty/aty128fb.c index ff60701..aedf2fb 100644 --- a/drivers/video/fbdev/aty/aty128fb.c +++ b/drivers/video/fbdev/aty/aty128fb.c @@ -324,14 +324,61 @@ struct aty128_meminfo { }; /* various memory configurations */ -static const struct aty128_meminfo sdr_128 = - { 4, 4, 3, 3, 1, 3, 1, 16, 30, 16, "128-bit SDR SGRAM (1:1)" }; -static const struct aty128_meminfo sdr_64 = - { 4, 8, 3, 3, 1, 3, 1, 17, 46, 17, "64-bit SDR SGRAM (1:1)" }; -static const struct aty128_meminfo sdr_sgram = - { 4, 4, 1, 2, 1, 2, 1, 16, 24, 16, "64-bit SDR SGRAM (2:1)" }; -static const struct aty128_meminfo ddr_sgram = - { 4, 4, 3, 3, 2, 3, 1, 16, 31, 16, "64-bit DDR SGRAM" }; +static const struct aty128_meminfo sdr_128 = { + .ML = 4, + .MB = 4, + .Trcd = 3, + .Trp = 3, + .Twr = 1, + .CL = 3, + .Tr2w = 1, + .LoopLatency = 16, + .DspOn = 30, + .Rloop = 16, + .name = "128-bit SDR SGRAM (1:1)", +}; + +static const struct aty128_meminfo sdr_64 = { + .ML = 4, + .MB = 8, + .Trcd = 3, + .Trp = 3, + .Twr = 1, + .CL = 3, + .Tr2w = 1, + .LoopLatency = 17, + .DspOn = 46, + .Rloop = 17, + .name = "64-bit SDR SGRAM (1:1)", +}; + +static const struct aty128_meminfo sdr_sgram = { + .ML = 4, + .MB = 4, + .Trcd = 1, + .Trp = 2, + .Twr = 1, + .CL = 2, + .Tr2w = 1, + .LoopLatency = 16, + .DspOn = 24, + .Rloop = 16, + .name = "64-bit SDR SGRAM (2:1)", +}; + +static const struct aty128_meminfo ddr_sgram = { + .ML = 4, + .MB = 4, + .Trcd = 3, + .Trp = 3, + .Twr = 2, + .CL = 3, + .Tr2w = 1, + .LoopLatency = 16, + .DspOn = 31, + .Rloop = 16, + .name = "64-bit DDR SGRAM", +}; static struct fb_fix_screeninfo aty128fb_fix = { .id = "ATY Rage128",
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia.lawall@lip6.fr> To: Josh Triplett <josh@joshtriplett.org> Cc: Paul Mackerras <paulus@samba.org>, kernel-janitors@vger.kernel.org, Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>, Tomi Valkeinen <tomi.valkeinen@ti.com>, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 8/9 v2] video: fbdev: aty: use c99 initializers in structures Date: Sat, 23 Aug 2014 15:50:28 +0000 [thread overview] Message-ID: <alpine.DEB.2.02.1408231749030.2068@localhost6.localdomain6> (raw) In-Reply-To: <20140823152015.GB2074@thin> From nobody Sat Aug 23 12:48:19 CEST 2014 From: Julia Lawall <Julia.Lawall@lip6.fr> To: Paul Mackerras <paulus@samba.org> Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,Tomi Valkeinen <tomi.valkeinen@ti.com>,linux-fbdev@vger.kernel.org,linux-kernel@vger.kernel.org Subject: [PATCH 8/9] video: fbdev: aty: use c99 initializers in structures From: Julia Lawall <Julia.Lawall@lip6.fr> Use c99 initializers for structures. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @decl@ identifier i1,fld; type T; field list[n] fs; @@ struct i1 { fs T fld; ...}; @bad@ identifier decl.i1,i2; expression e; initializer list[decl.n] is; @@ struct i1 i2 = { is, + .fld = e - e ,...}; // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- The patches in this series do not depend on each other. v2: Move close braces down to the next line and add trailing commas, as suggested by Josh Triplett. diff --git a/drivers/video/fbdev/aty/aty128fb.c b/drivers/video/fbdev/aty/aty128fb.c index ff60701..aedf2fb 100644 --- a/drivers/video/fbdev/aty/aty128fb.c +++ b/drivers/video/fbdev/aty/aty128fb.c @@ -324,14 +324,61 @@ struct aty128_meminfo { }; /* various memory configurations */ -static const struct aty128_meminfo sdr_128 - { 4, 4, 3, 3, 1, 3, 1, 16, 30, 16, "128-bit SDR SGRAM (1:1)" }; -static const struct aty128_meminfo sdr_64 - { 4, 8, 3, 3, 1, 3, 1, 17, 46, 17, "64-bit SDR SGRAM (1:1)" }; -static const struct aty128_meminfo sdr_sgram - { 4, 4, 1, 2, 1, 2, 1, 16, 24, 16, "64-bit SDR SGRAM (2:1)" }; -static const struct aty128_meminfo ddr_sgram - { 4, 4, 3, 3, 2, 3, 1, 16, 31, 16, "64-bit DDR SGRAM" }; +static const struct aty128_meminfo sdr_128 = { + .ML = 4, + .MB = 4, + .Trcd = 3, + .Trp = 3, + .Twr = 1, + .CL = 3, + .Tr2w = 1, + .LoopLatency = 16, + .DspOn = 30, + .Rloop = 16, + .name = "128-bit SDR SGRAM (1:1)", +}; + +static const struct aty128_meminfo sdr_64 = { + .ML = 4, + .MB = 8, + .Trcd = 3, + .Trp = 3, + .Twr = 1, + .CL = 3, + .Tr2w = 1, + .LoopLatency = 17, + .DspOn = 46, + .Rloop = 17, + .name = "64-bit SDR SGRAM (1:1)", +}; + +static const struct aty128_meminfo sdr_sgram = { + .ML = 4, + .MB = 4, + .Trcd = 1, + .Trp = 2, + .Twr = 1, + .CL = 2, + .Tr2w = 1, + .LoopLatency = 16, + .DspOn = 24, + .Rloop = 16, + .name = "64-bit SDR SGRAM (2:1)", +}; + +static const struct aty128_meminfo ddr_sgram = { + .ML = 4, + .MB = 4, + .Trcd = 3, + .Trp = 3, + .Twr = 2, + .CL = 3, + .Tr2w = 1, + .LoopLatency = 16, + .DspOn = 31, + .Rloop = 16, + .name = "64-bit DDR SGRAM", +}; static struct fb_fix_screeninfo aty128fb_fix = { .id = "ATY Rage128",
next prev parent reply other threads:[~2014-08-23 15:50 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-08-23 11:20 [PATCH 0/9] use c99 initializers in structures Julia Lawall 2014-08-23 11:20 ` Julia Lawall 2014-08-23 11:20 ` Julia Lawall 2014-08-23 11:20 ` Julia Lawall 2014-08-23 11:20 ` [PATCH 1/9] [media] v4l: ti-vpe: " Julia Lawall 2014-08-23 11:20 ` Julia Lawall 2014-08-23 11:20 ` [PATCH 2/9] video: fbdev: matrox: " Julia Lawall 2014-08-23 11:20 ` Julia Lawall 2014-08-23 11:20 ` [PATCH 3/9] pwm: lpss: " Julia Lawall 2014-08-23 11:20 ` Julia Lawall 2014-08-25 9:44 ` Thierry Reding 2014-08-25 9:44 ` Thierry Reding 2014-08-23 11:20 ` [PATCH 4/9] NFC: " Julia Lawall 2014-08-23 11:20 ` Julia Lawall 2014-08-23 11:20 ` Julia Lawall 2014-08-23 11:20 ` [PATCH 5/9] lustre: obdclass: " Julia Lawall 2014-08-23 11:20 ` Julia Lawall 2014-08-23 11:20 ` [PATCH 6/9] drm: " Julia Lawall 2014-08-23 11:20 ` Julia Lawall 2014-08-23 15:16 ` Josh Triplett 2014-08-23 15:16 ` Josh Triplett 2014-08-23 16:09 ` [PATCH 6/9 v2] " Julia Lawall 2014-08-23 16:09 ` Julia Lawall 2014-08-25 13:18 ` Daniel Vetter 2014-08-25 13:18 ` Daniel Vetter 2014-08-23 11:20 ` [PATCH 7/9] OMAPDSS: DSI: " Julia Lawall 2014-08-23 11:20 ` Julia Lawall 2014-08-23 11:20 ` [PATCH 8/9] video: fbdev: aty: " Julia Lawall 2014-08-23 11:20 ` Julia Lawall 2014-08-23 15:20 ` Josh Triplett 2014-08-23 15:20 ` Josh Triplett 2014-08-23 15:32 ` Julia Lawall 2014-08-23 15:32 ` Julia Lawall 2014-08-23 16:03 ` Josh Triplett 2014-08-23 16:03 ` Josh Triplett 2014-08-25 10:16 ` Dan Carpenter 2014-08-25 10:16 ` Dan Carpenter 2014-08-23 15:50 ` Julia Lawall [this message] 2014-08-23 15:50 ` [PATCH 8/9 v2] " Julia Lawall 2014-08-23 16:03 ` Josh Triplett 2014-08-23 16:03 ` Josh Triplett 2014-08-26 10:43 ` Tomi Valkeinen 2014-08-26 10:43 ` Tomi Valkeinen 2014-08-23 11:20 ` [PATCH 9/9] rtc: " Julia Lawall 2014-08-23 11:20 ` Julia Lawall 2014-08-23 15:21 ` [PATCH 0/9] " Josh Triplett 2014-08-23 15:21 ` Josh Triplett 2014-08-23 15:21 ` Josh Triplett
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=alpine.DEB.2.02.1408231749030.2068@localhost6.localdomain6 \ --to=julia.lawall@lip6.fr \ --cc=josh@joshtriplett.org \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=paulus@samba.org \ --cc=plagnioj@jcrosoft.com \ --cc=tomi.valkeinen@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.