Re: [RFC 4/7] libxl: Add "stubdomain_version" to domain_build_info.

[Stefano Stabellini <stefano.stabellini@eu.citrix.com>]

On Fri, 6 Feb 2015, Eric Shelton wrote:
> On Fri, Feb 6, 2015 at 11:06 AM, Stefano Stabellini
> <stefano.stabellini@eu.citrix.com> wrote:
> > On Tue, 3 Feb 2015, Eric Shelton wrote:
> >> This enum gives the ability to select between a MiniOS-based QEMU
> >> traditional stub domain and a Linux-based QEMU upstream stub domain.  To
> >> use the Linux-based stubdomain, the following two lines should be
> >> included in the appropriate xl.cfg file:
> >>
> >> device_model_version="qemu-xen"
> >> device_model_stubdomain_override=1
> >>
> >> To use the MiniOS-based stubdomain, the following is used instead:
> >>
> >> device_model_version="qemu-xen-traditional"
> >> device_model_stubdomain_override=1
> 
> ...
> 
> >> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
> >> index 02be466..8d0ac3b 100644
> >> --- a/tools/libxl/libxl_types.idl
> >> +++ b/tools/libxl/libxl_types.idl
> >> @@ -83,6 +83,12 @@ libxl_device_model_version = Enumeration("device_model_version", [
> >>      (2, "QEMU_XEN"),             # Upstream based qemu-xen device model
> >>      ])
> >>
> >> +# Give the kernel running in the stub-domain
> >> +libxl_stubdomain_version = Enumeration("stubdomain_version", [
> >
> > This should just be called stubdomain_version.
> 
> I'm sorry - I don't quite catch what you are suggesting.  Are you
> saying that the VM config file should have a line like this?
> 
> stubdomain_version="linux"

Sorry I misread your patch. Ignore my previous comment.