* [PATCH] Staging: i2o: Remove indentation of labels
@ 2015-03-26 0:02 Helen Fornazier
2015-03-26 6:33 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 3+ messages in thread
From: Helen Fornazier @ 2015-03-26 0:02 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Helen Fornazier
This patch fixes the checkpatche.pl warnings:
WARNING: labels should not be indented
+ context_remove:
WARNING: labels should not be indented
+ nop_msg:
WARNING: labels should not be indented
+ exit:
Signed-off-by: Helen Fornazier <helen.fornazier@gmail.com>
---
drivers/staging/i2o/i2o_block.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/i2o/i2o_block.c b/drivers/staging/i2o/i2o_block.c
index 7784787..406758f 100644
--- a/drivers/staging/i2o/i2o_block.c
+++ b/drivers/staging/i2o/i2o_block.c
@@ -871,13 +871,13 @@ static int i2o_block_transfer(struct request *req)
return 0;
- context_remove:
+context_remove:
i2o_cntxt_list_remove(c, req);
- nop_msg:
+nop_msg:
i2o_msg_nop(c, msg);
- exit:
+exit:
return rc;
};
@@ -1002,13 +1002,13 @@ static struct i2o_block_device *i2o_block_device_alloc(void)
return dev;
- cleanup_queue:
+cleanup_queue:
put_disk(gd);
- cleanup_dev:
+cleanup_dev:
kfree(dev);
- exit:
+exit:
return ERR_PTR(rc);
};
@@ -1115,10 +1115,10 @@ static int i2o_block_probe(struct device *dev)
return 0;
- claim_release:
+claim_release:
i2o_device_claim_release(i2o_dev);
- exit:
+exit:
return rc;
};
@@ -1187,16 +1187,16 @@ static int __init i2o_block_init(void)
return 0;
- unregister_blkdev:
+unregister_blkdev:
unregister_blkdev(I2O_MAJOR, "i2o_block");
- free_mempool:
+free_mempool:
mempool_destroy(i2o_blk_req_pool.pool);
- free_slab:
+free_slab:
kmem_cache_destroy(i2o_blk_req_pool.slab);
- exit:
+exit:
return rc;
};
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: i2o: Remove indentation of labels
2015-03-26 0:02 [PATCH] Staging: i2o: Remove indentation of labels Helen Fornazier
@ 2015-03-26 6:33 ` Julia Lawall
2015-03-26 12:09 ` Helen Fornazier
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2015-03-26 6:33 UTC (permalink / raw)
To: Helen Fornazier; +Cc: outreachy-kernel
i2o is on the way out of the kernel. So there is no point to mae patches
on it. You can find the list of the directories to avoid in the tutorial,
in the section Find a driver to clean up.
julia
On Wed, 25 Mar 2015, Helen Fornazier wrote:
> This patch fixes the checkpatche.pl warnings:
>
> WARNING: labels should not be indented
> + context_remove:
>
> WARNING: labels should not be indented
> + nop_msg:
>
> WARNING: labels should not be indented
> + exit:
>
> Signed-off-by: Helen Fornazier <helen.fornazier@gmail.com>
> ---
> drivers/staging/i2o/i2o_block.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/i2o/i2o_block.c b/drivers/staging/i2o/i2o_block.c
> index 7784787..406758f 100644
> --- a/drivers/staging/i2o/i2o_block.c
> +++ b/drivers/staging/i2o/i2o_block.c
> @@ -871,13 +871,13 @@ static int i2o_block_transfer(struct request *req)
>
> return 0;
>
> - context_remove:
> +context_remove:
> i2o_cntxt_list_remove(c, req);
>
> - nop_msg:
> +nop_msg:
> i2o_msg_nop(c, msg);
>
> - exit:
> +exit:
> return rc;
> };
>
> @@ -1002,13 +1002,13 @@ static struct i2o_block_device *i2o_block_device_alloc(void)
>
> return dev;
>
> - cleanup_queue:
> +cleanup_queue:
> put_disk(gd);
>
> - cleanup_dev:
> +cleanup_dev:
> kfree(dev);
>
> - exit:
> +exit:
> return ERR_PTR(rc);
> };
>
> @@ -1115,10 +1115,10 @@ static int i2o_block_probe(struct device *dev)
>
> return 0;
>
> - claim_release:
> +claim_release:
> i2o_device_claim_release(i2o_dev);
>
> - exit:
> +exit:
> return rc;
> };
>
> @@ -1187,16 +1187,16 @@ static int __init i2o_block_init(void)
>
> return 0;
>
> - unregister_blkdev:
> +unregister_blkdev:
> unregister_blkdev(I2O_MAJOR, "i2o_block");
>
> - free_mempool:
> +free_mempool:
> mempool_destroy(i2o_blk_req_pool.pool);
>
> - free_slab:
> +free_slab:
> kmem_cache_destroy(i2o_blk_req_pool.slab);
>
> - exit:
> +exit:
> return rc;
> };
>
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1427328162-6345-1-git-send-email-helen.fornazier%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: i2o: Remove indentation of labels
2015-03-26 6:33 ` [Outreachy kernel] " Julia Lawall
@ 2015-03-26 12:09 ` Helen Fornazier
0 siblings, 0 replies; 3+ messages in thread
From: Helen Fornazier @ 2015-03-26 12:09 UTC (permalink / raw)
To: Julia Lawall; +Cc: outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 3052 bytes --]
On Thu, Mar 26, 2015 at 3:33 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> i2o is on the way out of the kernel. So there is no point to mae patches
> on it. You can find the list of the directories to avoid in the tutorial,
> in the section Find a driver to clean up.
>
> julia
>
Sorry about that, I've read that list but I completely forgot about it.
>
> On Wed, 25 Mar 2015, Helen Fornazier wrote:
>
> > This patch fixes the checkpatche.pl warnings:
> >
> > WARNING: labels should not be indented
> > + context_remove:
> >
> > WARNING: labels should not be indented
> > + nop_msg:
> >
> > WARNING: labels should not be indented
> > + exit:
> >
> > Signed-off-by: Helen Fornazier <helen.fornazier@gmail.com>
> > ---
> > drivers/staging/i2o/i2o_block.c | 24 ++++++++++++------------
> > 1 file changed, 12 insertions(+), 12 deletions(-)
> >
> > diff --git a/drivers/staging/i2o/i2o_block.c
> b/drivers/staging/i2o/i2o_block.c
> > index 7784787..406758f 100644
> > --- a/drivers/staging/i2o/i2o_block.c
> > +++ b/drivers/staging/i2o/i2o_block.c
> > @@ -871,13 +871,13 @@ static int i2o_block_transfer(struct request *req)
> >
> > return 0;
> >
> > - context_remove:
> > +context_remove:
> > i2o_cntxt_list_remove(c, req);
> >
> > - nop_msg:
> > +nop_msg:
> > i2o_msg_nop(c, msg);
> >
> > - exit:
> > +exit:
> > return rc;
> > };
> >
> > @@ -1002,13 +1002,13 @@ static struct i2o_block_device
> *i2o_block_device_alloc(void)
> >
> > return dev;
> >
> > - cleanup_queue:
> > +cleanup_queue:
> > put_disk(gd);
> >
> > - cleanup_dev:
> > +cleanup_dev:
> > kfree(dev);
> >
> > - exit:
> > +exit:
> > return ERR_PTR(rc);
> > };
> >
> > @@ -1115,10 +1115,10 @@ static int i2o_block_probe(struct device *dev)
> >
> > return 0;
> >
> > - claim_release:
> > +claim_release:
> > i2o_device_claim_release(i2o_dev);
> >
> > - exit:
> > +exit:
> > return rc;
> > };
> >
> > @@ -1187,16 +1187,16 @@ static int __init i2o_block_init(void)
> >
> > return 0;
> >
> > - unregister_blkdev:
> > +unregister_blkdev:
> > unregister_blkdev(I2O_MAJOR, "i2o_block");
> >
> > - free_mempool:
> > +free_mempool:
> > mempool_destroy(i2o_blk_req_pool.pool);
> >
> > - free_slab:
> > +free_slab:
> > kmem_cache_destroy(i2o_blk_req_pool.slab);
> >
> > - exit:
> > +exit:
> > return rc;
> > };
> >
> > --
> > 1.9.1
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/1427328162-6345-1-git-send-email-helen.fornazier%40gmail.com
> .
> > For more options, visit https://groups.google.com/d/optout.
> >
>
--
Helen Fornazier
[-- Attachment #2: Type: text/html, Size: 4854 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-26 12:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-26 0:02 [PATCH] Staging: i2o: Remove indentation of labels Helen Fornazier
2015-03-26 6:33 ` [Outreachy kernel] " Julia Lawall
2015-03-26 12:09 ` Helen Fornazier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.