[PATCH] Staging: rts5208: Fix if-else brace indent

[PATCH] Staging: rts5208: Fix if-else brace indent

[Amitoj Kaur Chawla]

Fixed brace '{' position after if header. Problem found using checkpatch.pl
WARNING: suspect code indent for conditional statements (16, 16)

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
 drivers/staging/rts5208/ms.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c
index 4c38ff9..a8515d0 100644
--- a/drivers/staging/rts5208/ms.c
+++ b/drivers/staging/rts5208/ms.c
@@ -914,9 +914,8 @@ static int ms_read_attribute_info(struct rtsx_chip *chip)
 		if ((buf[cur_addr_off + 8] == 0x10) ||
 			(buf[cur_addr_off + 8] == 0x13))
 #else
-		if (buf[cur_addr_off + 8] == 0x10)
+		if (buf[cur_addr_off + 8] == 0x10) {
 #endif
-		{
 			sys_info_addr = ((u32)buf[cur_addr_off + 0] << 24) |
 				((u32)buf[cur_addr_off + 1] << 16) |
 				((u32)buf[cur_addr_off + 2] << 8) |
-- 
1.9.1

Re: [Outreachy kernel] [PATCH] Staging: rts5208: Fix if-else brace indent

[Julia Lawall]

On Mon, 30 Mar 2015, Amitoj Kaur Chawla wrote:

> Fixed brace '{' position after if header. Problem found using checkpatch.pl
> WARNING: suspect code indent for conditional statements (16, 16)
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
>  drivers/staging/rts5208/ms.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c
> index 4c38ff9..a8515d0 100644
> --- a/drivers/staging/rts5208/ms.c
> +++ b/drivers/staging/rts5208/ms.c
> @@ -914,9 +914,8 @@ static int ms_read_attribute_info(struct rtsx_chip *chip)
>  		if ((buf[cur_addr_off + 8] == 0x10) ||
>  			(buf[cur_addr_off + 8] == 0x13))
>  #else
> -		if (buf[cur_addr_off + 8] == 0x10)
> +		if (buf[cur_addr_off + 8] == 0x10) {
>  #endif
> -		{

Are you sure this is correct?  The { has moved from outside an ifdef into 
an ifdef branch.

julia

>  			sys_info_addr = ((u32)buf[cur_addr_off + 0] << 24) |
>  				((u32)buf[cur_addr_off + 1] << 16) |
>  				((u32)buf[cur_addr_off + 2] << 8) |
> -- 
> 1.9.1
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20150330173952.GA32369%40amitoj-Inspiron-3542.
> For more options, visit https://groups.google.com/d/optout.
>