From: Julia Lawall <julia.lawall@lip6.fr> To: SF Markus Elfring <elfring@users.sourceforge.net> Cc: LKML <linux-kernel@vger.kernel.org>, Richard Cochran <richardcochran@gmail.com>, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] posix-clock: Use an unsigned data type for a variable Date: Sun, 20 Dec 2015 12:09:52 +0100 (CET) [thread overview] Message-ID: <alpine.DEB.2.02.1512201208250.2067@localhost6.localdomain6> (raw) In-Reply-To: <56766488.9050402@users.sourceforge.net> On Sun, 20 Dec 2015, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sun, 20 Dec 2015 09:09:34 +0100 > > The data type "int" was used by the variable "result" in the > function "posix_clock_poll" even though the type "uint" will usually > be needed for the return value from a call of the function which was > assigned to the pointer "poll" of the variable "clk". > Reuse the type from this poll call instead. Why use uint when the function return type it unsigned int? On the other hand, why is the function return type unsigned int when there is a return of a negative constant? julia > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > kernel/time/posix-clock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/time/posix-clock.c b/kernel/time/posix-clock.c > index ce033c7..ac0b733 100644 > --- a/kernel/time/posix-clock.c > +++ b/kernel/time/posix-clock.c > @@ -69,7 +69,7 @@ static ssize_t posix_clock_read(struct file *fp, char __user *buf, > static unsigned int posix_clock_poll(struct file *fp, poll_table *wait) > { > struct posix_clock *clk = get_posix_clock(fp); > - int result = 0; > + uint result = 0; > > if (!clk) > return -ENODEV; > -- > 2.6.3 > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia.lawall@lip6.fr> To: SF Markus Elfring <elfring@users.sourceforge.net> Cc: LKML <linux-kernel@vger.kernel.org>, Richard Cochran <richardcochran@gmail.com>, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] posix-clock: Use an unsigned data type for a variable Date: Sun, 20 Dec 2015 11:09:52 +0000 [thread overview] Message-ID: <alpine.DEB.2.02.1512201208250.2067@localhost6.localdomain6> (raw) In-Reply-To: <56766488.9050402@users.sourceforge.net> On Sun, 20 Dec 2015, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sun, 20 Dec 2015 09:09:34 +0100 > > The data type "int" was used by the variable "result" in the > function "posix_clock_poll" even though the type "uint" will usually > be needed for the return value from a call of the function which was > assigned to the pointer "poll" of the variable "clk". > Reuse the type from this poll call instead. Why use uint when the function return type it unsigned int? On the other hand, why is the function return type unsigned int when there is a return of a negative constant? julia > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > kernel/time/posix-clock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/time/posix-clock.c b/kernel/time/posix-clock.c > index ce033c7..ac0b733 100644 > --- a/kernel/time/posix-clock.c > +++ b/kernel/time/posix-clock.c > @@ -69,7 +69,7 @@ static ssize_t posix_clock_read(struct file *fp, char __user *buf, > static unsigned int posix_clock_poll(struct file *fp, poll_table *wait) > { > struct posix_clock *clk = get_posix_clock(fp); > - int result = 0; > + uint result = 0; > > if (!clk) > return -ENODEV; > -- > 2.6.3 > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
next prev parent reply other threads:[~2015-12-20 11:09 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-12-20 8:19 [PATCH] posix-clock: Use an unsigned data type for a variable SF Markus Elfring 2015-12-20 8:19 ` SF Markus Elfring 2015-12-20 11:09 ` Julia Lawall [this message] 2015-12-20 11:09 ` Julia Lawall 2015-12-20 12:48 ` SF Markus Elfring 2015-12-20 12:48 ` SF Markus Elfring 2015-12-20 12:51 ` Julia Lawall 2015-12-20 12:51 ` Julia Lawall 2015-12-20 13:08 ` SF Markus Elfring 2015-12-20 13:08 ` SF Markus Elfring 2015-12-20 20:09 ` Richard Cochran 2015-12-20 20:09 ` Richard Cochran 2015-12-21 9:30 ` SF Markus Elfring 2015-12-21 9:30 ` SF Markus Elfring 2015-12-21 10:12 ` Richard Cochran 2015-12-21 10:12 ` Richard Cochran 2015-12-22 21:19 ` [PATCH] posix-clock: fix return code on the poll method's error path Richard Cochran 2015-12-22 21:19 ` Richard Cochran 2015-12-29 10:36 ` [tip:timers/urgent] posix-clock: Fix " tip-bot for Richard Cochran
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=alpine.DEB.2.02.1512201208250.2067@localhost6.localdomain6 \ --to=julia.lawall@lip6.fr \ --cc=elfring@users.sourceforge.net \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=richardcochran@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.