[PATCH] Staging: rtl8723au: Remove unnecessary variable

[PATCH] Staging: rtl8723au: Remove unnecessary variable

[Bhumika Goyal]

Variable ret is initially made 0 and it's value remains unchanged in
function. It is used only as return value.So remove ret and replace
return ret with return 0.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c
index 0ae2180..b10fdce 100644
--- a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c
+++ b/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c
@@ -242,7 +242,6 @@ rtw_cfg80211_default_mgmt_stypes[NUM_NL80211_IFTYPES] = {
 static int rtw_cfg80211_inform_bss(struct rtw_adapter *padapter,
 				   struct wlan_network *pnetwork)
 {
-	int ret = 0;
 	struct ieee80211_channel *notify_channel;
 	struct cfg80211_bss *bss;
 	u16 channel;
@@ -295,7 +294,7 @@ static int rtw_cfg80211_inform_bss(struct rtw_adapter *padapter,
 
 	cfg80211_put_bss(wiphy, bss);
 
-	return ret;
+	return 0;
 }
 
 void rtw_cfg80211_indicate_connect(struct rtw_adapter *padapter)
@@ -1300,7 +1299,6 @@ void rtw_cfg80211_surveydone_event_callback(struct rtw_adapter *padapter)
 static int rtw_cfg80211_set_probe_req_wpsp2pie(struct rtw_adapter *padapter,
 					       char *buf, int len)
 {
-	int ret = 0;
 	const u8 *wps_ie;
 	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
 
@@ -1330,7 +1328,7 @@ static int rtw_cfg80211_set_probe_req_wpsp2pie(struct rtw_adapter *padapter,
 		}
 	}
 
-	return ret;
+	return 0;
 }
 
 static int cfg80211_rtw_scan(struct wiphy *wiphy,
-- 
1.9.1

Re: [Outreachy kernel] [PATCH] Staging: rtl8723au: Remove unnecessary variable

[Julia Lawall]

On Wed, 10 Feb 2016, Bhumika Goyal wrote:

> Variable ret is initially made 0 and it's value remains unchanged in
> function. It is used only as return value.So remove ret and replace
> return ret with return 0.

"it's" -> "its".  And please always put a space after a period, when there 
is another following sentence.

Otherwise, the change looks fine.

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
>  drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c
> index 0ae2180..b10fdce 100644
> --- a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c
> +++ b/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c
> @@ -242,7 +242,6 @@ rtw_cfg80211_default_mgmt_stypes[NUM_NL80211_IFTYPES] = {
>  static int rtw_cfg80211_inform_bss(struct rtw_adapter *padapter,
>  				   struct wlan_network *pnetwork)
>  {
> -	int ret = 0;
>  	struct ieee80211_channel *notify_channel;
>  	struct cfg80211_bss *bss;
>  	u16 channel;
> @@ -295,7 +294,7 @@ static int rtw_cfg80211_inform_bss(struct rtw_adapter *padapter,
>  
>  	cfg80211_put_bss(wiphy, bss);
>  
> -	return ret;
> +	return 0;
>  }
>  
>  void rtw_cfg80211_indicate_connect(struct rtw_adapter *padapter)
> @@ -1300,7 +1299,6 @@ void rtw_cfg80211_surveydone_event_callback(struct rtw_adapter *padapter)
>  static int rtw_cfg80211_set_probe_req_wpsp2pie(struct rtw_adapter *padapter,
>  					       char *buf, int len)
>  {
> -	int ret = 0;
>  	const u8 *wps_ie;
>  	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
>  
> @@ -1330,7 +1328,7 @@ static int rtw_cfg80211_set_probe_req_wpsp2pie(struct rtw_adapter *padapter,
>  		}
>  	}
>  
> -	return ret;
> +	return 0;
>  }
>  
>  static int cfg80211_rtw_scan(struct wiphy *wiphy,
> -- 
> 1.9.1
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1455044948-1425-1-git-send-email-bhumirks%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
> 

Re: [Outreachy kernel] [PATCH] Staging: rtl8723au: Remove unnecessary variable

[Bhumika Goyal]

[-- Attachment #1.1: Type: text/plain, Size: 79 bytes --]

I am so sorry for such silly errors. Should I send v2 ?

Thanks,
Bhumika Goyal

[-- Attachment #1.2: Type: text/html, Size: 112 bytes --]

Re: [Outreachy kernel] [PATCH] Staging: rtl8723au: Remove unnecessary variable

[Julia Lawall]

On Wed, 10 Feb 2016, Bhumika Goyal wrote:

> I am so sorry for such silly errors. Should I send v2 ?

I don have the patch that this refers to any more, but if you think that
v2 might be useful, it probably is :)

julia

>
> Thanks,
> Bhumika Goyal
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/b4c83b1e-33bf-441e-b85b-
> 445d768f8870%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>