All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/3] ARM: socfpga: dtsi: add qspi node
@ 2016-10-18  7:43 Steffen Trumtrar
  2016-10-18  7:43 ` [PATCH 2/3] ARM: socfpga: socrates: enable qspi Steffen Trumtrar
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Steffen Trumtrar @ 2016-10-18  7:43 UTC (permalink / raw)
  To: linux-arm-kernel

Add the qspi node to the socfpga dtsi file.

Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
 arch/arm/boot/dts/socfpga.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
index 9f48141270b8..0dc96d2248a6 100644
--- a/arch/arm/boot/dts/socfpga.dtsi
+++ b/arch/arm/boot/dts/socfpga.dtsi
@@ -705,6 +705,20 @@
 			reg = <0xffff0000 0x10000>;
 		};
 
+		qspi: spi at ff705000 {
+			compatible = "cdns,qspi-nor";
+                        #address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0xff705000 0x1000>,
+			      <0xffa00000 0x1000>;
+			interrupts = <0 151 4>;
+			cdns,fifo-depth = <128>;
+			cdns,fifo-width = <4>;
+			cdns,trigger-address = <0x00000000>;
+			clocks = <&qspi_clk>;
+			status = "disabled";
+		};
+
 		rst: rstmgr at ffd05000 {
 			#reset-cells = <1>;
 			compatible = "altr,rst-mgr";
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH 2/3] ARM: socfpga: socrates: enable qspi
  2016-10-18  7:43 [PATCH 1/3] ARM: socfpga: dtsi: add qspi node Steffen Trumtrar
@ 2016-10-18  7:43 ` Steffen Trumtrar
  2016-10-18  7:43 ` [PATCH 3/3] ARM: socfpga: defconfig: " Steffen Trumtrar
  2016-10-19 15:55 ` [PATCH 1/3] ARM: socfpga: dtsi: add qspi node Dinh Nguyen
  2 siblings, 0 replies; 7+ messages in thread
From: Steffen Trumtrar @ 2016-10-18  7:43 UTC (permalink / raw)
  To: linux-arm-kernel

Enable the qspi controller on the socrates and add the flash chip.

Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
 arch/arm/boot/dts/socfpga_cyclone5_socrates.dts | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/arch/arm/boot/dts/socfpga_cyclone5_socrates.dts b/arch/arm/boot/dts/socfpga_cyclone5_socrates.dts
index d79853775061..c3d52f27b21e 100644
--- a/arch/arm/boot/dts/socfpga_cyclone5_socrates.dts
+++ b/arch/arm/boot/dts/socfpga_cyclone5_socrates.dts
@@ -80,3 +80,22 @@
 &mmc {
 	status = "okay";
 };
+
+&qspi {
+	status = "okay";
+
+	flash: flash at 0 {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		compatible = "n25q256a";
+		reg = <0>;
+		spi-max-frequency = <100000000>;
+		m25p,fast-read;
+		cdns,read-delay = <4>;
+		cdns,tshsl-ns = <50>;
+		cdns,tsd2d-ns = <50>;
+		cdns,tchsh-ns = <4>;
+		cdns,tslch-ns = <4>;
+		status = "okay";
+	};
+};
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH 3/3] ARM: socfpga: defconfig: enable qspi
  2016-10-18  7:43 [PATCH 1/3] ARM: socfpga: dtsi: add qspi node Steffen Trumtrar
  2016-10-18  7:43 ` [PATCH 2/3] ARM: socfpga: socrates: enable qspi Steffen Trumtrar
@ 2016-10-18  7:43 ` Steffen Trumtrar
  2016-10-18 21:03   ` Dinh Nguyen
  2016-10-19 15:55 ` [PATCH 1/3] ARM: socfpga: dtsi: add qspi node Dinh Nguyen
  2 siblings, 1 reply; 7+ messages in thread
From: Steffen Trumtrar @ 2016-10-18  7:43 UTC (permalink / raw)
  To: linux-arm-kernel

Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
 arch/arm/configs/socfpga_defconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/configs/socfpga_defconfig b/arch/arm/configs/socfpga_defconfig
index 9f84be5b3ac5..466050663c86 100644
--- a/arch/arm/configs/socfpga_defconfig
+++ b/arch/arm/configs/socfpga_defconfig
@@ -50,6 +50,9 @@ CONFIG_CAN_DEBUG_DEVICES=y
 CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
 CONFIG_DEVTMPFS=y
 CONFIG_DEVTMPFS_MOUNT=y
+CONFIG_MTD=y
+CONFIG_MTD_SPI_NOR=y
+CONFIG_SPI_CADENCE_QUADSPI=y
 CONFIG_BLK_DEV_RAM=y
 CONFIG_BLK_DEV_RAM_COUNT=2
 CONFIG_BLK_DEV_RAM_SIZE=8192
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH 3/3] ARM: socfpga: defconfig: enable qspi
  2016-10-18  7:43 ` [PATCH 3/3] ARM: socfpga: defconfig: " Steffen Trumtrar
@ 2016-10-18 21:03   ` Dinh Nguyen
  2016-10-19  5:26     ` Steffen Trumtrar
  0 siblings, 1 reply; 7+ messages in thread
From: Dinh Nguyen @ 2016-10-18 21:03 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, 18 Oct 2016, Steffen Trumtrar wrote:

> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
>  arch/arm/configs/socfpga_defconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/configs/socfpga_defconfig b/arch/arm/configs/socfpga_defconfig
> index 9f84be5b3ac5..466050663c86 100644
> --- a/arch/arm/configs/socfpga_defconfig
> +++ b/arch/arm/configs/socfpga_defconfig

Thanks Steffen, all patches applied. I'll fixup the commit header for the DTS
patches. The arm-soc maintainers prefer the DTS patches to be:

"ARM: dts: <platform>"

BR,
Dinh

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH 3/3] ARM: socfpga: defconfig: enable qspi
  2016-10-18 21:03   ` Dinh Nguyen
@ 2016-10-19  5:26     ` Steffen Trumtrar
  0 siblings, 0 replies; 7+ messages in thread
From: Steffen Trumtrar @ 2016-10-19  5:26 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Oct 18, 2016 at 04:03:01PM -0500, Dinh Nguyen wrote:
> On Tue, 18 Oct 2016, Steffen Trumtrar wrote:
> 
> > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> > ---
> >  arch/arm/configs/socfpga_defconfig | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/arch/arm/configs/socfpga_defconfig b/arch/arm/configs/socfpga_defconfig
> > index 9f84be5b3ac5..466050663c86 100644
> > --- a/arch/arm/configs/socfpga_defconfig
> > +++ b/arch/arm/configs/socfpga_defconfig
> 
> Thanks Steffen, all patches applied. I'll fixup the commit header for the DTS
> patches. The arm-soc maintainers prefer the DTS patches to be:
> 
> "ARM: dts: <platform>"

Oops.

Thanks,
Steffen


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH 1/3] ARM: socfpga: dtsi: add qspi node
  2016-10-18  7:43 [PATCH 1/3] ARM: socfpga: dtsi: add qspi node Steffen Trumtrar
  2016-10-18  7:43 ` [PATCH 2/3] ARM: socfpga: socrates: enable qspi Steffen Trumtrar
  2016-10-18  7:43 ` [PATCH 3/3] ARM: socfpga: defconfig: " Steffen Trumtrar
@ 2016-10-19 15:55 ` Dinh Nguyen
  2016-10-20  6:42   ` Steffen Trumtrar
  2 siblings, 1 reply; 7+ messages in thread
From: Dinh Nguyen @ 2016-10-19 15:55 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, 18 Oct 2016, Steffen Trumtrar wrote:

> Add the qspi node to the socfpga dtsi file.
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
>  arch/arm/boot/dts/socfpga.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> index 9f48141270b8..0dc96d2248a6 100644
> --- a/arch/arm/boot/dts/socfpga.dtsi
> +++ b/arch/arm/boot/dts/socfpga.dtsi
> @@ -705,6 +705,20 @@
>  			reg = <0xffff0000 0x10000>;
>  		};
>  
> +		qspi: spi at ff705000 {
> +			compatible = "cdns,qspi-nor";
> +                        #address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <0xff705000 0x1000>,
> +			      <0xffa00000 0x1000>;

I think the QSPI data address space has a length of 0x100000. I've fixed it up locally.

BR,
Dinh

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH 1/3] ARM: socfpga: dtsi: add qspi node
  2016-10-19 15:55 ` [PATCH 1/3] ARM: socfpga: dtsi: add qspi node Dinh Nguyen
@ 2016-10-20  6:42   ` Steffen Trumtrar
  0 siblings, 0 replies; 7+ messages in thread
From: Steffen Trumtrar @ 2016-10-20  6:42 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Oct 19, 2016 at 10:55:46AM -0500, Dinh Nguyen wrote:
> On Tue, 18 Oct 2016, Steffen Trumtrar wrote:
> 
> > Add the qspi node to the socfpga dtsi file.
> > 
> > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> > ---
> >  arch/arm/boot/dts/socfpga.dtsi | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> > index 9f48141270b8..0dc96d2248a6 100644
> > --- a/arch/arm/boot/dts/socfpga.dtsi
> > +++ b/arch/arm/boot/dts/socfpga.dtsi
> > @@ -705,6 +705,20 @@
> >  			reg = <0xffff0000 0x10000>;
> >  		};
> >  
> > +		qspi: spi at ff705000 {
> > +			compatible = "cdns,qspi-nor";
> > +                        #address-cells = <1>;
> > +			#size-cells = <0>;
> > +			reg = <0xff705000 0x1000>,
> > +			      <0xffa00000 0x1000>;
> 
> I think the QSPI data address space has a length of 0x100000. I've fixed it up locally.
> 

Yeah, you are right. Good catch.

Thanks,
Steffen

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-10-20  6:42 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-18  7:43 [PATCH 1/3] ARM: socfpga: dtsi: add qspi node Steffen Trumtrar
2016-10-18  7:43 ` [PATCH 2/3] ARM: socfpga: socrates: enable qspi Steffen Trumtrar
2016-10-18  7:43 ` [PATCH 3/3] ARM: socfpga: defconfig: " Steffen Trumtrar
2016-10-18 21:03   ` Dinh Nguyen
2016-10-19  5:26     ` Steffen Trumtrar
2016-10-19 15:55 ` [PATCH 1/3] ARM: socfpga: dtsi: add qspi node Dinh Nguyen
2016-10-20  6:42   ` Steffen Trumtrar

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.