All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mm: export "high_memory" symbol on !MMU
@ 2015-01-28 14:43 ` Arnd Bergmann
  0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2015-01-28 14:43 UTC (permalink / raw)
  To: Andrew Morton; +Cc: kirill.shutemov, linux-mm, gerg, linux-arm-kernel



^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] mm: export "high_memory" symbol on !MMU
@ 2015-01-28 14:43 ` Arnd Bergmann
  0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2015-01-28 14:43 UTC (permalink / raw)
  To: linux-arm-kernel

>From f391eb37fafc8a22d7fd9574b8d220f0d90a91d0 Mon Sep 17 00:00:00 2001
From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 25 Aug 2014 16:24:41 +0200
Subject: [PATCH] mm: export "high_memory" symbol on !MMU

The symbol 'high_memory' is provided on both MMU- and NOMMU-kernels,
but only one of them is exported, which leads to module build errors
in drivers that work fine built-in:

ERROR: "high_memory" [drivers/net/virtio_net.ko] undefined!
ERROR: "high_memory" [drivers/net/ppp/ppp_mppe.ko] undefined!
ERROR: "high_memory" [drivers/mtd/nand/nand.ko] undefined!
ERROR: "high_memory" [crypto/tcrypt.ko] undefined!
ERROR: "high_memory" [crypto/cts.ko] undefined!

This exports the symbol to get these to work on NOMMU as well.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

diff --git a/mm/nommu.c b/mm/nommu.c
index e9228cbe46de..7bdeb281ad0e 100644
--- a/mm/nommu.c
+++ b/mm/nommu.c
@@ -59,6 +59,7 @@
 #endif
 
 void *high_memory;
+EXPORT_SYMBOL(high_memory);
 struct page *mem_map;
 unsigned long max_mapnr;
 unsigned long highest_memmap_pfn;

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] mm: export "high_memory" symbol on !MMU
  2015-01-28 14:43 ` Arnd Bergmann
@ 2015-01-29  1:15   ` Greg Ungerer
  -1 siblings, 0 replies; 6+ messages in thread
From: Greg Ungerer @ 2015-01-29  1:15 UTC (permalink / raw)
  To: Arnd Bergmann, Andrew Morton; +Cc: kirill.shutemov, linux-mm, linux-arm-kernel

On 29/01/15 00:43, Arnd Bergmann wrote:
>>From f391eb37fafc8a22d7fd9574b8d220f0d90a91d0 Mon Sep 17 00:00:00 2001
> From: Arnd Bergmann <arnd@arndb.de>
> Date: Mon, 25 Aug 2014 16:24:41 +0200
> Subject: [PATCH] mm: export "high_memory" symbol on !MMU
> 
> The symbol 'high_memory' is provided on both MMU- and NOMMU-kernels,
> but only one of them is exported, which leads to module build errors
> in drivers that work fine built-in:
> 
> ERROR: "high_memory" [drivers/net/virtio_net.ko] undefined!
> ERROR: "high_memory" [drivers/net/ppp/ppp_mppe.ko] undefined!
> ERROR: "high_memory" [drivers/mtd/nand/nand.ko] undefined!
> ERROR: "high_memory" [crypto/tcrypt.ko] undefined!
> ERROR: "high_memory" [crypto/cts.ko] undefined!
> 
> This exports the symbol to get these to work on NOMMU as well.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Here is an ack if you want one:

Acked-by: Greg Ungerer <gerg@uclinux.org>

Regards
Greg


> diff --git a/mm/nommu.c b/mm/nommu.c
> index e9228cbe46de..7bdeb281ad0e 100644
> --- a/mm/nommu.c
> +++ b/mm/nommu.c
> @@ -59,6 +59,7 @@
>  #endif
>  
>  void *high_memory;
> +EXPORT_SYMBOL(high_memory);
>  struct page *mem_map;
>  unsigned long max_mapnr;
>  unsigned long highest_memmap_pfn;
> 
> 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] mm: export "high_memory" symbol on !MMU
@ 2015-01-29  1:15   ` Greg Ungerer
  0 siblings, 0 replies; 6+ messages in thread
From: Greg Ungerer @ 2015-01-29  1:15 UTC (permalink / raw)
  To: linux-arm-kernel

On 29/01/15 00:43, Arnd Bergmann wrote:
>>From f391eb37fafc8a22d7fd9574b8d220f0d90a91d0 Mon Sep 17 00:00:00 2001
> From: Arnd Bergmann <arnd@arndb.de>
> Date: Mon, 25 Aug 2014 16:24:41 +0200
> Subject: [PATCH] mm: export "high_memory" symbol on !MMU
> 
> The symbol 'high_memory' is provided on both MMU- and NOMMU-kernels,
> but only one of them is exported, which leads to module build errors
> in drivers that work fine built-in:
> 
> ERROR: "high_memory" [drivers/net/virtio_net.ko] undefined!
> ERROR: "high_memory" [drivers/net/ppp/ppp_mppe.ko] undefined!
> ERROR: "high_memory" [drivers/mtd/nand/nand.ko] undefined!
> ERROR: "high_memory" [crypto/tcrypt.ko] undefined!
> ERROR: "high_memory" [crypto/cts.ko] undefined!
> 
> This exports the symbol to get these to work on NOMMU as well.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Here is an ack if you want one:

Acked-by: Greg Ungerer <gerg@uclinux.org>

Regards
Greg


> diff --git a/mm/nommu.c b/mm/nommu.c
> index e9228cbe46de..7bdeb281ad0e 100644
> --- a/mm/nommu.c
> +++ b/mm/nommu.c
> @@ -59,6 +59,7 @@
>  #endif
>  
>  void *high_memory;
> +EXPORT_SYMBOL(high_memory);
>  struct page *mem_map;
>  unsigned long max_mapnr;
>  unsigned long highest_memmap_pfn;
> 
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] mm: export "high_memory" symbol on !MMU
  2015-01-28 14:43 ` Arnd Bergmann
@ 2015-02-02 17:51   ` David Rientjes
  -1 siblings, 0 replies; 6+ messages in thread
From: David Rientjes @ 2015-02-02 17:51 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Andrew Morton, kirill.shutemov, linux-mm, gerg, linux-arm-kernel

On Wed, 28 Jan 2015, Arnd Bergmann wrote:

> The symbol 'high_memory' is provided on both MMU- and NOMMU-kernels,
> but only one of them is exported, which leads to module build errors
> in drivers that work fine built-in:
> 
> ERROR: "high_memory" [drivers/net/virtio_net.ko] undefined!
> ERROR: "high_memory" [drivers/net/ppp/ppp_mppe.ko] undefined!
> ERROR: "high_memory" [drivers/mtd/nand/nand.ko] undefined!
> ERROR: "high_memory" [crypto/tcrypt.ko] undefined!
> ERROR: "high_memory" [crypto/cts.ko] undefined!
> 
> This exports the symbol to get these to work on NOMMU as well.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: David Rientjes <rientjes@google.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] mm: export "high_memory" symbol on !MMU
@ 2015-02-02 17:51   ` David Rientjes
  0 siblings, 0 replies; 6+ messages in thread
From: David Rientjes @ 2015-02-02 17:51 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, 28 Jan 2015, Arnd Bergmann wrote:

> The symbol 'high_memory' is provided on both MMU- and NOMMU-kernels,
> but only one of them is exported, which leads to module build errors
> in drivers that work fine built-in:
> 
> ERROR: "high_memory" [drivers/net/virtio_net.ko] undefined!
> ERROR: "high_memory" [drivers/net/ppp/ppp_mppe.ko] undefined!
> ERROR: "high_memory" [drivers/mtd/nand/nand.ko] undefined!
> ERROR: "high_memory" [crypto/tcrypt.ko] undefined!
> ERROR: "high_memory" [crypto/cts.ko] undefined!
> 
> This exports the symbol to get these to work on NOMMU as well.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: David Rientjes <rientjes@google.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2015-02-02 17:51 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-28 14:43 [PATCH] mm: export "high_memory" symbol on !MMU Arnd Bergmann
2015-01-28 14:43 ` Arnd Bergmann
2015-01-29  1:15 ` Greg Ungerer
2015-01-29  1:15   ` Greg Ungerer
2015-02-02 17:51 ` David Rientjes
2015-02-02 17:51   ` David Rientjes

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.