Re: [PATCH 1/7] x86/intel_rdt: Intel Cache Allocation Technology detection

[Vikas Shivappa <vikas.shivappa@intel.com>]

On Wed, 25 Feb 2015, Borislav Petkov wrote:

> On Tue, Feb 24, 2015 at 04:42:10PM -0800, Vikas Shivappa wrote:
>>>> +
>>>> +	pr_info("cbmlength:%u,Closs: %u\n", cbm_len, maxid);
>>>
>>> This text message needs to be much more user-friendly if it is going out
>>> to the console unconditionally.
>>>
>>
>> bit mask lengh:  number of CLOSids: ? . it should print with the module name
>> as well which should help understand what it is for.
>
> Right, if I haven't read the SDM on RDT, I still don't understand what
> those mean. What is the need for that message at all, what is it telling
> me?
>
> Can you show an example from a machine with RDT and explain what it is
> good for?


This would be an indication that the System support RDT. On a system with RDT 
would see a print.

intel_rdt: cbmlength: xx , CLOss:xx

This is documented in the RDT documentation that is added in the patch and the 
code also mentiones the Intel SDM section which details the feature. The RDT 
is expected to be used by advanced users atlest the ones who would use the 
cgroup RDT interface , knows about the class of service , bit mask etc.. The use 
cases are also documented in the RDT document  in cgroups/rdt.txt (the last 
patch in this series)

>
>>>> +config CGROUP_RDT
>>>> +	bool "Resource Director Technology cgroup subsystem"
>>>> +	depends on X86_64
>>>
>>> depends on X86_64 && CPU_SUP_INTEL
>>>
>>> Also, this should probably also depend on CGROUP-something or so
>>> AFAICT...
>>
>> This is with in the if CGROUPS
>
> Right, but you still need the CPU_SUP_INTEL dependency as !Intel x86
> doesn't need that code built.

Will add this dependency..

>
> Thanks.
>
> -- 
> Regards/Gruss,
>    Boris.
>
> ECO tip #101: Trim your mails when you reply.
> --
>