[PATCH] Staging: lustre: Add blank line after declarations

[PATCH] Staging: lustre: Add blank line after declarations

[Dilek Uzulmez]

The following patch fixes the checkpatch.pl warning:
drivers/staging/lustre/lustre/ptlrpc/import.c WARNING: Missing a blank
line after declarations

Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
---
 drivers/staging/lustre/lustre/ptlrpc/import.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/staging/lustre/lustre/ptlrpc/import.c b/drivers/staging/lustre/lustre/ptlrpc/import.c
index 4ceb90d..165aa82 100644
--- a/drivers/staging/lustre/lustre/ptlrpc/import.c
+++ b/drivers/staging/lustre/lustre/ptlrpc/import.c
@@ -448,6 +448,7 @@ int ptlrpc_reconnect_import(struct obd_import *imp)
 	if (atomic_read(&imp->imp_inval_count) > 0) {
 		int rc;
 		struct l_wait_info lwi = LWI_INTR(LWI_ON_SIGNAL_NOOP, NULL);
+
 		rc = l_wait_event(imp->imp_recovery_waitq,
 				  (atomic_read(&imp->imp_inval_count) == 0),
 				  &lwi);
@@ -529,6 +530,7 @@ static int import_select_connection(struct obd_import *imp)
 	   trying to reconnect on it.) */
 	if (tried_all && (imp->imp_conn_list.next == &imp_conn->oic_item)) {
 		struct adaptive_timeout *at = &imp->imp_at.iat_net_latency;
+
 		if (at_get(at) < CONNECTION_SWITCH_MAX) {
 			at_measured(at, at_get(at) + CONNECTION_SWITCH_INC);
 			if (at_get(at) > CONNECTION_SWITCH_MAX)
-- 
1.9.1

Re: [Outreachy kernel] [PATCH] Staging: lustre: Add blank line after declarations

[Julia Lawall]

Dilek, you could put them all in one patch.

julia

On Sat, 28 Feb 2015, Dilek Uzulmez wrote:

> The following patch fixes the checkpatch.pl warning:
> drivers/staging/lustre/lustre/ptlrpc/import.c WARNING: Missing a blank
> line after declarations
>
> Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
> ---
>  drivers/staging/lustre/lustre/ptlrpc/import.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/lustre/lustre/ptlrpc/import.c b/drivers/staging/lustre/lustre/ptlrpc/import.c
> index 4ceb90d..165aa82 100644
> --- a/drivers/staging/lustre/lustre/ptlrpc/import.c
> +++ b/drivers/staging/lustre/lustre/ptlrpc/import.c
> @@ -448,6 +448,7 @@ int ptlrpc_reconnect_import(struct obd_import *imp)
>  	if (atomic_read(&imp->imp_inval_count) > 0) {
>  		int rc;
>  		struct l_wait_info lwi = LWI_INTR(LWI_ON_SIGNAL_NOOP, NULL);
> +
>  		rc = l_wait_event(imp->imp_recovery_waitq,
>  				  (atomic_read(&imp->imp_inval_count) == 0),
>  				  &lwi);
> @@ -529,6 +530,7 @@ static int import_select_connection(struct obd_import *imp)
>  	   trying to reconnect on it.) */
>  	if (tried_all && (imp->imp_conn_list.next == &imp_conn->oic_item)) {
>  		struct adaptive_timeout *at = &imp->imp_at.iat_net_latency;
> +
>  		if (at_get(at) < CONNECTION_SWITCH_MAX) {
>  			at_measured(at, at_get(at) + CONNECTION_SWITCH_INC);
>  			if (at_get(at) > CONNECTION_SWITCH_MAX)
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1425079467-3349-1-git-send-email-dilekuzulmez%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH] Staging: lustre: Add blank line after declarations

[Daniel Baluta]

On Fri, Feb 27, 2015 at 9:23 PM, Melike Yurtoglu
<aysemelikeyurtoglu@gmail.com> wrote:
> WARNING: "Missing a blank line after declarations"
> Add blank line after declarations. That was found by running checkpatch
>
> Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>

Reviewed-by: Daniel Baluta <daniel.baluta@intel.com>

Re: [Outreachy kernel] [PATCH] Staging: lustre: Add blank line after declarations

[Greg KH]

On Sat, Feb 28, 2015 at 02:12:24AM +0200, Dilek Uzulmez wrote:
> The following patch fixes the checkpatch.pl warning:
> drivers/staging/lustre/lustre/ptlrpc/service.c WARNING: Missing a
> blank line after declarations
> 
> Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
> ---
>  drivers/staging/lustre/lustre/ptlrpc/service.c | 3 +++
>  1 file changed, 3 insertions(+)

You sent 7 patches all with the same subject, yet they do different
things.  Can you please fix this and resend makeing the subjects unique?

thanks,

greg k-h

Re: [Outreachy kernel] [PATCH] Staging: lustre: Add blank line after declarations

[Julia Lawall]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 3081 bytes --]



On Fri, 27 Feb 2015, Hatice ERTÜRK wrote:

> The following patch fixes the checkpatch.pl warning:
> drivers/staging/lustre/lustre/osc/lproc_osc.c WARNING: Missing a blank
> line after declarations
>
> Signed-off-by: Hatice ERTÜRK <haticeerturk27@gmail.com>
> ---
>  drivers/staging/lustre/lustre/osc/lproc_osc.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/staging/lustre/lustre/osc/lproc_osc.c b/drivers/staging/lustre/lustre/osc/lproc_osc.c
> index 9f719bc..9c151dd 100644
> --- a/drivers/staging/lustre/lustre/osc/lproc_osc.c
> +++ b/drivers/staging/lustre/lustre/osc/lproc_osc.c
> @@ -345,6 +345,7 @@ static int osc_checksum_type_seq_show(struct seq_file *m, void *v)
>  {
>  	struct obd_device *obd = m->private;
>  	int i;
> +
>  	DECLARE_CKSUM_NAME;

The above line is probably a declaration too, so the blank line would not
be appropriate.

julia

>
>  	if (obd == NULL)
> @@ -367,6 +368,7 @@ static ssize_t osc_checksum_type_seq_write(struct file *file, const char *buffer
>  {
>  	struct obd_device *obd = ((struct seq_file *)file->private_data)->private;
>  	int i;
> +
>  	DECLARE_CKSUM_NAME;
>  	char kernbuf[10];
>
> @@ -461,6 +463,7 @@ LPROC_SEQ_FOPS(osc_lockless_truncate);
>  static int osc_destroys_in_flight_seq_show(struct seq_file *m, void *v)
>  {
>  	struct obd_device *obd = m->private;
> +
>  	return seq_printf(m, "%u\n",
>  			atomic_read(&obd->u.cli.cl_destroy_in_flight));
>  }
> @@ -602,6 +605,7 @@ static int osc_rpc_stats_seq_show(struct seq_file *seq, void *v)
>  	for (i = 0; i < OBD_HIST_MAX; i++) {
>  		unsigned long r = cli->cl_read_page_hist.oh_buckets[i];
>  		unsigned long w = cli->cl_write_page_hist.oh_buckets[i];
> +
>  		read_cum += r;
>  		write_cum += w;
>  		seq_printf(seq, "%d:\t\t%10lu %3lu %3lu   | %10lu %3lu %3lu\n",
> @@ -625,6 +629,7 @@ static int osc_rpc_stats_seq_show(struct seq_file *seq, void *v)
>  	for (i = 0; i < OBD_HIST_MAX; i++) {
>  		unsigned long r = cli->cl_read_rpc_hist.oh_buckets[i];
>  		unsigned long w = cli->cl_write_rpc_hist.oh_buckets[i];
> +
>  		read_cum += r;
>  		write_cum += w;
>  		seq_printf(seq, "%d:\t\t%10lu %3lu %3lu   | %10lu %3lu %3lu\n",
> @@ -648,6 +653,7 @@ static int osc_rpc_stats_seq_show(struct seq_file *seq, void *v)
>  	for (i = 0; i < OBD_HIST_MAX; i++) {
>  		unsigned long r = cli->cl_read_offset_hist.oh_buckets[i];
>  		unsigned long w = cli->cl_write_offset_hist.oh_buckets[i];
> +
>  		read_cum += r;
>  		write_cum += w;
>  		seq_printf(seq, "%d:\t\t%10lu %3lu %3lu   | %10lu %3lu %3lu\n",
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1425041831-15572-1-git-send-email-haticeerturk27%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>