Cannot locate pMgntInfo

Cannot locate pMgntInfo

[Ksenija Stanojević]

Hi,

While working on a patch, I needed to find out the type of
pMgntInfo->RegRfOff on line 2770, in file
drivers/staging/rtl8192u/r8192U_core.c. But I cannot find where
pMgntInfo is defined, I saw that is used in  rtl8192u and rtl8192eu
directories. I tried recursive grep to find it and I could not locate
where it is defined. I suppose it's some kind of macro...

Can you help me find out?

Regards,

Ksenija

Re: [Outreachy kernel] Cannot locate pMgntInfo

[Julia Lawall]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1414 bytes --]

On Tue, 3 Mar 2015, Ksenija Stanojević wrote:

> Hi,
>
> While working on a patch, I needed to find out the type of
> pMgntInfo->RegRfOff on line 2770, in file
> drivers/staging/rtl8192u/r8192U_core.c. But I cannot find where
> pMgntInfo is defined, I saw that is used in  rtl8192u and rtl8192eu
> directories. I tried recursive grep to find it and I could not locate
> where it is defined. I suppose it's some kind of macro...

The structure r8192_priv defined in rtl8192e/rtl8192e/rtl_core.h has a
field named RegRfOff.  It has type bool.  The directory is different than
the one you are looking at though.

In your directory, there is drivers/staging/rtl8192u/r8192U.h that
declares a r8192_priv structure type, but it does not have this field.

Maybe this is dead code?  Can you compile the file?

julia


>
> Can you help me find out?
>
> Regards,
>
> Ksenija
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAL7P5jKSFrxDKXwC1VhLfFYVPqHQ%3D2yK07o%2B84z_%3Dc64Qas9jQ%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] Cannot locate pMgntInfo

[Ksenija Stanojević]

On Tue, Mar 3, 2015 at 10:50 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> On Tue, 3 Mar 2015, Ksenija Stanojević wrote:
>
>> Hi,
>>
>> While working on a patch, I needed to find out the type of
>> pMgntInfo->RegRfOff on line 2770, in file
>> drivers/staging/rtl8192u/r8192U_core.c. But I cannot find where
>> pMgntInfo is defined, I saw that is used in  rtl8192u and rtl8192eu
>> directories. I tried recursive grep to find it and I could not locate
>> where it is defined. I suppose it's some kind of macro...
>
> The structure r8192_priv defined in rtl8192e/rtl8192e/rtl_core.h has a
> field named RegRfOff.  It has type bool.  The directory is different than
> the one you are looking at though.
>
> In your directory, there is drivers/staging/rtl8192u/r8192U.h that
> declares a r8192_priv structure type, but it does not have this field.
>
> Maybe this is dead code?  Can you compile the file?

Yes I can compile it, and I do: make
drivers/staging/rtl8192u/r8192U_core.o. Also I found
commented code : drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c in file
drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c (for example in line 214)

I find it quite strange.

Ksenija

> julia
>
>
>>
>> Can you help me find out?
>>
>> Regards,
>>
>> Ksenija
>>
>> --
>> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>> To post to this group, send email to outreachy-kernel@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAL7P5jKSFrxDKXwC1VhLfFYVPqHQ%3D2yK07o%2B84z_%3Dc64Qas9jQ%40mail.gmail.com.
>> For more options, visit https://groups.google.com/d/optout.
>>

Re: [Outreachy kernel] Cannot locate pMgntInfo

[Ksenija Stanojević]

On Tue, Mar 3, 2015 at 10:58 PM, Ksenija Stanojević
<ksenija.stanojevic@gmail.com> wrote:
> On Tue, Mar 3, 2015 at 10:50 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>> On Tue, 3 Mar 2015, Ksenija Stanojević wrote:
>>
>>> Hi,
>>>
>>> While working on a patch, I needed to find out the type of
>>> pMgntInfo->RegRfOff on line 2770, in file
>>> drivers/staging/rtl8192u/r8192U_core.c. But I cannot find where
>>> pMgntInfo is defined, I saw that is used in  rtl8192u and rtl8192eu
>>> directories. I tried recursive grep to find it and I could not locate
>>> where it is defined. I suppose it's some kind of macro...
>>
>> The structure r8192_priv defined in rtl8192e/rtl8192e/rtl_core.h has a
>> field named RegRfOff.  It has type bool.  The directory is different than
>> the one you are looking at though.
>>
>> In your directory, there is drivers/staging/rtl8192u/r8192U.h that
>> declares a r8192_priv structure type, but it does not have this field.
>>
>> Maybe this is dead code?  Can you compile the file?
>
> Yes I can compile it, and I do: make
> drivers/staging/rtl8192u/r8192U_core.o. Also I found
> commented code : /*PMGNT_INFO pMgntInfo = &padapter->MgntInfo; */
in file
> drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c (for example in line 214)
>
> I find it quite strange.
>
> Ksenija
>
>> julia
>>
>>
>>>
>>> Can you help me find out?
>>>
>>> Regards,
>>>
>>> Ksenija
>>>
>>> --
>>> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>>> To post to this group, send email to outreachy-kernel@googlegroups.com.
>>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAL7P5jKSFrxDKXwC1VhLfFYVPqHQ%3D2yK07o%2B84z_%3Dc64Qas9jQ%40mail.gmail.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>

Re: [Outreachy kernel] Cannot locate pMgntInfo

[Julia Lawall]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1383 bytes --]



On Tue, 3 Mar 2015, Ksenija Stanojević wrote:

> On Tue, Mar 3, 2015 at 10:50 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> > On Tue, 3 Mar 2015, Ksenija Stanojević wrote:
> >
> >> Hi,
> >>
> >> While working on a patch, I needed to find out the type of
> >> pMgntInfo->RegRfOff on line 2770, in file
> >> drivers/staging/rtl8192u/r8192U_core.c. But I cannot find where
> >> pMgntInfo is defined, I saw that is used in  rtl8192u and rtl8192eu
> >> directories. I tried recursive grep to find it and I could not locate
> >> where it is defined. I suppose it's some kind of macro...
> >
> > The structure r8192_priv defined in rtl8192e/rtl8192e/rtl_core.h has a
> > field named RegRfOff.  It has type bool.  The directory is different than
> > the one you are looking at though.
> >
> > In your directory, there is drivers/staging/rtl8192u/r8192U.h that
> > declares a r8192_priv structure type, but it does not have this field.
> >
> > Maybe this is dead code?  Can you compile the file?
>
> Yes I can compile it, and I do: make
> drivers/staging/rtl8192u/r8192U_core.o. Also I found
> commented code : drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c in file
> drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c (for example in line 214)
>
> I find it quite strange.

Is there an ifdef around the code?

You can say make foo.i and see the result of macro expansion.

julia

Re: [Outreachy kernel] Cannot locate pMgntInfo

[Ksenija Stanojević]

On Tue, Mar 3, 2015 at 10:59 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
> On Tue, 3 Mar 2015, Ksenija Stanojević wrote:
>
>> On Tue, Mar 3, 2015 at 10:50 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>> > On Tue, 3 Mar 2015, Ksenija Stanojević wrote:
>> >
>> >> Hi,
>> >>
>> >> While working on a patch, I needed to find out the type of
>> >> pMgntInfo->RegRfOff on line 2770, in file
>> >> drivers/staging/rtl8192u/r8192U_core.c. But I cannot find where
>> >> pMgntInfo is defined, I saw that is used in  rtl8192u and rtl8192eu
>> >> directories. I tried recursive grep to find it and I could not locate
>> >> where it is defined. I suppose it's some kind of macro...
>> >
>> > The structure r8192_priv defined in rtl8192e/rtl8192e/rtl_core.h has a
>> > field named RegRfOff.  It has type bool.  The directory is different than
>> > the one you are looking at though.
>> >
>> > In your directory, there is drivers/staging/rtl8192u/r8192U.h that
>> > declares a r8192_priv structure type, but it does not have this field.
>> >
>> > Maybe this is dead code?  Can you compile the file?
>>
>> Yes I can compile it, and I do: make
>> drivers/staging/rtl8192u/r8192U_core.o. Also I found
>> commented code : drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c in file
>> drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c (for example in line 214)
>>
>> I find it quite strange.
>
> Is there an ifdef around the code?

Yes, there is #ifdef TO_DO_LIST

> You can say make foo.i and see the result of macro expansion.

Ok, I will try that. Thanks.

Ksenija
>
> julia

Re: [Outreachy kernel] Cannot locate pMgntInfo

[Julia Lawall]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1866 bytes --]



On Tue, 3 Mar 2015, Ksenija Stanojević wrote:

> On Tue, Mar 3, 2015 at 10:59 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> >
> >
> > On Tue, 3 Mar 2015, Ksenija Stanojević wrote:
> >
> >> On Tue, Mar 3, 2015 at 10:50 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> >> > On Tue, 3 Mar 2015, Ksenija Stanojević wrote:
> >> >
> >> >> Hi,
> >> >>
> >> >> While working on a patch, I needed to find out the type of
> >> >> pMgntInfo->RegRfOff on line 2770, in file
> >> >> drivers/staging/rtl8192u/r8192U_core.c. But I cannot find where
> >> >> pMgntInfo is defined, I saw that is used in  rtl8192u and rtl8192eu
> >> >> directories. I tried recursive grep to find it and I could not locate
> >> >> where it is defined. I suppose it's some kind of macro...
> >> >
> >> > The structure r8192_priv defined in rtl8192e/rtl8192e/rtl_core.h has a
> >> > field named RegRfOff.  It has type bool.  The directory is different than
> >> > the one you are looking at though.
> >> >
> >> > In your directory, there is drivers/staging/rtl8192u/r8192U.h that
> >> > declares a r8192_priv structure type, but it does not have this field.
> >> >
> >> > Maybe this is dead code?  Can you compile the file?
> >>
> >> Yes I can compile it, and I do: make
> >> drivers/staging/rtl8192u/r8192U_core.o. Also I found
> >> commented code : drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c in file
> >> drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c (for example in line 214)
> >>
> >> I find it quite strange.
> >
> > Is there an ifdef around the code?
>
> Yes, there is #ifdef TO_DO_LIST

OK, this seems very unlikely to be set to true by your configuration.
Perhaps check the TODO list for the driver to see if there is
some information.

julia

>
> > You can say make foo.i and see the result of macro expansion.
>
> Ok, I will try that. Thanks.
>
> Ksenija
> >
> > julia
>

Re: [Outreachy kernel] Cannot locate pMgntInfo

[Ksenija Stanojević]

On Tue, Mar 3, 2015 at 11:03 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
> On Tue, 3 Mar 2015, Ksenija Stanojević wrote:
>
>> On Tue, Mar 3, 2015 at 10:59 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>> >
>> >
>> > On Tue, 3 Mar 2015, Ksenija Stanojević wrote:
>> >
>> >> On Tue, Mar 3, 2015 at 10:50 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>> >> > On Tue, 3 Mar 2015, Ksenija Stanojević wrote:
>> >> >
>> >> >> Hi,
>> >> >>
>> >> >> While working on a patch, I needed to find out the type of
>> >> >> pMgntInfo->RegRfOff on line 2770, in file
>> >> >> drivers/staging/rtl8192u/r8192U_core.c. But I cannot find where
>> >> >> pMgntInfo is defined, I saw that is used in  rtl8192u and rtl8192eu
>> >> >> directories. I tried recursive grep to find it and I could not locate
>> >> >> where it is defined. I suppose it's some kind of macro...
>> >> >
>> >> > The structure r8192_priv defined in rtl8192e/rtl8192e/rtl_core.h has a
>> >> > field named RegRfOff.  It has type bool.  The directory is different than
>> >> > the one you are looking at though.
>> >> >
>> >> > In your directory, there is drivers/staging/rtl8192u/r8192U.h that
>> >> > declares a r8192_priv structure type, but it does not have this field.
>> >> >
>> >> > Maybe this is dead code?  Can you compile the file?
>> >>
>> >> Yes I can compile it, and I do: make
>> >> drivers/staging/rtl8192u/r8192U_core.o. Also I found
>> >> commented code : drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c in file
>> >> drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c (for example in line 214)
>> >>
>> >> I find it quite strange.
>> >
>> > Is there an ifdef around the code?
>>
>> Yes, there is #ifdef TO_DO_LIST
>
> OK, this seems very unlikely to be set to true by your configuration.
> Perhaps check the TODO list for the driver to see if there is
> some information.

Hi, it seems that there is no TO DO LIst for this driver, I only found
one comment:

//// TODO: this function doesn't work well at this time, we should wait for FPGA

so maybe its all dead code?


Ksenija


>
> julia
>
>>
>> > You can say make foo.i and see the result of macro expansion.
>>
>> Ok, I will try that. Thanks.
>>
>> Ksenija
>> >
>> > julia
>>

Re: [Outreachy kernel] Cannot locate pMgntInfo

[Julia Lawall]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 2290 bytes --]



On Wed, 4 Mar 2015, Ksenija Stanojević wrote:

> On Tue, Mar 3, 2015 at 11:03 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> >
> >
> > On Tue, 3 Mar 2015, Ksenija Stanojević wrote:
> >
> >> On Tue, Mar 3, 2015 at 10:59 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> >> >
> >> >
> >> > On Tue, 3 Mar 2015, Ksenija Stanojević wrote:
> >> >
> >> >> On Tue, Mar 3, 2015 at 10:50 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> >> >> > On Tue, 3 Mar 2015, Ksenija Stanojević wrote:
> >> >> >
> >> >> >> Hi,
> >> >> >>
> >> >> >> While working on a patch, I needed to find out the type of
> >> >> >> pMgntInfo->RegRfOff on line 2770, in file
> >> >> >> drivers/staging/rtl8192u/r8192U_core.c. But I cannot find where
> >> >> >> pMgntInfo is defined, I saw that is used in  rtl8192u and rtl8192eu
> >> >> >> directories. I tried recursive grep to find it and I could not locate
> >> >> >> where it is defined. I suppose it's some kind of macro...
> >> >> >
> >> >> > The structure r8192_priv defined in rtl8192e/rtl8192e/rtl_core.h has a
> >> >> > field named RegRfOff.  It has type bool.  The directory is different than
> >> >> > the one you are looking at though.
> >> >> >
> >> >> > In your directory, there is drivers/staging/rtl8192u/r8192U.h that
> >> >> > declares a r8192_priv structure type, but it does not have this field.
> >> >> >
> >> >> > Maybe this is dead code?  Can you compile the file?
> >> >>
> >> >> Yes I can compile it, and I do: make
> >> >> drivers/staging/rtl8192u/r8192U_core.o. Also I found
> >> >> commented code : drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c in file
> >> >> drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c (for example in line 214)
> >> >>
> >> >> I find it quite strange.
> >> >
> >> > Is there an ifdef around the code?
> >>
> >> Yes, there is #ifdef TO_DO_LIST
> >
> > OK, this seems very unlikely to be set to true by your configuration.
> > Perhaps check the TODO list for the driver to see if there is
> > some information.
>
> Hi, it seems that there is no TO DO LIst for this driver, I only found
> one comment:
>
> //// TODO: this function doesn't work well at this time, we should wait for FPGA
>
> so maybe its all dead code?

No idea.  In any case, I wouldn't spend time on improving the uncompiled
parts...

julia