* [lustre-devel] [PATCH] Staging: lustre: obdclass: Remove unused header files
@ 2015-10-23 9:57 ` Shraddha Barke
0 siblings, 0 replies; 4+ messages in thread
From: Shraddha Barke @ 2015-10-23 9:57 UTC (permalink / raw)
To: lustre-devel
Remove unused header files that are already included in 'lu_object.h'
and 'obd.h'
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
drivers/staging/lustre/lustre/obdclass/lu_object.c | 1 -
drivers/staging/lustre/lustre/obdclass/lu_ref.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/lu_object.c b/drivers/staging/lustre/lustre/obdclass/lu_object.c
index 0d15bd5..549df95 100644
--- a/drivers/staging/lustre/lustre/obdclass/lu_object.c
+++ b/drivers/staging/lustre/lustre/obdclass/lu_object.c
@@ -55,7 +55,6 @@
#include "../include/lustre_disk.h"
#include "../include/lustre_fid.h"
#include "../include/lu_object.h"
-#include "../include/lu_ref.h"
#include <linux/list.h>
static void lu_object_free(const struct lu_env *env, struct lu_object *o);
diff --git a/drivers/staging/lustre/lustre/obdclass/lu_ref.c b/drivers/staging/lustre/lustre/obdclass/lu_ref.c
index 993697b..df2d8b9 100644
--- a/drivers/staging/lustre/lustre/obdclass/lu_ref.c
+++ b/drivers/staging/lustre/lustre/obdclass/lu_ref.c
@@ -47,4 +47,3 @@
#include "../include/obd.h"
#include "../include/obd_class.h"
#include "../include/obd_support.h"
-#include "../include/lu_ref.h"
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] Staging: lustre: obdclass: Remove unused header files
@ 2015-10-23 9:57 ` Shraddha Barke
0 siblings, 0 replies; 4+ messages in thread
From: Shraddha Barke @ 2015-10-23 9:57 UTC (permalink / raw)
To: outreachy-kernel; +Cc: lustre-devel
Remove unused header files that are already included in 'lu_object.h'
and 'obd.h'
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
drivers/staging/lustre/lustre/obdclass/lu_object.c | 1 -
drivers/staging/lustre/lustre/obdclass/lu_ref.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/lu_object.c b/drivers/staging/lustre/lustre/obdclass/lu_object.c
index 0d15bd5..549df95 100644
--- a/drivers/staging/lustre/lustre/obdclass/lu_object.c
+++ b/drivers/staging/lustre/lustre/obdclass/lu_object.c
@@ -55,7 +55,6 @@
#include "../include/lustre_disk.h"
#include "../include/lustre_fid.h"
#include "../include/lu_object.h"
-#include "../include/lu_ref.h"
#include <linux/list.h>
static void lu_object_free(const struct lu_env *env, struct lu_object *o);
diff --git a/drivers/staging/lustre/lustre/obdclass/lu_ref.c b/drivers/staging/lustre/lustre/obdclass/lu_ref.c
index 993697b..df2d8b9 100644
--- a/drivers/staging/lustre/lustre/obdclass/lu_ref.c
+++ b/drivers/staging/lustre/lustre/obdclass/lu_ref.c
@@ -47,4 +47,3 @@
#include "../include/obd.h"
#include "../include/obd_class.h"
#include "../include/obd_support.h"
-#include "../include/lu_ref.h"
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [lustre-devel] [Outreachy kernel] [PATCH] Staging: lustre: obdclass: Remove unused header files
2015-10-23 9:57 ` Shraddha Barke
@ 2015-10-23 9:59 ` Julia Lawall
-1 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2015-10-23 9:59 UTC (permalink / raw)
To: lustre-devel
On Fri, 23 Oct 2015, Shraddha Barke wrote:
> Remove unused header files that are already included in 'lu_object.h'
> and 'obd.h'
>
> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> ---
> drivers/staging/lustre/lustre/obdclass/lu_object.c | 1 -
> drivers/staging/lustre/lustre/obdclass/lu_ref.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/obdclass/lu_object.c b/drivers/staging/lustre/lustre/obdclass/lu_object.c
> index 0d15bd5..549df95 100644
> --- a/drivers/staging/lustre/lustre/obdclass/lu_object.c
> +++ b/drivers/staging/lustre/lustre/obdclass/lu_object.c
> @@ -55,7 +55,6 @@
> #include "../include/lustre_disk.h"
> #include "../include/lustre_fid.h"
> #include "../include/lu_object.h"
> -#include "../include/lu_ref.h"
If things from lu_ref.h are directly referred to in the .c file, it may be
better to keep the include, rather than relying on some other include file
(that could change in the future) to include it.
julia
> #include <linux/list.h>
>
> static void lu_object_free(const struct lu_env *env, struct lu_object *o);
> diff --git a/drivers/staging/lustre/lustre/obdclass/lu_ref.c b/drivers/staging/lustre/lustre/obdclass/lu_ref.c
> index 993697b..df2d8b9 100644
> --- a/drivers/staging/lustre/lustre/obdclass/lu_ref.c
> +++ b/drivers/staging/lustre/lustre/obdclass/lu_ref.c
> @@ -47,4 +47,3 @@
> #include "../include/obd.h"
> #include "../include/obd_class.h"
> #include "../include/obd_support.h"
> -#include "../include/lu_ref.h"
> --
> 2.1.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe at googlegroups.com.
> To post to this group, send email to outreachy-kernel at googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1445594277-14421-1-git-send-email-shraddha.6596%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: lustre: obdclass: Remove unused header files
@ 2015-10-23 9:59 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2015-10-23 9:59 UTC (permalink / raw)
To: Shraddha Barke; +Cc: outreachy-kernel, lustre-devel
On Fri, 23 Oct 2015, Shraddha Barke wrote:
> Remove unused header files that are already included in 'lu_object.h'
> and 'obd.h'
>
> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> ---
> drivers/staging/lustre/lustre/obdclass/lu_object.c | 1 -
> drivers/staging/lustre/lustre/obdclass/lu_ref.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/obdclass/lu_object.c b/drivers/staging/lustre/lustre/obdclass/lu_object.c
> index 0d15bd5..549df95 100644
> --- a/drivers/staging/lustre/lustre/obdclass/lu_object.c
> +++ b/drivers/staging/lustre/lustre/obdclass/lu_object.c
> @@ -55,7 +55,6 @@
> #include "../include/lustre_disk.h"
> #include "../include/lustre_fid.h"
> #include "../include/lu_object.h"
> -#include "../include/lu_ref.h"
If things from lu_ref.h are directly referred to in the .c file, it may be
better to keep the include, rather than relying on some other include file
(that could change in the future) to include it.
julia
> #include <linux/list.h>
>
> static void lu_object_free(const struct lu_env *env, struct lu_object *o);
> diff --git a/drivers/staging/lustre/lustre/obdclass/lu_ref.c b/drivers/staging/lustre/lustre/obdclass/lu_ref.c
> index 993697b..df2d8b9 100644
> --- a/drivers/staging/lustre/lustre/obdclass/lu_ref.c
> +++ b/drivers/staging/lustre/lustre/obdclass/lu_ref.c
> @@ -47,4 +47,3 @@
> #include "../include/obd.h"
> #include "../include/obd_class.h"
> #include "../include/obd_support.h"
> -#include "../include/lu_ref.h"
> --
> 2.1.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1445594277-14421-1-git-send-email-shraddha.6596%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-23 9:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-23 9:57 [lustre-devel] [PATCH] Staging: lustre: obdclass: Remove unused header files Shraddha Barke
2015-10-23 9:57 ` Shraddha Barke
2015-10-23 9:59 ` [lustre-devel] [Outreachy kernel] " Julia Lawall
2015-10-23 9:59 ` Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.