All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] [media] media: videobuf2: fix compare_const_fl.cocci warnings
@ 2015-11-13 10:46 Julia Lawall
  2015-11-15 23:05 ` Sakari Ailus
  0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2015-11-13 10:46 UTC (permalink / raw)
  To: Junghak Sung
  Cc: kbuild-all, linux-kernel, Mauro Carvalho Chehab, linux-media,
	Geunyoung Kim, Hans Verkuil, Pawel Osciak, Marek Szyprowski,
	Kyungmin Park, linux-kernel

 Move constants to the right of binary operators.

Generated by: scripts/coccinelle/misc/compare_const_fl.cocci

CC: Junghak Sung <jh1009.sung@samsung.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
---

!b->m.planes could also be possible.  Up to you.

 videobuf2-v4l2.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/media/v4l2-core/videobuf2-v4l2.c
+++ b/drivers/media/v4l2-core/videobuf2-v4l2.c
@@ -52,7 +52,7 @@ static int __verify_planes_array(struct
 		return 0;

 	/* Is memory for copying plane information present? */
-	if (NULL == b->m.planes) {
+	if (b->m.planes == NULL) {
 		dprintk(1, "multi-planar buffer passed but "
 			   "planes array not provided\n");
 		return -EINVAL;

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] [media] media: videobuf2: fix compare_const_fl.cocci warnings
  2015-11-13 10:46 [PATCH] [media] media: videobuf2: fix compare_const_fl.cocci warnings Julia Lawall
@ 2015-11-15 23:05 ` Sakari Ailus
  0 siblings, 0 replies; 2+ messages in thread
From: Sakari Ailus @ 2015-11-15 23:05 UTC (permalink / raw)
  To: Julia Lawall
  Cc: Junghak Sung, kbuild-all, linux-kernel, Mauro Carvalho Chehab,
	linux-media, Geunyoung Kim, Hans Verkuil, Pawel Osciak,
	Marek Szyprowski, Kyungmin Park

On Fri, Nov 13, 2015 at 11:46:00AM +0100, Julia Lawall wrote:
>  Move constants to the right of binary operators.
> 
> Generated by: scripts/coccinelle/misc/compare_const_fl.cocci
> 
> CC: Junghak Sung <jh1009.sung@samsung.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>

Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>

-- 
Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-11-15 23:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-13 10:46 [PATCH] [media] media: videobuf2: fix compare_const_fl.cocci warnings Julia Lawall
2015-11-15 23:05 ` Sakari Ailus

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.