* [PATCH v1] mm: fix warning in comparing enumerator
@ 2015-12-01 8:37 ` Naoya Horiguchi
0 siblings, 0 replies; 10+ messages in thread
From: Naoya Horiguchi @ 2015-12-01 8:37 UTC (permalink / raw)
To: Andrew Morton
Cc: Yaowei Bai, KAMEZAWA Hiroyuki, linux-mm, linux-kernel,
Naoya Horiguchi, Naoya Horiguchi
I saw the following warning when building mmotm-2015-11-25-17-08.
mm/page_alloc.c:4185:16: warning: comparison between 'enum zone_type' and 'enum <anonymous>' [-Wenum-compare]
for (i = 0; i < MAX_ZONELISTS; i++) {
^
enum zone_type is named like ZONE_* which is different from ZONELIST_*, so
we are somehow doing incorrect comparison. Just fixes it.
Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
---
mm/page_alloc.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git mmotm-2015-11-25-17-08/mm/page_alloc.c mmotm-2015-11-25-17-08_patched/mm/page_alloc.c
index e267faa..b801e6f 100644
--- mmotm-2015-11-25-17-08/mm/page_alloc.c
+++ mmotm-2015-11-25-17-08_patched/mm/page_alloc.c
@@ -4174,8 +4174,7 @@ static void set_zonelist_order(void)
static void build_zonelists(pg_data_t *pgdat)
{
- int j, node, load;
- enum zone_type i;
+ int i, j, node, load;
nodemask_t used_mask;
int local_node, prev_node;
struct zonelist *zonelist;
--
1.7.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v1] mm: fix warning in comparing enumerator @ 2015-12-01 8:37 ` Naoya Horiguchi 0 siblings, 0 replies; 10+ messages in thread From: Naoya Horiguchi @ 2015-12-01 8:37 UTC (permalink / raw) To: Andrew Morton Cc: Yaowei Bai, KAMEZAWA Hiroyuki, linux-mm, linux-kernel, Naoya Horiguchi, Naoya Horiguchi I saw the following warning when building mmotm-2015-11-25-17-08. mm/page_alloc.c:4185:16: warning: comparison between 'enum zone_type' and 'enum <anonymous>' [-Wenum-compare] for (i = 0; i < MAX_ZONELISTS; i++) { ^ enum zone_type is named like ZONE_* which is different from ZONELIST_*, so we are somehow doing incorrect comparison. Just fixes it. Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> --- mm/page_alloc.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git mmotm-2015-11-25-17-08/mm/page_alloc.c mmotm-2015-11-25-17-08_patched/mm/page_alloc.c index e267faa..b801e6f 100644 --- mmotm-2015-11-25-17-08/mm/page_alloc.c +++ mmotm-2015-11-25-17-08_patched/mm/page_alloc.c @@ -4174,8 +4174,7 @@ static void set_zonelist_order(void) static void build_zonelists(pg_data_t *pgdat) { - int j, node, load; - enum zone_type i; + int i, j, node, load; nodemask_t used_mask; int local_node, prev_node; struct zonelist *zonelist; -- 1.7.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v1] mm: fix warning in comparing enumerator 2015-12-01 8:37 ` Naoya Horiguchi @ 2015-12-01 22:25 ` David Rientjes -1 siblings, 0 replies; 10+ messages in thread From: David Rientjes @ 2015-12-01 22:25 UTC (permalink / raw) To: Naoya Horiguchi Cc: Andrew Morton, Yaowei Bai, KAMEZAWA Hiroyuki, linux-mm, linux-kernel, Naoya Horiguchi On Tue, 1 Dec 2015, Naoya Horiguchi wrote: > I saw the following warning when building mmotm-2015-11-25-17-08. > > mm/page_alloc.c:4185:16: warning: comparison between 'enum zone_type' and 'enum <anonymous>' [-Wenum-compare] > for (i = 0; i < MAX_ZONELISTS; i++) { > ^ > > enum zone_type is named like ZONE_* which is different from ZONELIST_*, so > we are somehow doing incorrect comparison. Just fixes it. > > Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> > --- > mm/page_alloc.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git mmotm-2015-11-25-17-08/mm/page_alloc.c mmotm-2015-11-25-17-08_patched/mm/page_alloc.c > index e267faa..b801e6f 100644 > --- mmotm-2015-11-25-17-08/mm/page_alloc.c > +++ mmotm-2015-11-25-17-08_patched/mm/page_alloc.c > @@ -4174,8 +4174,7 @@ static void set_zonelist_order(void) > > static void build_zonelists(pg_data_t *pgdat) > { > - int j, node, load; > - enum zone_type i; > + int i, j, node, load; > nodemask_t used_mask; > int local_node, prev_node; > struct zonelist *zonelist; Obviously correct, but I would have thought we could just remove 'j' and used 'i' as our iterator through the entire function. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1] mm: fix warning in comparing enumerator @ 2015-12-01 22:25 ` David Rientjes 0 siblings, 0 replies; 10+ messages in thread From: David Rientjes @ 2015-12-01 22:25 UTC (permalink / raw) To: Naoya Horiguchi Cc: Andrew Morton, Yaowei Bai, KAMEZAWA Hiroyuki, linux-mm, linux-kernel, Naoya Horiguchi On Tue, 1 Dec 2015, Naoya Horiguchi wrote: > I saw the following warning when building mmotm-2015-11-25-17-08. > > mm/page_alloc.c:4185:16: warning: comparison between 'enum zone_type' and 'enum <anonymous>' [-Wenum-compare] > for (i = 0; i < MAX_ZONELISTS; i++) { > ^ > > enum zone_type is named like ZONE_* which is different from ZONELIST_*, so > we are somehow doing incorrect comparison. Just fixes it. > > Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> > --- > mm/page_alloc.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git mmotm-2015-11-25-17-08/mm/page_alloc.c mmotm-2015-11-25-17-08_patched/mm/page_alloc.c > index e267faa..b801e6f 100644 > --- mmotm-2015-11-25-17-08/mm/page_alloc.c > +++ mmotm-2015-11-25-17-08_patched/mm/page_alloc.c > @@ -4174,8 +4174,7 @@ static void set_zonelist_order(void) > > static void build_zonelists(pg_data_t *pgdat) > { > - int j, node, load; > - enum zone_type i; > + int i, j, node, load; > nodemask_t used_mask; > int local_node, prev_node; > struct zonelist *zonelist; Obviously correct, but I would have thought we could just remove 'j' and used 'i' as our iterator through the entire function. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2] mm: fix warning in comparing enumerator 2015-12-01 22:25 ` David Rientjes @ 2015-12-01 23:07 ` Naoya Horiguchi -1 siblings, 0 replies; 10+ messages in thread From: Naoya Horiguchi @ 2015-12-01 23:07 UTC (permalink / raw) To: David Rientjes Cc: Naoya Horiguchi, Andrew Morton, Yaowei Bai, KAMEZAWA Hiroyuki, linux-mm, linux-kernel On Tue, Dec 01, 2015 at 02:25:50PM -0800, David Rientjes wrote: > On Tue, 1 Dec 2015, Naoya Horiguchi wrote: > > > I saw the following warning when building mmotm-2015-11-25-17-08. > > > > mm/page_alloc.c:4185:16: warning: comparison between 'enum zone_type' and 'enum <anonymous>' [-Wenum-compare] > > for (i = 0; i < MAX_ZONELISTS; i++) { > > ^ > > > > enum zone_type is named like ZONE_* which is different from ZONELIST_*, so > > we are somehow doing incorrect comparison. Just fixes it. > > > > Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> > > --- > > mm/page_alloc.c | 3 +-- > > 1 files changed, 1 insertions(+), 2 deletions(-) > > > > diff --git mmotm-2015-11-25-17-08/mm/page_alloc.c mmotm-2015-11-25-17-08_patched/mm/page_alloc.c > > index e267faa..b801e6f 100644 > > --- mmotm-2015-11-25-17-08/mm/page_alloc.c > > +++ mmotm-2015-11-25-17-08_patched/mm/page_alloc.c > > @@ -4174,8 +4174,7 @@ static void set_zonelist_order(void) > > > > static void build_zonelists(pg_data_t *pgdat) > > { > > - int j, node, load; > > - enum zone_type i; > > + int i, j, node, load; > > nodemask_t used_mask; > > int local_node, prev_node; > > struct zonelist *zonelist; > > Obviously correct, but I would have thought we could just remove 'j' and > used 'i' as our iterator through the entire function. You're right, thank you. Here is v2. --- From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> Subject: [PATCH v2] mm: fix warning in comparing enumerator I saw the following warning when building mmotm-2015-11-25-17-08. mm/page_alloc.c:4185:16: warning: comparison between 'enum zone_type' and 'enum <anonymous>' [-Wenum-compare] for (i = 0; i < MAX_ZONELISTS; i++) { ^ enum zone_type is named like ZONE_* which is different from ZONELIST_*, so we are somehow doing incorrect comparison. Just fixes it. Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> --- v1 -> v2: - remove 'j' --- mm/page_alloc.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index e267faad4649..54fcd0a60d5e 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -4174,8 +4174,7 @@ static void set_zonelist_order(void) static void build_zonelists(pg_data_t *pgdat) { - int j, node, load; - enum zone_type i; + int i, node, load; nodemask_t used_mask; int local_node, prev_node; struct zonelist *zonelist; @@ -4195,7 +4194,7 @@ static void build_zonelists(pg_data_t *pgdat) nodes_clear(used_mask); memset(node_order, 0, sizeof(node_order)); - j = 0; + i = 0; while ((node = find_next_best_node(local_node, &used_mask)) >= 0) { /* @@ -4212,12 +4211,12 @@ static void build_zonelists(pg_data_t *pgdat) if (order == ZONELIST_ORDER_NODE) build_zonelists_in_node_order(pgdat, node); else - node_order[j++] = node; /* remember order */ + node_order[i++] = node; /* remember order */ } if (order == ZONELIST_ORDER_ZONE) { /* calculate node order -- i.e., DMA last! */ - build_zonelists_in_zone_order(pgdat, j); + build_zonelists_in_zone_order(pgdat, i); } build_thisnode_zonelists(pgdat); -- 2.4.3 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2] mm: fix warning in comparing enumerator @ 2015-12-01 23:07 ` Naoya Horiguchi 0 siblings, 0 replies; 10+ messages in thread From: Naoya Horiguchi @ 2015-12-01 23:07 UTC (permalink / raw) To: David Rientjes Cc: Naoya Horiguchi, Andrew Morton, Yaowei Bai, KAMEZAWA Hiroyuki, linux-mm, linux-kernel On Tue, Dec 01, 2015 at 02:25:50PM -0800, David Rientjes wrote: > On Tue, 1 Dec 2015, Naoya Horiguchi wrote: > > > I saw the following warning when building mmotm-2015-11-25-17-08. > > > > mm/page_alloc.c:4185:16: warning: comparison between 'enum zone_type' and 'enum <anonymous>' [-Wenum-compare] > > for (i = 0; i < MAX_ZONELISTS; i++) { > > ^ > > > > enum zone_type is named like ZONE_* which is different from ZONELIST_*, so > > we are somehow doing incorrect comparison. Just fixes it. > > > > Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> > > --- > > mm/page_alloc.c | 3 +-- > > 1 files changed, 1 insertions(+), 2 deletions(-) > > > > diff --git mmotm-2015-11-25-17-08/mm/page_alloc.c mmotm-2015-11-25-17-08_patched/mm/page_alloc.c > > index e267faa..b801e6f 100644 > > --- mmotm-2015-11-25-17-08/mm/page_alloc.c > > +++ mmotm-2015-11-25-17-08_patched/mm/page_alloc.c > > @@ -4174,8 +4174,7 @@ static void set_zonelist_order(void) > > > > static void build_zonelists(pg_data_t *pgdat) > > { > > - int j, node, load; > > - enum zone_type i; > > + int i, j, node, load; > > nodemask_t used_mask; > > int local_node, prev_node; > > struct zonelist *zonelist; > > Obviously correct, but I would have thought we could just remove 'j' and > used 'i' as our iterator through the entire function. You're right, thank you. Here is v2. --- From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> Subject: [PATCH v2] mm: fix warning in comparing enumerator I saw the following warning when building mmotm-2015-11-25-17-08. mm/page_alloc.c:4185:16: warning: comparison between 'enum zone_type' and 'enum <anonymous>' [-Wenum-compare] for (i = 0; i < MAX_ZONELISTS; i++) { ^ enum zone_type is named like ZONE_* which is different from ZONELIST_*, so we are somehow doing incorrect comparison. Just fixes it. Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> --- v1 -> v2: - remove 'j' --- mm/page_alloc.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index e267faad4649..54fcd0a60d5e 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -4174,8 +4174,7 @@ static void set_zonelist_order(void) static void build_zonelists(pg_data_t *pgdat) { - int j, node, load; - enum zone_type i; + int i, node, load; nodemask_t used_mask; int local_node, prev_node; struct zonelist *zonelist; @@ -4195,7 +4194,7 @@ static void build_zonelists(pg_data_t *pgdat) nodes_clear(used_mask); memset(node_order, 0, sizeof(node_order)); - j = 0; + i = 0; while ((node = find_next_best_node(local_node, &used_mask)) >= 0) { /* @@ -4212,12 +4211,12 @@ static void build_zonelists(pg_data_t *pgdat) if (order == ZONELIST_ORDER_NODE) build_zonelists_in_node_order(pgdat, node); else - node_order[j++] = node; /* remember order */ + node_order[i++] = node; /* remember order */ } if (order == ZONELIST_ORDER_ZONE) { /* calculate node order -- i.e., DMA last! */ - build_zonelists_in_zone_order(pgdat, j); + build_zonelists_in_zone_order(pgdat, i); } build_thisnode_zonelists(pgdat); -- 2.4.3 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2] mm: fix warning in comparing enumerator 2015-12-01 23:07 ` Naoya Horiguchi @ 2015-12-01 23:35 ` David Rientjes -1 siblings, 0 replies; 10+ messages in thread From: David Rientjes @ 2015-12-01 23:35 UTC (permalink / raw) To: Naoya Horiguchi Cc: Naoya Horiguchi, Andrew Morton, Yaowei Bai, KAMEZAWA Hiroyuki, linux-mm, linux-kernel On Wed, 2 Dec 2015, Naoya Horiguchi wrote: > From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> > Subject: [PATCH v2] mm: fix warning in comparing enumerator > > I saw the following warning when building mmotm-2015-11-25-17-08. > > mm/page_alloc.c:4185:16: warning: comparison between 'enum zone_type' and 'enum <anonymous>' [-Wenum-compare] > for (i = 0; i < MAX_ZONELISTS; i++) { > ^ > > enum zone_type is named like ZONE_* which is different from ZONELIST_*, so > we are somehow doing incorrect comparison. Just fixes it. > > Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> Acked-by: David Rientjes <rientjes@google.com> ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] mm: fix warning in comparing enumerator @ 2015-12-01 23:35 ` David Rientjes 0 siblings, 0 replies; 10+ messages in thread From: David Rientjes @ 2015-12-01 23:35 UTC (permalink / raw) To: Naoya Horiguchi Cc: Naoya Horiguchi, Andrew Morton, Yaowei Bai, KAMEZAWA Hiroyuki, linux-mm, linux-kernel On Wed, 2 Dec 2015, Naoya Horiguchi wrote: > From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> > Subject: [PATCH v2] mm: fix warning in comparing enumerator > > I saw the following warning when building mmotm-2015-11-25-17-08. > > mm/page_alloc.c:4185:16: warning: comparison between 'enum zone_type' and 'enum <anonymous>' [-Wenum-compare] > for (i = 0; i < MAX_ZONELISTS; i++) { > ^ > > enum zone_type is named like ZONE_* which is different from ZONELIST_*, so > we are somehow doing incorrect comparison. Just fixes it. > > Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> Acked-by: David Rientjes <rientjes@google.com> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] mm: fix warning in comparing enumerator 2015-12-01 23:07 ` Naoya Horiguchi @ 2015-12-02 9:16 ` Yaowei Bai -1 siblings, 0 replies; 10+ messages in thread From: Yaowei Bai @ 2015-12-02 9:16 UTC (permalink / raw) To: Naoya Horiguchi Cc: David Rientjes, Naoya Horiguchi, Andrew Morton, KAMEZAWA Hiroyuki, linux-mm, linux-kernel On Wed, Dec 02, 2015 at 08:07:42AM +0900, Naoya Horiguchi wrote: > On Tue, Dec 01, 2015 at 02:25:50PM -0800, David Rientjes wrote: > > On Tue, 1 Dec 2015, Naoya Horiguchi wrote: > > I saw the following warning when building mmotm-2015-11-25-17-08. > > mm/page_alloc.c:4185:16: warning: comparison between 'enum zone_type' and 'enum <anonymous>' [-Wenum-compare] > for (i = 0; i < MAX_ZONELISTS; i++) { > ^ > > enum zone_type is named like ZONE_* which is different from ZONELIST_*, so > we are somehow doing incorrect comparison. Just fixes it. > > Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> Acked-by: Yaowei Bai <baiyaowei@cmss.chinamobile.com> ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] mm: fix warning in comparing enumerator @ 2015-12-02 9:16 ` Yaowei Bai 0 siblings, 0 replies; 10+ messages in thread From: Yaowei Bai @ 2015-12-02 9:16 UTC (permalink / raw) To: Naoya Horiguchi Cc: David Rientjes, Naoya Horiguchi, Andrew Morton, KAMEZAWA Hiroyuki, linux-mm, linux-kernel On Wed, Dec 02, 2015 at 08:07:42AM +0900, Naoya Horiguchi wrote: > On Tue, Dec 01, 2015 at 02:25:50PM -0800, David Rientjes wrote: > > On Tue, 1 Dec 2015, Naoya Horiguchi wrote: > > I saw the following warning when building mmotm-2015-11-25-17-08. > > mm/page_alloc.c:4185:16: warning: comparison between 'enum zone_type' and 'enum <anonymous>' [-Wenum-compare] > for (i = 0; i < MAX_ZONELISTS; i++) { > ^ > > enum zone_type is named like ZONE_* which is different from ZONELIST_*, so > we are somehow doing incorrect comparison. Just fixes it. > > Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> Acked-by: Yaowei Bai <baiyaowei@cmss.chinamobile.com> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-12-02 9:17 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2015-12-01 8:37 [PATCH v1] mm: fix warning in comparing enumerator Naoya Horiguchi 2015-12-01 8:37 ` Naoya Horiguchi 2015-12-01 22:25 ` David Rientjes 2015-12-01 22:25 ` David Rientjes 2015-12-01 23:07 ` [PATCH v2] " Naoya Horiguchi 2015-12-01 23:07 ` Naoya Horiguchi 2015-12-01 23:35 ` David Rientjes 2015-12-01 23:35 ` David Rientjes 2015-12-02 9:16 ` Yaowei Bai 2015-12-02 9:16 ` Yaowei Bai
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.