All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
	"James E.J. Bottomley" <JBottomley@odin.com>,
	Ondrej Zary <linux@rainbow-software.org>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org, Hannes Reinecke <hare@suse.com>
Subject: Re: [patch RESEND] atp870u: 64 bit bug in atp885_init()
Date: Wed, 9 Dec 2015 19:11:15 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.10.1512091907590.2491@hadrien> (raw)
In-Reply-To: <20151209174819.GB5177@mwanda>



On Wed, 9 Dec 2015, Dan Carpenter wrote:

> We should add a tag to indicate that we are sending a patch for a crappy
> driver.
>
> IMHO-this-driver-is-garbage: Your Name <email>
>
> If it got 10 votes of no confidence it would be moved to staging and
> then deleted.

Forgive my ignorance, but what is the exact procedure?  For example, the
following file: drivers/pcmcia/vrc4173_cardu.c contains the following
code: INIT_WORK(&socket->tq_work, cardu_bh, socket);.  The last time
INIT_WORK took three arguments was Linux 2.6.19, so I think no one has
been compiling this code recently.  There would be the .c file and the
associated .h file to move to staging, but it's less clear to me eg what
to do with the Kconfig entry and the Makefile entry.  And is there
anything else to take into account?

thanks,
julia

WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia.lawall@lip6.fr>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
	"James E.J. Bottomley" <JBottomley@odin.com>,
	Ondrej Zary <linux@rainbow-software.org>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org, Hannes Reinecke <hare@suse.com>
Subject: Re: [patch RESEND] atp870u: 64 bit bug in atp885_init()
Date: Wed, 09 Dec 2015 18:11:15 +0000	[thread overview]
Message-ID: <alpine.DEB.2.10.1512091907590.2491@hadrien> (raw)
In-Reply-To: <20151209174819.GB5177@mwanda>



On Wed, 9 Dec 2015, Dan Carpenter wrote:

> We should add a tag to indicate that we are sending a patch for a crappy
> driver.
>
> IMHO-this-driver-is-garbage: Your Name <email>
>
> If it got 10 votes of no confidence it would be moved to staging and
> then deleted.

Forgive my ignorance, but what is the exact procedure?  For example, the
following file: drivers/pcmcia/vrc4173_cardu.c contains the following
code: INIT_WORK(&socket->tq_work, cardu_bh, socket);.  The last time
INIT_WORK took three arguments was Linux 2.6.19, so I think no one has
been compiling this code recently.  There would be the .c file and the
associated .h file to move to staging, but it's less clear to me eg what
to do with the Kconfig entry and the Makefile entry.  And is there
anything else to take into account?

thanks,
julia

  reply	other threads:[~2015-12-09 18:11 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-04  9:50 [patch] [SCSI] atp870u: 64 bit bug in probe() Dan Carpenter
2013-09-04  9:50 ` Dan Carpenter
2015-07-29 21:36 ` Dan Carpenter
2015-07-29 21:36   ` Dan Carpenter
2015-07-30  6:54   ` Hannes Reinecke
2015-07-30  6:54     ` Hannes Reinecke
2015-12-09 10:24     ` [patch RESEND] atp870u: 64 bit bug in atp885_init() Dan Carpenter
2015-12-09 10:24       ` Dan Carpenter
2015-12-09 11:53       ` One Thousand Gnomes
2015-12-09 11:53         ` One Thousand Gnomes
2015-12-09 12:07         ` Ondrej Zary
2015-12-09 12:07           ` Ondrej Zary
2015-12-09 13:45         ` Dan Carpenter
2015-12-09 13:45           ` Dan Carpenter
2015-12-09 14:14           ` One Thousand Gnomes
2015-12-09 14:14             ` One Thousand Gnomes
2015-12-09 17:48             ` Dan Carpenter
2015-12-09 17:48               ` Dan Carpenter
2015-12-09 18:11               ` Julia Lawall [this message]
2015-12-09 18:11                 ` Julia Lawall
2015-12-09 18:28                 ` Dan Carpenter
2015-12-09 18:28                   ` Dan Carpenter
2015-12-09 19:37                   ` One Thousand Gnomes
2015-12-09 19:37                     ` One Thousand Gnomes
2018-02-15 23:44       ` Martin K. Petersen
2018-02-15 23:44         ` Martin K. Petersen
2018-03-02  2:11       ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.10.1512091907590.2491@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=JBottomley@odin.com \
    --cc=dan.carpenter@oracle.com \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=hare@suse.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux@rainbow-software.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.