All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: Michal Hocko <mhocko@kernel.org>,
	linux-mm@kvack.org,
	Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC 1/3] oom, sysrq: Skip over oom victims and killed tasks
Date: Tue, 19 Jan 2016 15:01:44 -0800 (PST)	[thread overview]
Message-ID: <alpine.DEB.2.10.1601191458100.7346@chino.kir.corp.google.com> (raw)
In-Reply-To: <20160115153721.7d363aef@lxorguk.ukuu.org.uk>

On Fri, 15 Jan 2016, One Thousand Gnomes wrote:

> > > I think it's time to kill sysrq+F and I'll send those two patches
> > > unless there is a usecase I'm not aware of.
> > 
> > I have described one in the part you haven't quoted here. Let me repeat:
> > : Your system might be trashing to the point you are not able to log in
> > : and resolve the situation in a reasonable time yet you are still not
> > : OOM. sysrq+f is your only choice then.
> > 
> > Could you clarify why it is better to ditch a potentially usefull
> > emergency tool rather than to make it work reliably and predictably?
> 
> Even if it doesn't work reliably and predictably it is *still* better
> than removing it as it works currently. Today we have "might save you a
> reboot", the removal turns it into "you'll have to reboot". That's a
> regression.
> 

Under what circumstance are you supposing to use sysrq+f in your 
hypothetical?  If you have access to the shell, then you can kill any 
process at random (and you may even be able to make better realtime 
decisions than the oom killer) and it will gain access to memory reserves 
immediately under my proposal when it tries to allocate memory.  The net 
result is that calling the oom killer is no better than you issuing the 
SIGKILL yourself.

This doesn't work if your are supposing to use sysrq+f without the ability 
to get access to the shell.  That's the point, I believe, that Michal has 
raised in this thread.  I'd like to address that issue directly rather 
than requiring human intervention to fix.  If you have deployed a very 
large number of machines to your datacenters, you don't possibly have the 
resources to do this.

WARNING: multiple messages have this Message-ID (diff)
From: David Rientjes <rientjes@google.com>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: Michal Hocko <mhocko@kernel.org>,
	linux-mm@kvack.org,
	Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC 1/3] oom, sysrq: Skip over oom victims and killed tasks
Date: Tue, 19 Jan 2016 15:01:44 -0800 (PST)	[thread overview]
Message-ID: <alpine.DEB.2.10.1601191458100.7346@chino.kir.corp.google.com> (raw)
In-Reply-To: <20160115153721.7d363aef@lxorguk.ukuu.org.uk>

On Fri, 15 Jan 2016, One Thousand Gnomes wrote:

> > > I think it's time to kill sysrq+F and I'll send those two patches
> > > unless there is a usecase I'm not aware of.
> > 
> > I have described one in the part you haven't quoted here. Let me repeat:
> > : Your system might be trashing to the point you are not able to log in
> > : and resolve the situation in a reasonable time yet you are still not
> > : OOM. sysrq+f is your only choice then.
> > 
> > Could you clarify why it is better to ditch a potentially usefull
> > emergency tool rather than to make it work reliably and predictably?
> 
> Even if it doesn't work reliably and predictably it is *still* better
> than removing it as it works currently. Today we have "might save you a
> reboot", the removal turns it into "you'll have to reboot". That's a
> regression.
> 

Under what circumstance are you supposing to use sysrq+f in your 
hypothetical?  If you have access to the shell, then you can kill any 
process at random (and you may even be able to make better realtime 
decisions than the oom killer) and it will gain access to memory reserves 
immediately under my proposal when it tries to allocate memory.  The net 
result is that calling the oom killer is no better than you issuing the 
SIGKILL yourself.

This doesn't work if your are supposing to use sysrq+f without the ability 
to get access to the shell.  That's the point, I believe, that Michal has 
raised in this thread.  I'd like to address that issue directly rather 
than requiring human intervention to fix.  If you have deployed a very 
large number of machines to your datacenters, you don't possibly have the 
resources to do this.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2016-01-19 23:01 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-12 21:00 [RFC 0/3] oom: few enahancements Michal Hocko
2016-01-12 21:00 ` Michal Hocko
2016-01-12 21:00 ` [RFC 1/3] oom, sysrq: Skip over oom victims and killed tasks Michal Hocko
2016-01-12 21:00   ` Michal Hocko
2016-01-13  0:41   ` David Rientjes
2016-01-13  0:41     ` David Rientjes
2016-01-13  9:30     ` Michal Hocko
2016-01-13  9:30       ` Michal Hocko
2016-01-14  0:38       ` David Rientjes
2016-01-14  0:38         ` David Rientjes
2016-01-14 11:00         ` Michal Hocko
2016-01-14 11:00           ` Michal Hocko
2016-01-14 21:51           ` David Rientjes
2016-01-14 21:51             ` David Rientjes
2016-01-15 10:12             ` Michal Hocko
2016-01-15 10:12               ` Michal Hocko
2016-01-15 15:37               ` One Thousand Gnomes
2016-01-15 15:37                 ` One Thousand Gnomes
2016-01-19 23:01                 ` David Rientjes [this message]
2016-01-19 23:01                   ` David Rientjes
2016-01-19 22:57               ` David Rientjes
2016-01-19 22:57                 ` David Rientjes
2016-01-20  9:49                 ` Michal Hocko
2016-01-20  9:49                   ` Michal Hocko
2016-01-21  0:01                   ` David Rientjes
2016-01-21  0:01                     ` David Rientjes
2016-01-21  9:15                     ` Michal Hocko
2016-01-21  9:15                       ` Michal Hocko
2016-01-12 21:00 ` [RFC 2/3] oom: Do not sacrifice already OOM killed children Michal Hocko
2016-01-12 21:00   ` Michal Hocko
2016-01-13  0:45   ` David Rientjes
2016-01-13  0:45     ` David Rientjes
2016-01-13  9:36     ` Michal Hocko
2016-01-13  9:36       ` Michal Hocko
2016-01-14  0:42       ` David Rientjes
2016-01-14  0:42         ` David Rientjes
2016-01-12 21:00 ` [RFC 3/3] oom: Do not try to sacrifice small children Michal Hocko
2016-01-12 21:00   ` Michal Hocko
2016-01-13  0:51   ` David Rientjes
2016-01-13  0:51     ` David Rientjes
2016-01-13  9:40     ` Michal Hocko
2016-01-13  9:40       ` Michal Hocko
2016-01-14  0:43       ` David Rientjes
2016-01-14  0:43         ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.10.1601191458100.7346@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.