All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] scripts/coccinelle: modernize &
@ 2016-02-17 23:16 ` Julia Lawall
  0 siblings, 0 replies; 16+ messages in thread
From: Julia Lawall @ 2016-02-17 23:16 UTC (permalink / raw)
  To: Julia Lawall
  Cc: kernel-janitors, Gilles Muller, Nicolas Palix, Michal Marek,
	cocci, linux-kernel, Nishanth Menon

& is no longer allowed in column 0, since Coccinelle 1.0.4.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 scripts/coccinelle/iterators/use_after_iter.cocci |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/coccinelle/iterators/use_after_iter.cocci b/scripts/coccinelle/iterators/use_after_iter.cocci
index f085f59..ce8cc9c 100644
--- a/scripts/coccinelle/iterators/use_after_iter.cocci
+++ b/scripts/coccinelle/iterators/use_after_iter.cocci
@@ -123,7 +123,7 @@ list_remove_head(x,c,...)
 |
 sizeof(<+...c...+>)
 |
-&c->member
+ &c->member
 |
 c = E
 |

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH] scripts/coccinelle: modernize &
@ 2016-02-17 23:16 ` Julia Lawall
  0 siblings, 0 replies; 16+ messages in thread
From: Julia Lawall @ 2016-02-17 23:16 UTC (permalink / raw)
  To: cocci

& is no longer allowed in column 0, since Coccinelle 1.0.4.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 scripts/coccinelle/iterators/use_after_iter.cocci |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/coccinelle/iterators/use_after_iter.cocci b/scripts/coccinelle/iterators/use_after_iter.cocci
index f085f59..ce8cc9c 100644
--- a/scripts/coccinelle/iterators/use_after_iter.cocci
+++ b/scripts/coccinelle/iterators/use_after_iter.cocci
@@ -123,7 +123,7 @@ list_remove_head(x,c,...)
 |
 sizeof(<+...c...+>)
 |
-&c->member
+ &c->member
 |
 c = E
 |


^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [Cocci] [PATCH] scripts/coccinelle: modernize &
@ 2016-02-17 23:16 ` Julia Lawall
  0 siblings, 0 replies; 16+ messages in thread
From: Julia Lawall @ 2016-02-17 23:16 UTC (permalink / raw)
  To: cocci

& is no longer allowed in column 0, since Coccinelle 1.0.4.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 scripts/coccinelle/iterators/use_after_iter.cocci |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/coccinelle/iterators/use_after_iter.cocci b/scripts/coccinelle/iterators/use_after_iter.cocci
index f085f59..ce8cc9c 100644
--- a/scripts/coccinelle/iterators/use_after_iter.cocci
+++ b/scripts/coccinelle/iterators/use_after_iter.cocci
@@ -123,7 +123,7 @@ list_remove_head(x,c,...)
 |
 sizeof(<+...c...+>)
 |
-&c->member
+ &c->member
 |
 c = E
 |

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: [PATCH] scripts/coccinelle: modernize &
  2016-02-17 23:16 ` Julia Lawall
  (?)
@ 2016-02-17 23:47   ` Nishanth Menon
  -1 siblings, 0 replies; 16+ messages in thread
From: Nishanth Menon @ 2016-02-17 23:47 UTC (permalink / raw)
  To: Julia Lawall
  Cc: kernel-janitors, Gilles Muller, Nicolas Palix, Michal Marek,
	cocci, linux-kernel

On 02/17/2016 05:16 PM, Julia Lawall wrote:
> & is no longer allowed in column 0, since Coccinelle 1.0.4.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> ---
>  scripts/coccinelle/iterators/use_after_iter.cocci |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/coccinelle/iterators/use_after_iter.cocci b/scripts/coccinelle/iterators/use_after_iter.cocci
> index f085f59..ce8cc9c 100644
> --- a/scripts/coccinelle/iterators/use_after_iter.cocci
> +++ b/scripts/coccinelle/iterators/use_after_iter.cocci
> @@ -123,7 +123,7 @@ list_remove_head(x,c,...)
>  |
>  sizeof(<+...c...+>)
>  |
> -&c->member
> + &c->member
>  |
>  c = E
>  |
> 


Verified with:
spatch --version
spatch byte-code version 1.0.4-00118-gc7cf750d1c44 compiled with OCaml
version 4.01.0


Tested-by: Nishanth Menon <nm@ti.com>

-- 
Regards,
Nishanth Menon

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] scripts/coccinelle: modernize &
@ 2016-02-17 23:47   ` Nishanth Menon
  0 siblings, 0 replies; 16+ messages in thread
From: Nishanth Menon @ 2016-02-17 23:47 UTC (permalink / raw)
  To: cocci

On 02/17/2016 05:16 PM, Julia Lawall wrote:
> & is no longer allowed in column 0, since Coccinelle 1.0.4.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> ---
>  scripts/coccinelle/iterators/use_after_iter.cocci |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/coccinelle/iterators/use_after_iter.cocci b/scripts/coccinelle/iterators/use_after_iter.cocci
> index f085f59..ce8cc9c 100644
> --- a/scripts/coccinelle/iterators/use_after_iter.cocci
> +++ b/scripts/coccinelle/iterators/use_after_iter.cocci
> @@ -123,7 +123,7 @@ list_remove_head(x,c,...)
>  |
>  sizeof(<+...c...+>)
>  |
> -&c->member
> + &c->member
>  |
>  c = E
>  |
> 


Verified with:
spatch --version
spatch byte-code version 1.0.4-00118-gc7cf750d1c44 compiled with OCaml
version 4.01.0


Tested-by: Nishanth Menon <nm@ti.com>

-- 
Regards,
Nishanth Menon

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [Cocci] [PATCH] scripts/coccinelle: modernize &
@ 2016-02-17 23:47   ` Nishanth Menon
  0 siblings, 0 replies; 16+ messages in thread
From: Nishanth Menon @ 2016-02-17 23:47 UTC (permalink / raw)
  To: cocci

On 02/17/2016 05:16 PM, Julia Lawall wrote:
> & is no longer allowed in column 0, since Coccinelle 1.0.4.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> ---
>  scripts/coccinelle/iterators/use_after_iter.cocci |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/coccinelle/iterators/use_after_iter.cocci b/scripts/coccinelle/iterators/use_after_iter.cocci
> index f085f59..ce8cc9c 100644
> --- a/scripts/coccinelle/iterators/use_after_iter.cocci
> +++ b/scripts/coccinelle/iterators/use_after_iter.cocci
> @@ -123,7 +123,7 @@ list_remove_head(x,c,...)
>  |
>  sizeof(<+...c...+>)
>  |
> -&c->member
> + &c->member
>  |
>  c = E
>  |
> 


Verified with:
spatch --version
spatch byte-code version 1.0.4-00118-gc7cf750d1c44 compiled with OCaml
version 4.01.0


Tested-by: Nishanth Menon <nm@ti.com>

-- 
Regards,
Nishanth Menon

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] scripts/coccinelle: modernize &
  2016-02-17 23:47   ` Nishanth Menon
  (?)
@ 2016-02-18  0:46     ` Julia Lawall
  -1 siblings, 0 replies; 16+ messages in thread
From: Julia Lawall @ 2016-02-18  0:46 UTC (permalink / raw)
  To: Nishanth Menon
  Cc: Julia Lawall, kernel-janitors, Gilles Muller, Nicolas Palix,
	Michal Marek, cocci, linux-kernel

On Wed, 17 Feb 2016, Nishanth Menon wrote:

> On 02/17/2016 05:16 PM, Julia Lawall wrote:
> > & is no longer allowed in column 0, since Coccinelle 1.0.4.
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> >
> > ---
> >  scripts/coccinelle/iterators/use_after_iter.cocci |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/coccinelle/iterators/use_after_iter.cocci b/scripts/coccinelle/iterators/use_after_iter.cocci
> > index f085f59..ce8cc9c 100644
> > --- a/scripts/coccinelle/iterators/use_after_iter.cocci
> > +++ b/scripts/coccinelle/iterators/use_after_iter.cocci
> > @@ -123,7 +123,7 @@ list_remove_head(x,c,...)
> >  |
> >  sizeof(<+...c...+>)
> >  |
> > -&c->member
> > + &c->member
> >  |
> >  c = E
> >  |
> >
>
>
> Verified with:
> spatch --version
> spatch byte-code version 1.0.4-00118-gc7cf750d1c44 compiled with OCaml
> version 4.01.0
>
>
> Tested-by: Nishanth Menon <nm@ti.com>

Thanks!

julia

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] scripts/coccinelle: modernize &
@ 2016-02-18  0:46     ` Julia Lawall
  0 siblings, 0 replies; 16+ messages in thread
From: Julia Lawall @ 2016-02-18  0:46 UTC (permalink / raw)
  To: cocci

On Wed, 17 Feb 2016, Nishanth Menon wrote:

> On 02/17/2016 05:16 PM, Julia Lawall wrote:
> > & is no longer allowed in column 0, since Coccinelle 1.0.4.
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> >
> > ---
> >  scripts/coccinelle/iterators/use_after_iter.cocci |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/coccinelle/iterators/use_after_iter.cocci b/scripts/coccinelle/iterators/use_after_iter.cocci
> > index f085f59..ce8cc9c 100644
> > --- a/scripts/coccinelle/iterators/use_after_iter.cocci
> > +++ b/scripts/coccinelle/iterators/use_after_iter.cocci
> > @@ -123,7 +123,7 @@ list_remove_head(x,c,...)
> >  |
> >  sizeof(<+...c...+>)
> >  |
> > -&c->member
> > + &c->member
> >  |
> >  c = E
> >  |
> >
>
>
> Verified with:
> spatch --version
> spatch byte-code version 1.0.4-00118-gc7cf750d1c44 compiled with OCaml
> version 4.01.0
>
>
> Tested-by: Nishanth Menon <nm@ti.com>

Thanks!

julia

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [Cocci] [PATCH] scripts/coccinelle: modernize &
@ 2016-02-18  0:46     ` Julia Lawall
  0 siblings, 0 replies; 16+ messages in thread
From: Julia Lawall @ 2016-02-18  0:46 UTC (permalink / raw)
  To: cocci

On Wed, 17 Feb 2016, Nishanth Menon wrote:

> On 02/17/2016 05:16 PM, Julia Lawall wrote:
> > & is no longer allowed in column 0, since Coccinelle 1.0.4.
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> >
> > ---
> >  scripts/coccinelle/iterators/use_after_iter.cocci |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/coccinelle/iterators/use_after_iter.cocci b/scripts/coccinelle/iterators/use_after_iter.cocci
> > index f085f59..ce8cc9c 100644
> > --- a/scripts/coccinelle/iterators/use_after_iter.cocci
> > +++ b/scripts/coccinelle/iterators/use_after_iter.cocci
> > @@ -123,7 +123,7 @@ list_remove_head(x,c,...)
> >  |
> >  sizeof(<+...c...+>)
> >  |
> > -&c->member
> > + &c->member
> >  |
> >  c = E
> >  |
> >
>
>
> Verified with:
> spatch --version
> spatch byte-code version 1.0.4-00118-gc7cf750d1c44 compiled with OCaml
> version 4.01.0
>
>
> Tested-by: Nishanth Menon <nm@ti.com>

Thanks!

julia

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] scripts/coccinelle: modernize &
  2016-02-17 23:16 ` Julia Lawall
  (?)
@ 2016-02-19 12:25   ` SF Markus Elfring
  -1 siblings, 0 replies; 16+ messages in thread
From: SF Markus Elfring @ 2016-02-19 12:25 UTC (permalink / raw)
  To: Julia Lawall
  Cc: kernel-janitors, cocci, linux-kernel, Gilles Muller,
	Harish Chegondi, Michal Marek, Nicolas Palix, Nishanth Menon

> & is no longer allowed in column 0, since Coccinelle 1.0.4.

This information corresponds to the support for handling of conjunctions
in the semantic patch language which was added with the software
release "Coccinelle 1.0.3".
https://systeme.lip6.fr/pipermail/cocci/2015-October/002634.html


> diff --git a/scripts/coccinelle/iterators/use_after_iter.cocci b/scripts/coccinelle/iterators/use_after_iter.cocci
> index f085f59..ce8cc9c 100644
> --- a/scripts/coccinelle/iterators/use_after_iter.cocci
> +++ b/scripts/coccinelle/iterators/use_after_iter.cocci
> @@ -123,7 +123,7 @@ list_remove_head(x,c,...)
>  |
>  sizeof(<+...c...+>)
>  |
> -&c->member
> + &c->member

The added space character is not in the first column of this SmPL script.

* Can it be that the additional character will be transformed according to
  special pretty-printing rules?
  https://github.com/coccinelle/coccinelle/issues/37

* Is such a change a possible workaround for open issues around
  the message "minus: parse error" (or software improvements
  which were developed in the meantime)?


>  |
>  c = E
>  |


Does the shown tweak need any further considerations?

Regards,
Markus

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] scripts/coccinelle: modernize &
@ 2016-02-19 12:25   ` SF Markus Elfring
  0 siblings, 0 replies; 16+ messages in thread
From: SF Markus Elfring @ 2016-02-19 12:25 UTC (permalink / raw)
  To: cocci

> & is no longer allowed in column 0, since Coccinelle 1.0.4.

This information corresponds to the support for handling of conjunctions
in the semantic patch language which was added with the software
release "Coccinelle 1.0.3".
https://systeme.lip6.fr/pipermail/cocci/2015-October/002634.html


> diff --git a/scripts/coccinelle/iterators/use_after_iter.cocci b/scripts/coccinelle/iterators/use_after_iter.cocci
> index f085f59..ce8cc9c 100644
> --- a/scripts/coccinelle/iterators/use_after_iter.cocci
> +++ b/scripts/coccinelle/iterators/use_after_iter.cocci
> @@ -123,7 +123,7 @@ list_remove_head(x,c,...)
>  |
>  sizeof(<+...c...+>)
>  |
> -&c->member
> + &c->member

The added space character is not in the first column of this SmPL script.

* Can it be that the additional character will be transformed according to
  special pretty-printing rules?
  https://github.com/coccinelle/coccinelle/issues/37

* Is such a change a possible workaround for open issues around
  the message "minus: parse error" (or software improvements
  which were developed in the meantime)?


>  |
>  c = E
>  |


Does the shown tweak need any further considerations?

Regards,
Markus

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [Cocci] [PATCH] scripts/coccinelle: modernize &
@ 2016-02-19 12:25   ` SF Markus Elfring
  0 siblings, 0 replies; 16+ messages in thread
From: SF Markus Elfring @ 2016-02-19 12:25 UTC (permalink / raw)
  To: cocci

> & is no longer allowed in column 0, since Coccinelle 1.0.4.

This information corresponds to the support for handling of conjunctions
in the semantic patch language which was added with the software
release "Coccinelle 1.0.3".
https://systeme.lip6.fr/pipermail/cocci/2015-October/002634.html


> diff --git a/scripts/coccinelle/iterators/use_after_iter.cocci b/scripts/coccinelle/iterators/use_after_iter.cocci
> index f085f59..ce8cc9c 100644
> --- a/scripts/coccinelle/iterators/use_after_iter.cocci
> +++ b/scripts/coccinelle/iterators/use_after_iter.cocci
> @@ -123,7 +123,7 @@ list_remove_head(x,c,...)
>  |
>  sizeof(<+...c...+>)
>  |
> -&c->member
> + &c->member

The added space character is not in the first column of this SmPL script.

* Can it be that the additional character will be transformed according to
  special pretty-printing rules?
  https://github.com/coccinelle/coccinelle/issues/37

* Is such a change a possible workaround for open issues around
  the message "minus: parse error" (or software improvements
  which were developed in the meantime)?


>  |
>  c = E
>  |


Does the shown tweak need any further considerations?

Regards,
Markus

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [Cocci] [PATCH] scripts/coccinelle: modernize &
  2016-02-19 12:25   ` SF Markus Elfring
  (?)
  (?)
@ 2016-02-19 12:31   ` Julia Lawall
  -1 siblings, 0 replies; 16+ messages in thread
From: Julia Lawall @ 2016-02-19 12:31 UTC (permalink / raw)
  To: cocci

> > diff --git a/scripts/coccinelle/iterators/use_after_iter.cocci b/scripts/coccinelle/iterators/use_after_iter.cocci
> > index f085f59..ce8cc9c 100644
> > --- a/scripts/coccinelle/iterators/use_after_iter.cocci
> > +++ b/scripts/coccinelle/iterators/use_after_iter.cocci
> > @@ -123,7 +123,7 @@ list_remove_head(x,c,...)
> >  |
> >  sizeof(<+...c...+>)
> >  |
> > -&c->member
> > + &c->member
>
> The added space character is not in the first column of this SmPL script.
>
> * Can it be that the additional character will be transformed according to
>   special pretty-printing rules?
>   https://github.com/coccinelle/coccinelle/issues/37

I don't understand the question.  Spaces in the script (at least before
and after the pattern) don't impact spaces in the source code.

> * Is such a change a possible workaround for open issues around
>   the message "minus: parse error" (or software improvements
>   which were developed in the meantime)?

No idea what is referred to here.  Maybe you don't like the parse errors,
but that is the errors that the parser generator generates.  You are
welcome to write a parser generator that produces bettwe messages if you
like.

> >  |
> >  c = E
> >  |
>
>
> Does the shown tweak need any further considerations?

No idea what is referred to here.

julia

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] scripts/coccinelle: modernize &
  2016-02-17 23:47   ` Nishanth Menon
  (?)
@ 2016-02-19 13:09     ` Michal Marek
  -1 siblings, 0 replies; 16+ messages in thread
From: Michal Marek @ 2016-02-19 13:09 UTC (permalink / raw)
  To: Nishanth Menon, Julia Lawall
  Cc: kernel-janitors, Gilles Muller, Nicolas Palix, cocci, linux-kernel

On 2016-02-18 00:47, Nishanth Menon wrote:
> On 02/17/2016 05:16 PM, Julia Lawall wrote:
>> & is no longer allowed in column 0, since Coccinelle 1.0.4.
>>
>> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
[...]
> Verified with:
> spatch --version
> spatch byte-code version 1.0.4-00118-gc7cf750d1c44 compiled with OCaml
> version 4.01.0
> 
> 
> Tested-by: Nishanth Menon <nm@ti.com>

Applied to kbuild.git#misc with Cc: stable.

Michal

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] scripts/coccinelle: modernize &
@ 2016-02-19 13:09     ` Michal Marek
  0 siblings, 0 replies; 16+ messages in thread
From: Michal Marek @ 2016-02-19 13:09 UTC (permalink / raw)
  To: cocci

On 2016-02-18 00:47, Nishanth Menon wrote:
> On 02/17/2016 05:16 PM, Julia Lawall wrote:
>> & is no longer allowed in column 0, since Coccinelle 1.0.4.
>>
>> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
[...]
> Verified with:
> spatch --version
> spatch byte-code version 1.0.4-00118-gc7cf750d1c44 compiled with OCaml
> version 4.01.0
> 
> 
> Tested-by: Nishanth Menon <nm@ti.com>

Applied to kbuild.git#misc with Cc: stable.

Michal

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [Cocci] [PATCH] scripts/coccinelle: modernize &
@ 2016-02-19 13:09     ` Michal Marek
  0 siblings, 0 replies; 16+ messages in thread
From: Michal Marek @ 2016-02-19 13:09 UTC (permalink / raw)
  To: cocci

On 2016-02-18 00:47, Nishanth Menon wrote:
> On 02/17/2016 05:16 PM, Julia Lawall wrote:
>> & is no longer allowed in column 0, since Coccinelle 1.0.4.
>>
>> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
[...]
> Verified with:
> spatch --version
> spatch byte-code version 1.0.4-00118-gc7cf750d1c44 compiled with OCaml
> version 4.01.0
> 
> 
> Tested-by: Nishanth Menon <nm@ti.com>

Applied to kbuild.git#misc with Cc: stable.

Michal

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2016-02-19 13:09 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-17 23:16 [PATCH] scripts/coccinelle: modernize & Julia Lawall
2016-02-17 23:16 ` [Cocci] " Julia Lawall
2016-02-17 23:16 ` Julia Lawall
2016-02-17 23:47 ` Nishanth Menon
2016-02-17 23:47   ` [Cocci] " Nishanth Menon
2016-02-17 23:47   ` Nishanth Menon
2016-02-18  0:46   ` Julia Lawall
2016-02-18  0:46     ` [Cocci] " Julia Lawall
2016-02-18  0:46     ` Julia Lawall
2016-02-19 13:09   ` Michal Marek
2016-02-19 13:09     ` [Cocci] " Michal Marek
2016-02-19 13:09     ` Michal Marek
2016-02-19 12:25 ` SF Markus Elfring
2016-02-19 12:25   ` [Cocci] " SF Markus Elfring
2016-02-19 12:25   ` SF Markus Elfring
2016-02-19 12:31   ` [Cocci] " Julia Lawall

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.