* [PATCH] net: ethernet: fix odd_ptr_err.cocci warnings
@ 2016-06-21 10:03 ` Julia Lawall
0 siblings, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2016-06-21 10:03 UTC (permalink / raw)
To: thloh
Cc: robh+dt, mark.rutland, peppe.cavallaro, alexandre.torgue, davem,
preid, dinguyen, netdev, devicetree, linux-kernel, thloh85,
cnphoon, thloh, kbuild-all
PTR_ERR should normally access the value just tested by IS_ERR
Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
CC: Tien Hock Loh <thloh@altera.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
This patch refers to the following code:
url:
https://github.com/0day-ci/linux/commits/thloh-altera-com/net-ethernet-Add-T
SE-PCS-support-to-dwmac-socfpga/20160621-164854
dwmac-socfpga.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
@@ -224,7 +224,7 @@ static int socfpga_dwmac_parse_data(stru
dev_err(dev,
"%s: ERROR: failed mapping tse control port\n",
__func__);
- return PTR_ERR(dwmac->pcs.sgmii_adapter_base);
+ return PTR_ERR(dwmac->pcs.tse_pcs_base);
}
}
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] net: ethernet: fix odd_ptr_err.cocci warnings
@ 2016-06-21 10:03 ` Julia Lawall
0 siblings, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2016-06-21 10:03 UTC (permalink / raw)
Cc: robh+dt, mark.rutland, peppe.cavallaro, alexandre.torgue, davem,
preid, dinguyen, netdev, devicetree, linux-kernel, thloh85,
cnphoon, thloh, kbuild-all
PTR_ERR should normally access the value just tested by IS_ERR
Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
CC: Tien Hock Loh <thloh@altera.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
This patch refers to the following code:
url:
https://github.com/0day-ci/linux/commits/thloh-altera-com/net-ethernet-Add-T
SE-PCS-support-to-dwmac-socfpga/20160621-164854
dwmac-socfpga.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
@@ -224,7 +224,7 @@ static int socfpga_dwmac_parse_data(stru
dev_err(dev,
"%s: ERROR: failed mapping tse control port\n",
__func__);
- return PTR_ERR(dwmac->pcs.sgmii_adapter_base);
+ return PTR_ERR(dwmac->pcs.tse_pcs_base);
}
}
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: ethernet: fix odd_ptr_err.cocci warnings
2016-06-21 10:03 ` Julia Lawall
(?)
@ 2016-06-23 19:21 ` David Miller
-1 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2016-06-23 19:21 UTC (permalink / raw)
To: julia.lawall
Cc: thloh, robh+dt, mark.rutland, peppe.cavallaro, alexandre.torgue,
preid, dinguyen, netdev, devicetree, linux-kernel, thloh85,
cnphoon, kbuild-all
From: Julia Lawall <julia.lawall@lip6.fr>
Date: Tue, 21 Jun 2016 12:03:28 +0200 (CEST)
> PTR_ERR should normally access the value just tested by IS_ERR
>
> Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
>
> CC: Tien Hock Loh <thloh@altera.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
This doesn't apply to any of my tree(s).
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-23 19:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-21 10:03 [PATCH] net: ethernet: fix odd_ptr_err.cocci warnings Julia Lawall
2016-06-21 10:03 ` Julia Lawall
2016-06-23 19:21 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.