All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: Yann Droneaud <ydroneaud@opteya.com>
Cc: Michal Marek <mmarek@suse.com>,
	Gilles Muller <Gilles.Muller@lip6.fr>,
	Nicolas Palix <nicolas.palix@imag.fr>, Tejun Heo <tj@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org,
	Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH v2 1/3] coccinelle: also catch kzfree() issues
Date: Tue, 21 Jun 2016 13:17:35 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.10.1606211316530.2882@hadrien> (raw)
In-Reply-To: <1466507681.30939.14.camel@opteya.com>

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1567 bytes --]



On Tue, 21 Jun 2016, Yann Droneaud wrote:

> Hi,
>
> Le mardi 21 juin 2016 à 11:43 +0200, Michal Marek a écrit :
> > Dne 20.6.2016 v 22:21 Julia Lawall napsal(a):
> > > On Mon, 20 Jun 2016, Michal Marek wrote:
> > > On 2016-05-23 17:18, Julia Lawall wrote:
> > > > > On Mon, 23 May 2016, Yann Droneaud wrote:
> > > > >
> > > > > > Since commit 3ef0e5ba4673 ('slab: introduce kzfree()'),
> > > > > > kfree() is no more the only function to be considered:
> > > > > > kzfree() should be recognized too.
> > > > > >
> > > > > > In particular, kzfree() must not be called on memory
> > > > > > allocated through devm_*() functions.
> > > > > >
> > > > > > Cc: Johannes Weiner <hannes@cmpxchg.org>
> > > > > > Signed-off-by: Yann Droneaud <ydroneaud@opteya.com>
> > > > >
> > > > > Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> > > >
> > > > Hi Julia,
> > > >
> > > > does your ACK apply to the other two patches as well?
> > >
> > > Sorry, I seem to have missed the other two.  I have reviewed them
> > > now, and the ack applies to all three.  Thanks for checking on it.
> >
>
> Back in February, those two other patches were already Acked-by:
>
> http://lkml.kernel.org/r/alpine.DEB.2.10.1602161818100.2685@hadrien
> http://lkml.kernel.org/r/alpine.DEB.2.10.1602161819340.2685@hadrien
>
> I've (re)sent them with added Acked-by:, and thought it would not
> require further Acked-by:.
>
> Anyway, this one was new and required proper review. Thanks a lot.

Thanks for the reminder.  Since they are comitted now, things are going in
the right direction.

julia

WARNING: multiple messages have this Message-ID (diff)
From: julia.lawall@lip6.fr (Julia Lawall)
To: cocci@systeme.lip6.fr
Subject: [Cocci] [PATCH v2 1/3] coccinelle: also catch kzfree() issues
Date: Tue, 21 Jun 2016 13:17:35 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.10.1606211316530.2882@hadrien> (raw)
In-Reply-To: <1466507681.30939.14.camel@opteya.com>



On Tue, 21 Jun 2016, Yann Droneaud wrote:

> Hi,
>
> Le mardi 21 juin 2016 ? 11:43 +0200, Michal Marek a ?crit?:
> > Dne 20.6.2016 v 22:21 Julia Lawall napsal(a):
> > > On Mon, 20 Jun 2016, Michal Marek wrote:
> > > On 2016-05-23 17:18, Julia Lawall wrote:
> > > > > On Mon, 23 May 2016, Yann Droneaud wrote:
> > > > >
> > > > > > Since commit 3ef0e5ba4673 ('slab: introduce kzfree()'),
> > > > > > kfree() is no more the only function to be considered:
> > > > > > kzfree() should be recognized too.
> > > > > >
> > > > > > In particular, kzfree() must not be called on memory
> > > > > > allocated through devm_*() functions.
> > > > > >
> > > > > > Cc: Johannes Weiner <hannes@cmpxchg.org>
> > > > > > Signed-off-by: Yann Droneaud <ydroneaud@opteya.com>
> > > > >
> > > > > Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> > > >
> > > > Hi Julia,
> > > >
> > > > does your ACK apply to the other two patches as well?
> > >
> > > Sorry, I seem to have missed the other two.??I have reviewed them
> > > now, and the ack applies to all three.??Thanks for checking on it.
> >
>
> Back in February, those two other patches were already Acked-by:
>
> http://lkml.kernel.org/r/alpine.DEB.2.10.1602161818100.2685 at hadrien
> http://lkml.kernel.org/r/alpine.DEB.2.10.1602161819340.2685 at hadrien
>
> I've (re)sent them with added Acked-by:, and thought it would not
> require further Acked-by:.
>
> Anyway, this one was new and required proper review. Thanks a lot.

Thanks for the reminder.  Since they are comitted now, things are going in
the right direction.

julia

  reply	other threads:[~2016-06-21 11:30 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-23 15:07 [PATCH v2 0/3] coccinelle: catchup on memory allocation functions Yann Droneaud
2016-05-23 15:07 ` [Cocci] " Yann Droneaud
2016-05-23 15:07 ` [PATCH v2 1/3] coccinelle: also catch kzfree() issues Yann Droneaud
2016-05-23 15:07   ` [Cocci] " Yann Droneaud
2016-05-23 15:18   ` Julia Lawall
2016-05-23 15:18     ` [Cocci] " Julia Lawall
2016-06-20 13:24     ` Michal Marek
2016-06-20 13:24       ` [Cocci] " Michal Marek
2016-06-20 20:21       ` Julia Lawall
2016-06-20 20:21         ` [Cocci] " Julia Lawall
2016-06-21  9:43         ` Michal Marek
2016-06-21  9:43           ` [Cocci] " Michal Marek
2016-06-21 11:14           ` Yann Droneaud
2016-06-21 11:14             ` [Cocci] " Yann Droneaud
2016-06-21 11:17             ` Julia Lawall [this message]
2016-06-21 11:17               ` Julia Lawall
2016-05-23 15:07 ` [PATCH v2 2/3] coccinelle: recognize more devm_* memory allocation functions Yann Droneaud
2016-05-23 15:07   ` [Cocci] " Yann Droneaud
2016-05-23 15:07 ` [PATCH v2 3/3] coccinelle: catch krealloc() on devm_*() allocated memory Yann Droneaud
2016-05-23 15:07   ` [Cocci] " Yann Droneaud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.10.1606211316530.2882@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=Gilles.Muller@lip6.fr \
    --cc=cocci@systeme.lip6.fr \
    --cc=gregkh@linuxfoundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.com \
    --cc=nicolas.palix@imag.fr \
    --cc=tj@kernel.org \
    --cc=ydroneaud@opteya.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.