[PATCH] Moved the trailing comment end quote to next line.

[PATCH] Moved the trailing comment end quote to next line.

[gs0510]

Checkpatch displays error that the comment endings should be in separate
line, should not end in the same line as the comment.

Signed-off-by: Gargi Sharma <gs051095@gmail.com>
---
 drivers/staging/ks7010/eap_packet.h | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/ks7010/eap_packet.h b/drivers/staging/ks7010/eap_packet.h
index 16a392a..0a9ab097 100644
--- a/drivers/staging/ks7010/eap_packet.h
+++ b/drivers/staging/ks7010/eap_packet.h
@@ -52,15 +52,18 @@ struct ieee802_1x_eapol_key {
 	unsigned char type;
 	unsigned short key_length;
 	/* does not repeat within the life of the keying material used to
-	 * encrypt the Key field; 64-bit NTP timestamp MAY be used here */
+	 * encrypt the Key field; 64-bit NTP timestamp MAY be used here
+	*/
 	unsigned char replay_counter[IEEE8021X_REPLAY_COUNTER_LEN];
 	unsigned char key_iv[IEEE8021X_KEY_IV_LEN];	/* cryptographically random number */
 	unsigned char key_index;	/* key flag in the most significant bit:
 					 * 0 = broadcast (default key),
 					 * 1 = unicast (key mapping key); key index is in the
-					 * 7 least significant bits */
+					 * 7 least significant bits
+					 */
 	/* HMAC-MD5 message integrity check computed with MS-MPPE-Send-Key as
-	 * the key */
+	 * the key
+	*/
 	unsigned char key_signature[IEEE8021X_KEY_SIGN_LEN];
 
 	/* followed by key: if packet body length = 44 + key length, then the
@@ -68,7 +71,8 @@ struct ieee802_1x_eapol_key {
 	 * if packet body length = 44, key field is absent and key_length
 	 * represents the number of least significant octets from
 	 * MS-MPPE-Send-Key attribute to be used as the keying material;
-	 * RC4 key used in encryption = Key-IV + MS-MPPE-Recv-Key */
+	 * RC4 key used in encryption = Key-IV + MS-MPPE-Recv-Key
+	*/
 } __attribute__ ((packed));
 
 #define WPA_NONCE_LEN 32
-- 
2.9.2

Re: [Outreachy kernel] [PATCH] Moved the trailing comment end quote to next line.

[Julia Lawall]

Actually, the From name in your message should be the same as in your
Signed off by line, which should be your real name.

On Mon, 12 Sep 2016, gs0510 wrote:

> Checkpatch displays error that the comment endings should be in separate
> line, should not end in the same line as the comment.
>
> Signed-off-by: Gargi Sharma <gs051095@gmail.com>
> ---
>  drivers/staging/ks7010/eap_packet.h | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/ks7010/eap_packet.h b/drivers/staging/ks7010/eap_packet.h
> index 16a392a..0a9ab097 100644
> --- a/drivers/staging/ks7010/eap_packet.h
> +++ b/drivers/staging/ks7010/eap_packet.h
> @@ -52,15 +52,18 @@ struct ieee802_1x_eapol_key {
>  	unsigned char type;
>  	unsigned short key_length;
>  	/* does not repeat within the life of the keying material used to
> -	 * encrypt the Key field; 64-bit NTP timestamp MAY be used here */
> +	 * encrypt the Key field; 64-bit NTP timestamp MAY be used here
> +	*/

It doesn't look like this line is lines up properly with the others.
Also, the first /* should be on a separate line too.

julia

>  	unsigned char replay_counter[IEEE8021X_REPLAY_COUNTER_LEN];
>  	unsigned char key_iv[IEEE8021X_KEY_IV_LEN];	/* cryptographically random number */
>  	unsigned char key_index;	/* key flag in the most significant bit:
>  					 * 0 = broadcast (default key),
>  					 * 1 = unicast (key mapping key); key index is in the
> -					 * 7 least significant bits */
> +					 * 7 least significant bits
> +					 */
>  	/* HMAC-MD5 message integrity check computed with MS-MPPE-Send-Key as
> -	 * the key */
> +	 * the key
> +	*/
>  	unsigned char key_signature[IEEE8021X_KEY_SIGN_LEN];
>
>  	/* followed by key: if packet body length = 44 + key length, then the
> @@ -68,7 +71,8 @@ struct ieee802_1x_eapol_key {
>  	 * if packet body length = 44, key field is absent and key_length
>  	 * represents the number of least significant octets from
>  	 * MS-MPPE-Send-Key attribute to be used as the keying material;
> -	 * RC4 key used in encryption = Key-IV + MS-MPPE-Recv-Key */
> +	 * RC4 key used in encryption = Key-IV + MS-MPPE-Recv-Key
> +	*/
>  } __attribute__ ((packed));
>
>  #define WPA_NONCE_LEN 32
> --
> 2.9.2
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160912164440.9174-1-gs051095%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [PATCH] Moved the trailing comment end quote to next line.

[Greg KH]

On Mon, Sep 12, 2016 at 10:14:40PM +0530, gs0510 wrote:
> Checkpatch displays error that the comment endings should be in separate
> line, should not end in the same line as the comment.
> 
> Signed-off-by: Gargi Sharma <gs051095@gmail.com>
> ---
>  drivers/staging/ks7010/eap_packet.h | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)

Your From: line should match your signed-off-by: line please.

Also, look at the subject, it doesn't say what part of the kernel is
being modified.  Please fix that up as well when you resend this.

thanks,

greg k-h

Re: [Outreachy kernel] [PATCH] Moved the trailing comment end quote to next line.

[Gargi Sharma]

[-- Attachment #1: Type: text/plain, Size: 3303 bytes --]

Noted the mistakes. Sending a new patch fixing them.

Thanks!
Gargi

On Mon, Sep 12, 2016 at 10:25 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:

> Actually, the From name in your message should be the same as in your
> Signed off by line, which should be your real name.
>
> On Mon, 12 Sep 2016, gs0510 wrote:
>
> > Checkpatch displays error that the comment endings should be in separate
> > line, should not end in the same line as the comment.
> >
> > Signed-off-by: Gargi Sharma <gs051095@gmail.com>
> > ---
> >  drivers/staging/ks7010/eap_packet.h | 12 ++++++++----
> >  1 file changed, 8 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/staging/ks7010/eap_packet.h
> b/drivers/staging/ks7010/eap_packet.h
> > index 16a392a..0a9ab097 100644
> > --- a/drivers/staging/ks7010/eap_packet.h
> > +++ b/drivers/staging/ks7010/eap_packet.h
> > @@ -52,15 +52,18 @@ struct ieee802_1x_eapol_key {
> >       unsigned char type;
> >       unsigned short key_length;
> >       /* does not repeat within the life of the keying material used to
> > -      * encrypt the Key field; 64-bit NTP timestamp MAY be used here */
> > +      * encrypt the Key field; 64-bit NTP timestamp MAY be used here
> > +     */
>
> It doesn't look like this line is lines up properly with the others.
> Also, the first /* should be on a separate line too.
>
> julia
>
> >       unsigned char replay_counter[IEEE8021X_REPLAY_COUNTER_LEN];
> >       unsigned char key_iv[IEEE8021X_KEY_IV_LEN];     /*
> cryptographically random number */
> >       unsigned char key_index;        /* key flag in the most
> significant bit:
> >                                        * 0 = broadcast (default key),
> >                                        * 1 = unicast (key mapping key);
> key index is in the
> > -                                      * 7 least significant bits */
> > +                                      * 7 least significant bits
> > +                                      */
> >       /* HMAC-MD5 message integrity check computed with MS-MPPE-Send-Key
> as
> > -      * the key */
> > +      * the key
> > +     */
> >       unsigned char key_signature[IEEE8021X_KEY_SIGN_LEN];
> >
> >       /* followed by key: if packet body length = 44 + key length, then
> the
> > @@ -68,7 +71,8 @@ struct ieee802_1x_eapol_key {
> >        * if packet body length = 44, key field is absent and key_length
> >        * represents the number of least significant octets from
> >        * MS-MPPE-Send-Key attribute to be used as the keying material;
> > -      * RC4 key used in encryption = Key-IV + MS-MPPE-Recv-Key */
> > +      * RC4 key used in encryption = Key-IV + MS-MPPE-Recv-Key
> > +     */
> >  } __attribute__ ((packed));
> >
> >  #define WPA_NONCE_LEN 32
> > --
> > 2.9.2
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/
> msgid/outreachy-kernel/20160912164440.9174-1-gs051095%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >
>

[-- Attachment #2: Type: text/html, Size: 4755 bytes --]